a word of caution. according to INFRA-18748, asf infra is going to be
cutting out blind PR building. So we'll need to be sure that precommit
integration works e.g. testing PRs because there's a JIRA that a
whitelisted contributor has associated and put in patch available
status.
On Mon, Jul 22, 20
Thanks Wei-Chiu for starting this discussion.
+1 (non-binding) for turning code review to GitHub PR and keep other
comments/discussions on JIRA.
1. In my experience, JIRA is better at tracking and recording information.
2. It is confused that no guide (`How to contribute`) about submit PR to
JIRA
Although we will use github with PRs, I'd still prefer adding a +1 as a
jira comment stating which PR was the last and approved one among the many.
On Tue, Jul 23, 2019 at 11:22 AM Steve Loughran
wrote:
> On Mon, Jul 22, 2019 at 7:29 PM Eric Badger
> wrote:
>
> > Where would JIRA fit into the P
On Mon, Jul 22, 2019 at 7:29 PM Eric Badger
wrote:
> Where would JIRA fit into the PR workflow? Would we file JIRAs just to
> track github PRs and have all of the discussion on the PR?
>
>
Every code contribution needs its JIRA for: tracking, release notes, cross
referencing; every committed patc
Where would JIRA fit into the PR workflow? Would we file JIRAs just to
track github PRs and have all of the discussion on the PR?
Eric
On Mon, Jul 22, 2019 at 1:10 PM Dinesh Chitlangia
wrote:
> +1 Absolutely. It also makes it easy/clean for reviewers to leave specific
> comments and the authors
+1 Absolutely. It also makes it easy/clean for reviewers to leave specific
comments and the authors can make incremental changes without the hassles
of generating iterative patch files.
Thanks,
Dinesh
On Mon, Jul 22, 2019 at 2:06 PM Wei-Chiu Chuang wrote:
> Historically, Hadoop developers cr
Historically, Hadoop developers create patches and attache them to JIRA,
andthen the Yetus bot runs precommit against the patch in the JIRA.
The Github PR is more convenient for code review and less hassle for
committers to merge a commit. I am proposing for the community to prefer
Github PR over
