Hello Lorenzo,
Thursday, September 17, 2009, 4:44:04 PM, you wrote:
LF> In contrib/hbtip/sendmail.prg these lines:
LF> IF !( Right( cBody, 2 ) == hb_osNewLine() )
LF> cBody += hb_osNewLine()
LF> ENDIF
LF> should be:
LF> IF !( Right( cBody, 2 ) == Chr( 13 ) + Chr( 10
Lorenzo Fiorini wrote:
In contrib/hbtip/sendmail.prg these lines:
...
the standard requires Cr+Lf and servers like QMail reject messages
with ONLY Lf reporting:
451 See http://pobox.com/~djb/docs/smtplf.html
while others like Postfix accept them but report:
354 End data with .
Using Chr( 13 )
On 9/17/2009 10:44 AM, Lorenzo Fiorini wrote:
In contrib/hbtip/sendmail.prg these lines:
IF !( Right( cBody, 2 ) == hb_osNewLine() )
cBody += hb_osNewLine()
ENDIF
should be:
IF !( Right( cBody, 2 ) == Chr( 13 ) + Chr( 10 ) )
cBody += Chr( 13 ) + Chr( 10
On Thu, 17 Sep 2009, Viktor Szakáts wrote:
> > > i think (from a quick skim of the code) that the correct solution
> > > would be deleting these three altogether, and the smtp client seems to
> > > already add this in it's commit(), which should be enough (and along
> > > these lines, appendin
i think (from a quick skim of the code) that the correct solution
would be deleting these three altogether, and the smtp client seems
to
already add this in it's commit(), which should be enough (and along
these lines, appending anything to cbody is wrong).
I've tried to remove them but then
On Thu, Sep 17, 2009 at 5:41 PM, Tamas TEVESZ wrote:
> i think (from a quick skim of the code) that the correct solution
> would be deleting these three altogether, and the smtp client seems to
> already add this in it's commit(), which should be enough (and along
> these lines, appending anythin
On Thu, 17 Sep 2009, Lorenzo Fiorini wrote:
> In contrib/hbtip/sendmail.prg these lines:
>
> IF !( Right( cBody, 2 ) == hb_osNewLine() )
> cBody += hb_osNewLine()
> ENDIF
>
> should be:
>
> IF !( Right( cBody, 2 ) == Chr( 13 ) + Chr( 10 ) )
> cBody
Okay, I'll make it.
Brgds,
Viktor
On 2009 Sep 17, at 17:05, Lorenzo Fiorini wrote:
On Thu, Sep 17, 2009 at 4:51 PM, Viktor Szakáts 0...@syenar.hu> wrote:
Pls commit it.
Sorry, my local repo is quite "customized" and I use mercurial as
local VCS so for me commit to svn is a "big" task.
Cou
On Thu, Sep 17, 2009 at 4:51 PM, Viktor Szakáts wrote:
> Pls commit it.
Sorry, my local repo is quite "customized" and I use mercurial as
local VCS so for me commit to svn is a "big" task.
Could you kindly add this small change to your next commit?
best regards,
Lorenzo
___
Hi Lorenzo,
Seems okay to me.
Current solution is wrong anyway, since Right( , 2 )
will rarely be equal to hb_osNewLine() on systems with
1 char long EOLs.
Pls commit it.
Brgds,
Viktor
On 2009 Sep 17, at 16:44, Lorenzo Fiorini wrote:
In contrib/hbtip/sendmail.prg these lines:
IF !( Ri
In contrib/hbtip/sendmail.prg these lines:
IF !( Right( cBody, 2 ) == hb_osNewLine() )
cBody += hb_osNewLine()
ENDIF
should be:
IF !( Right( cBody, 2 ) == Chr( 13 ) + Chr( 10 ) )
cBody += Chr( 13 ) + Chr( 10 )
ENDIF
the standard requires Cr+Lf and serve
11 matches
Mail list logo
