you then could take a look at my changes.
Best Regards,
Alexander Stephan
-Original Message-
From: PR Bot
Sent: Friday, June 30, 2023 1:23 PM
To: haproxy@formilux.org
Cc: Stephan, Alexander
Subject: [PR] Implement fetch for arbitrary TLV payloads
[You don't often get email from ha
Dear HAProxy-maintainers,
As proposed by my colleague Christian Menges in [1], I’ve implemented support
for fetching arbitrary TLV values for PROXY protocol V2 via a sample fetch. It
can be used by calling ‘fc_pp_tlv’ with the numerical value of the desired TLV
type. This also fixes issue [2].
Best,
Alexander
-Original Message-
From: Willy Tarreau
Sent: Thursday, August 10, 2023 9:18 AM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY
protocol v2 TLV values
[You don't often get em
risky.
If there should be a nit that you quickly want to change, feel free to. I am
not upset about it at all.
Best,
Alexander
-Original Message-
From: Willy Tarreau
Sent: Sunday, August 13, 2023 10:01 AM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH] MEDIUM: sample:
Hi Willy,
Did you already have the chance to take a look at the updated patches?
No hurry though, I just wanted to make sure that the message didn't get lost.
As mentioned, I am aware that sending individual patches is better in the
common case.
If that is a problem here, please just let me know
Hi Willy,
> finally back to this! Overall it's a great and very clean series, I really
> want to thank you for this high quality work!
Thanks for the compliment, really glad to hear! :)
> Yeah it initially gave me a bit of head scratching when reading this part but
> I understood what you did a
Hi Willy,
> And I was wrong, they were indeed for the first one. However I had to also
> remove the NOT_LAST from the intermediate patches using the list_for_each().
> I put quotes around the symbolic names in the doc to make it clearer which
> one was to be used and which one it corresponds to
,
Alexander
From: Илья Шипицин
Sent: Thursday, August 31, 2023 8:56 PM
To: Willy Tarreau
Cc: Stephan, Alexander ; haproxy@formilux.org
Subject: Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY
protocol v2 TLV values
You don't often get email from
chipits...@gmai
Hi all,
As a follow-up to my last patches that allow to fetch any TLV in the frontend,
I have also implemented similar functionality in the backend that allows to
send out TLVs of any type.
This is an addition to the existing proxy-protocol-v2-option constants like
crc32c. Unlike the pre-def
From fb8714c5aebd7fe957264d0f2234182f55f952fe Mon Sep 17 00:00:00 2001
From: Alexander Stephan
mailto:alexander.step...@sap.com>>
Date: Fri, 15 Sep 2023 12:38:46 +0200
Subject: [PATCH 1/4] MEDIUM: server: Parse generic type-value pairs as
proxy-v2-options
This commit introduces a generic server-
From 84608ed754c1a92e85e03036e8b0cd0949721ffb Mon Sep 17 00:00:00 2001
From: Alexander Stephan
Date: Fri, 15 Sep 2023 12:42:36 +0200
Subject: [PATCH 2/4] MEDIUM: connection: Send out generically allocated
proxy-v2-options
This commit removes the previous limitations on the existing, fixed PPv2 T
From cc8fe58a8d2f8d47b03d03fd1048fe1b9babca70 Mon Sep 17 00:00:00 2001
From: Alexander Stephan
Date: Fri, 15 Sep 2023 12:18:10 +0200
Subject: [PATCH 3/4] LOW: connection: Add TLV update function
Until now, it was not possible to deliberatily change received TLVs
that are stored within a connectio
From da4dc50153fe6cc7e562b63439dd8be4846e0dcf Mon Sep 17 00:00:00 2001
From: Alexander Stephan
Date: Fri, 15 Sep 2023 12:25:03 +0200
Subject: [PATCH 4/4] MEDIUM: tcp-act: Add new set-tlv TCP action for PPv2 TLVs
This commit adds an action called set-tlv() that allows to directly
update the TLV d
Hi,
I am back from my vacation and I wanted to ask whether somebody has had the
chance to look at this.
A short ACK that the changes will be reviewed would be much appreciated.
Best,
Alexander
SAP SE Germany
From: Stephan, Alexander
Sent: Friday, September 15, 2023 6:39 PM
To: haproxy
archive?
If not, I can of course send them again.
Best,
Alexander
-Original Message-
From: Willy Tarreau
Sent: Tuesday, October 3, 2023 11:27 AM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH 0/4] Support server-side sending and forwarding of
arbitrary PPv2 TLVs
From fb8714c5aebd7fe957264d0f2234182f55f952fe Mon Sep 17 00:00:00 2001
From: Alexander Stephan
Date: Fri, 15 Sep 2023 12:38:46 +0200
Subject: [PATCH 1/4] MEDIUM: server: Parse generic type-value pairs as
proxy-v2-options
This commit introduces a generic server-side parsing of type-value pair
argu
From 84608ed754c1a92e85e03036e8b0cd0949721ffb Mon Sep 17 00:00:00 2001
From: Alexander Stephan
mailto:alexander.step...@sap.com>>
Date: Fri, 15 Sep 2023 12:42:36 +0200
Subject: [PATCH 2/4] MEDIUM: connection: Send out generically allocated
proxy-v2-options
This commit removes the previous limita
From cc8fe58a8d2f8d47b03d03fd1048fe1b9babca70 Mon Sep 17 00:00:00 2001
From: Alexander Stephan
mailto:alexander.step...@sap.com>>
Date: Fri, 15 Sep 2023 12:18:10 +0200
Subject: [PATCH 3/4] LOW: connection: Add TLV update function
Until now, it was not possible to deliberatily change received TLVs
From da4dc50153fe6cc7e562b63439dd8be4846e0dcf Mon Sep 17 00:00:00 2001
From: Alexander Stephan
mailto:alexander.step...@sap.com>>
Date: Fri, 15 Sep 2023 12:25:03 +0200
Subject: [PATCH 4/4] MEDIUM: tcp-act: Add new set-tlv TCP action for PPv2 TLVs
This commit adds an action called set-tlv() that
Hi Willy,
Ah, what a pity. Anyway, I sent them again with you in CC. Does it look alright
now?
Best,
Alexander
-Original Message-
From: Willy Tarreau
Sent: Wednesday, October 4, 2023 3:21 PM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH 0/4] Support server-side
Hi Willy,
Do you know whether this can/will make it to the next release? It would be
crucial for us to know.
Best,
Alexander
-Original Message-
From: Willy Tarreau
Sent: Thursday, October 5, 2023 2:42 PM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH 0/4
OXY V1 protocol */
+ { "send-proxy-v2",srv_parse_send_proxy_v2,0, 1, 1 },
/* Enforce use of PROXY V2 protocol */
+ { "set-proxy-v2-tlv-fmt", srv_parse_set_proxy_v2_tlv_fmt, 0, 1, 1 },
/* Set TLV of PROXY V2 protocol */
+ { "shard
ideas on how to
tackle the issue I described above?
Disabling the default-server support could be another solution. I am very
interested in your opinion on this.
Best,
Alexander
-----Original Message-
From: Willy Tarreau
Sent: Monday, October 23, 2023 2:33 PM
To: Stephan, Alexander
Cc:
else {
+ /* Create empty TLV as no value was specified */
+ ret += make_tlv(&buf[ret], (buf_len - ret),
srv_tlv->type, 0, NULL);
+ }
+ }
+ }
+
+ /* Handle predefined TLVs as
ly Tarreau
Sent: Friday, October 27, 2023 4:22 PM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH 2/4] MEDIUM: connection: Send out generically allocated
proxy-v2-options
Hi Alexander,
On Fri, Oct 27, 2023 at 02:12:10PM +0000, Stephan, Alexander wrote:
> > BTW, plea
Hi Willy,
Sorry, my email client probably did something weird...
I attached them now, should hopefully prevent any reformatting.
Best,
Alexander
-Original Message-
From: Willy Tarreau
Sent: Friday, November 3, 2023 5:52 PM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re
uent patch.
Again, I don't mind if you make the SMP_VAL_*. I tried the
sess_build_logline() and it seems to work perfectly. The tests also still pass,
so looks good. I would like to provide a second patch for this next week, if
this okay.
Best,
Alexander
-Original Message-
From: Will
strm, replace->area,
replace->size, &srv_tlv->fmt);
?
It seems to achieve the behavior you described regarding the health checks,
right? If that's alright, I will send the corresponding patch.
Best,
Alexander
-Original Message-
From: Willy Tarreau
Sent: Saturday, Novembe
Hi everyone,
My colleague Christian Norbert Menges (in CC) has written a patch that I now
polished and made ready for submission.
It adds a converter function to convert bytes, that are assumed to be saved in
little endian, into decimal representation, similarly to the existing be2dec
sample fe
tation, similarly to the existing be2dec sample
fet...
github.com
Thanks and best regards,
Alexander
________
From: Stephan, Alexander
Sent: Friday, March 14, 2025 2:43 PM
To: haproxy@formilux.org
Cc: Menges, Christian Norbert
Subject: [PATCH]: MINOR: sample: Add le2dec
30 matches
Mail list logo
