Re: [PATCH] BUG/MINOR: 51 degree: handle a possible strdup() failure

On 02. 01. 2025. 21:40, Илья Шипицин wrote: > Honestly, I think those elements must be deallocated on program exit, > not only if something failed during allocation. > > but I did not check that > That is correct. However, the calloc() result is not checked before strdup() either, so the patch

Re: [PATCH] BUG/MINOR: 51 degree: handle a possible strdup() failure

чт, 2 янв. 2025 г. в 21:46, Miroslav Zagorac : > On 02. 01. 2025. 21:40, Илья Шипицин wrote: > > Honestly, I think those elements must be deallocated on program exit, > > not only if something failed during allocation. > > > > but I did not check that > > > > That is correct. However, the calloc(

[PATCH 0/1] Add 4 new sample fetches to get information from ClientHello message

This patch includes functionality to add sample fetches to get ciphers, supported groups, key shares and sigalgs from the ClientHello message. This will help enhance observability and help direct traffic to different backends based on different algorithms supported by the client for key exchange

[PATCH 1/1] MINOR: sample: Add sample fetches for enhanced observability for TLS ClientHello

Add new sample fetches to get the ciphers, supported groups, key shares and signature algorithms that the client supports during a TLS handshake as part of the contents of a TLS ClientHello. Currently we can get the following contents of the ClientHello message: SNI(req_ssl_sni) and TLS protocol

Re: [PATCH] BUG/MINOR: 51 degree: handle a possible strdup() failure

Honestly, I think those elements must be deallocated on program exit, not only if something failed during allocation. but I did not check that чт, 2 янв. 2025 г. в 20:13, Miroslav Zagorac : > On 02. 01. 2025. 15:18, Ilia Shipitsin wrote: > > This defect was found by the coccinelle script "unchec

Re: [PATCH] BUG/MINOR: 51 degree: handle a possible strdup() failure

Hi Ilya, On Thu, Jan 02, 2025 at 10:02:01PM +0100, ??? wrote: > ??, 2 ???. 2025 ?. ? 21:46, Miroslav Zagorac : > > > On 02. 01. 2025. 21:40, ??? wrote: > > > Honestly, I think those elements must be deallocated on program exit, > > > not only if something failed during allocatio

Re: [PATCH] BUG/MINOR: 51 degree: handle a possible strdup() failure

On 02. 01. 2025. 22:02, Илья Шипицин wrote: > I did not pretend to add "calloc" check for this patch. > we have dedicated *dev/coccinelle/unchecked-calloc.cocci *script which > allows us to detect unchecked "calloc". no worry, it won't be forgotten > OK then; thank you for your help. -- Mirosl

Re: HAproxy load balancing query

Hi Willy, Good day to you. After long time I'm requesting this query as well. with HA proxy are we able to load balance udp traffic? Best Regards, Shehan Jayawardane Head of Engineering sheh...@nvision.lk www.thryvz.com [cid:a58c8d85-df93-459d-8064-e5a1ed2a6d92]

Re: HAproxy load balancing query

Hi Shehan. On 2025-01-02 (Do.) 13:13, Shehan Jayawardane wrote: Hi Willy, Thanks for the information. Actually, our UDP traffic are radius requests to be forwarded to 1812, and 1813 UDP ports. we need to load balance these requests. Can we load balance these UDP requests? Looks like you hav

Re: HAproxy load balancing query

Hi Willy, Thanks for the information. Actually, our UDP traffic are radius requests to be forwarded to 1812, and 1813 UDP ports. we need to load balance these requests. Can we load balance these UDP requests? Best Regards, Shehan Jayawardane Head of Engineering sheh...@nvision.lk www.thryvz.co

[PATCH] BUG/MINOR: 51 degree: handle a possible strdup() failure

This defect was found by the coccinelle script "unchecked-strdup.cocci". It can be backported to all supported branches. --- addons/51degrees/51d.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/addons/51degrees/51d.c b/addons/51degrees/51d.c index a23b468d6..4

Re: HAproxy load balancing query

Hi Shehan, On Thu, Jan 02, 2025 at 11:25:25AM +, Shehan Jayawardane wrote: > Hi Willy, > > Good day to you. > After long time I'm requesting this query as well. > with HA proxy are we able to load balance udp traffic? There isn't such a thing as "udp traffic" but there are udp-based services

Re: [PATCH 3/3] BUG/MINOR: compression: handle a possible strdup() failure

seems UDP was involved in the transit, patches did not reach target repo. сб, 28 дек. 2024 г. в 06:23, Willy Tarreau : > On Fri, Dec 27, 2024 at 10:18:04PM +0100, ??? wrote: > > here's v2 > > Looks good, applied now. > Thank you Ilya! > willy >

Re: [PATCH 3/3] BUG/MINOR: compression: handle a possible strdup() failure

On Thu, Jan 02, 2025 at 02:28:55PM +0100, ??? wrote: > seems UDP was involved in the transit, patches did not reach target repo. Grrr sorry for this Ilya. It happens sometimes when I apply them to the branch I'm working in and that I finally don't push as incomplete. Now pushed, thanks fo

Re: [PATCH] BUG/MINOR: 51 degree: handle a possible strdup() failure

On 02. 01. 2025. 15:18, Ilia Shipitsin wrote: > This defect was found by the coccinelle script "unchecked-strdup.cocci". > It can be backported to all supported branches. Hello Ilia, due to allocating memory for list elements, in case of impossibility of memory allocation, the previously added li