Re: [PATCH] CI: limix aws-lc and libressl Quic Interop to "haproxy" only

2024-12-10 Thread Willy Tarreau
Hi Ilya, On Tue, Dec 10, 2024 at 01:35:40PM +0100, Ilia Shipitsin wrote: > those CI is not supposed to run in forks (however, if someone wants, > he can enable it personally) Do these cause any trouble ? I'm asking because some devs use various accounts (including personal) to test their changes

Re: [PATCH 1/4] BUG/MINOR: checks: handle a possible strdup() failure

2024-12-10 Thread Willy Tarreau
Hi Ilya, Thanks for these patches. Please be careful, most parsing or init functions that return ERR_ALERT are expected to have either printed the alert or produced it in the "err" field. Sadly there's no general rule to know which one uses what, generally it's needed to see what other parts are d

Re: [PATCH] CI: limix aws-lc and libressl Quic Interop to "haproxy" only

2024-12-10 Thread Илья Шипицин
ср, 11 дек. 2024 г. в 04:43, Willy Tarreau : > Hi Ilya, > > On Tue, Dec 10, 2024 at 01:35:40PM +0100, Ilia Shipitsin wrote: > > those CI is not supposed to run in forks (however, if someone wants, > > he can enable it personally) > > Do these cause any trouble ? I'm asking because some devs use va

Re: [PATCH 1/4] BUG/MINOR: checks: handle a possible strdup() failure

2024-12-10 Thread Илья Шипицин
I'm not sure "memprintf" will succeed in case of OOM. I'll check ср, 11 дек. 2024 г. в 04:39, Willy Tarreau : > Hi Ilya, > > Thanks for these patches. Please be careful, most parsing or init > functions that return ERR_ALERT are expected to have either printed > the alert or produced it in the "e

Re: [PATCH] CI: limix aws-lc and libressl Quic Interop to "haproxy" only

2024-12-10 Thread Alan Murrell
Can someone PLEASE get me off this mailing list? I have tried 3 or 4 times now by using the "list-unsubscribe" address in the e-mail headers, and while I have received the "Reply to this e-mail to confirm" message each time, and I have replied to each of those, I remain subscribed, so clearly

[PATCH 3/4] BUG/MINOR: mux_h1: handle a possible strdup() failure

2024-12-10 Thread Ilia Shipitsin
This defect was found by the coccinelle script "unchecked-strdup.cocci". It can be backported to all supported branches. --- src/mux_h1.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mux_h1.c b/src/mux_h1.c index 7eb18133d..0206dcbd0 100644 --- a/src/mux_h1.c +++ b/s

[PATCH 1/4] BUG/MINOR: checks: handle a possible strdup() failure

2024-12-10 Thread Ilia Shipitsin
This defect was found by the coccinelle script "unchecked-strdup.cocci". It can be backported to all supported branches. --- src/check.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/check.c b/src/check.c index 29a86b7dd..e636148b6 100644 --- a/src/check.c +++ b/src/check.c @@ -1667,6

[PATCH 2/4] BUG/MINOR: listener: handle a possible strdup() failure

2024-12-10 Thread Ilia Shipitsin
This defect was found by the coccinelle script "unchecked-strdup.cocci". It can be backported to all supported branches. --- src/listener.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/listener.c b/src/listener.c index 5f3a98b4a..5fb610a88 100644 --- a/src/listener.c

[PATCH 4/4] BUG/MINOR: debug: handle a possible strdup() failure

2024-12-10 Thread Ilia Shipitsin
This defect was found by the coccinelle script "unchecked-strdup.cocci". It can be backported to all supported branches. --- src/debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/debug.c b/src/debug.c index d052f5b63..2c5e35553 100644 --- a/src/debug.c +++ b/src/debug.c @@ -2048,6

[PATCH] CI: limix aws-lc and libressl Quic Interop to "haproxy" only

2024-12-10 Thread Ilia Shipitsin
those CI is not supposed to run in forks (however, if someone wants, he can enable it personally) --- .github/workflows/quic-interop-aws-lc.yml | 2 ++ .github/workflows/quic-interop-libressl.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/quic-interop-aws-lc.yml b/

Re: [PATCH 1/4] BUG/MINOR: checks: handle a possible strdup() failure

2024-12-10 Thread Willy Tarreau
On Wed, Dec 11, 2024 at 05:38:21AM +0100, ??? wrote: > I'm not sure "memprintf" will succeed in case of OOM. I'll check No, it may also fail but anyway callers are prepared to this, and that's the way it's handled at other places. Willy

Re: [PATCH] CI: limix aws-lc and libressl Quic Interop to "haproxy" only

2024-12-10 Thread Илья Шипицин
generally, I'm fine with either option. Please consult developers who are actively involved into QUIC development ср, 11 дек. 2024 г. в 04:43, Willy Tarreau : > Hi Ilya, > > On Tue, Dec 10, 2024 at 01:35:40PM +0100, Ilia Shipitsin wrote: > > those CI is not supposed to run in forks (however, if s