Re: [hackers] [dwm] Redundant code in manage()?

2024-10-29 Thread Raymond Cole
On 24/10/29 09:56AM, Hiltjo Posthuma wrote: > On Tue, Oct 29, 2024 at 02:25:13AM +0000, Raymond Cole wrote: > > In dwm's manage() function there is this line: > > > > XMoveResizeWindow(dpy, c->win, c->x + 2 * sw, c->y, c->w, c->h); /* > > som

Re: [hackers] [dwm][PATCH] Avoid unsigned integer underflow in drw_text()

2024-10-28 Thread Raymond Cole
On 24/10/28 08:57PM, Hiltjo Posthuma wrote: > On Mon, Oct 28, 2024 at 12:34:55AM +0000, Raymond Cole wrote: > > --- > > drw.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drw.c b/drw.c > > index 344de61..c41e6af 100644 > > ---

[hackers] [dwm] Redundant code in manage()?

2024-10-28 Thread Raymond Cole
In dwm's manage() function there is this line: XMoveResizeWindow(dpy, c->win, c->x + 2 * sw, c->y, c->w, c->h); /* some windows require this */ It's hard to imagine what windows would require this. The commit history seems to leave no clue. Removing it hasn't caused any problem to me. My

[hackers] [dwm][PATCH] Avoid unsigned integer underflow in drw_text()

2024-10-27 Thread Raymond Cole
--- drw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drw.c b/drw.c index 344de61..c41e6af 100644 --- a/drw.c +++ b/drw.c @@ -248,6 +248,8 @@ drw_text(Drw *drw, int x, int y, unsigned int w, unsigned int h, unsigned int lp } else { XSetForeground(drw->dpy, drw->g

Re: [hackers] [dwm][PATCH] Fix bug in die()

2024-10-27 Thread Raymond Cole
On 24/10/27 06:27PM, Hiltjo Posthuma wrote: > Thanks for the patch. I agree and the common pattern is even, at the top of > the function: > > int saved_errno = errno; > > Then use (or restore) errno. > I notice dmenu, dwm, libsl, sbase, etc have this bug. > Sorry, I didn't notice vprintf

[hackers] [dwm][PATCH] Fix bug in die()

2024-10-27 Thread Raymond Cole
fputc() might set errno and thus affect perror(). --- util.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/util.c b/util.c index 96b82c9..a289160 100644 --- a/util.c +++ b/util.c @@ -1,4 +1,5 @@ /* See LICENSE file for copyright and license details. */ +#include