On Tue, Nov 11, 2014 at 11:05 AM, Dimitris Papastamos wrote:
>
> I agree on this, I think Hiltjo had some trouble because it
> was defaulting to "c99" as opposed to "cc" and that did not
> exist on his system.
>
> Hiltjo, can you clarify again?
>
Yeah that was my problem. ".POSIX:" in the Makefil
Hi guys,
This is a resend of the patch to add Xft support to upstream dmenu.
There was some stray whitespace in the previous patch which I fixed.
Based on the work of libsl I have modified dmenu to use the new
libsl/libdraw code which adds Xft and fallback-fonts support aswell.
Addtionally I fix
On Mon, Jun 8, 2015 at 11:05 PM, Hiltjo Posthuma wrote:
> ... snip ...
>
I forgot to mention I also changed the odd case in drw_cur_create
where if you pass NULL for drw it would allocate memory but never
expose it and return NULL (possible leak):
http://git.suckless.org/dwm/tree/drw.
On Mon, Jun 8, 2015 at 11:48 PM, Hiltjo Posthuma wrote:
> On Mon, Jun 8, 2015 at 11:05 PM, Hiltjo Posthuma
> wrote:
>> ... snip ...
>>
>
Some more thoughts: in drw.c these functions don't check if drw ==
NULL before use: drw_load_fonts, drw_font_xcreate.
We should p
On Sat, Jun 13, 2015 at 11:51 AM, Dimitris Papastamos wrote:
>
> Works well for me.
>
> Anselm, can we merge this?
>
Bump.
Can this get merged to master?
I'd be willing to take over maintainership for dwm and dmenu if the
current maintainer(s) don't have the time or energy to do it. Also I'd
li
On Sat, Jun 27, 2015 at 9:50 PM, Anselm R Garbe wrote:
>
> You are very welcome to take over libsl+dmenu. But I'd like to keep
> the dwm maintainership, though all plans back from 2013 are still
> valid. If you keep working on libsl+dmenu, I'd be willing to
> adopt/adjust dwm accordingly for the n
On Wed, Jul 8, 2015 at 8:45 PM, FRIGN wrote:
> Good evening everybody!
>
> I've taken a look at st today and made some changes that have proven to
> improve the code while working on sbase and ubase in the last few months.
>
> These patches imply layout and style changes in most places of the code
Hi,
Just some minor fixes (whitespace and such).
Kind regards,
Hiltjo
From c79b4339fc477e2d0212d442f38c50326e430f2a Mon Sep 17 00:00:00 2001
From: Hiltjo Posthuma
Date: Wed, 15 Jul 2015 21:37:32 +0200
Subject: [PATCH] whitespace + typo fixes
change exit(-1) to exit(1), just use 1 instead of
Hi,
This patch fixes parsing the end of a comment, there was a missing ;
Kind regards,
Hiltjo
From 2dc0d42b51973d0e9106a2fd487d9f485178ac34 Mon Sep 17 00:00:00 2001
From: Hiltjo Posthuma
Date: Wed, 15 Jul 2015 22:34:42 +0200
Subject: [PATCH] lex: fix parsing end of comment
---
cc1/lex.c | 4
Hi,
patch 1: whitespace fixes
patch 2: make fp of type FILE * and use needed includes
patch 3: fix missing ;
Kind regards,
Hiltjo
fprintf(stderr, "PAR%d:%s\n", n, arglist[n]);
copymacro(buffer, s+3, INPUTSIZ-1, arglist);
--
2.3.0
From 88eb60a95be178120f204bc80d6a011cece4522b Mon Sep 17 00:00:00 2001
From: Hiltjo Posthuma
Date: Fri, 17 Jul 2015 20:29:28 +0200
Subject: [PATCH 2/3] make fp of type FILE * and use needed includes
On Thu, Aug 6, 2015 at 4:20 AM, Eric Pruitt wrote:
> This patch fixes a typo in dmenu.
>
Hi!
Applied! Thanks for the patch.
Kind regards,
Hiltjo
On Sun, Aug 30, 2015 at 2:57 PM, Michael Stummvoll wrote:
> From 12b254047d5f4fe0c254a3e686a36965ff50a266 Mon Sep 17 00:00:00 2001
> From: Michael Stummvoll
> Date: Sun, 30 Aug 2015 14:49:51 +0200
> Subject: [PATCH] Introduce instant match option
>
> with the instant match option, dmenu will clos
On Tue, Sep 29, 2015 at 8:41 PM, Greg Reagle wrote:
> My two patches combined with FRIGN's feedback. See attached.
>
Nice work!
On Sat, Oct 3, 2015 at 3:09 AM, shua lloret wrote:
> attached is a small patch to enable pasting from clipboard, as well as
> primary.
>
> It seems like there was already code in there to allow this, but since there
> was never any case to match the upper case 'Y', that inline if would always
> ev
On Fri, Aug 14, 2015 at 6:28 PM, Davide Del Zompo
wrote:
> dmenu incorrectly orders matching results:
>
> $ dmenu < suck xless
> suck less
> EOF
>
> Typing 'suck less' shows 'suck xless' as first result, however, according to a
> comment in the source code, this is not the intended behaviour:
>
On Sun, Oct 4, 2015 at 6:22 PM, shua lloret wrote:
> You should change the website if git diff is not the correct way to create
> patches.
>
> http://dwm.suckless.org/patches/
> http://surf.suckless.org/patches/
> http://tools.suckless.org/dmenu/patches/
> http://tools.suckless.org/ii/patches/
> h
On Thu, Nov 5, 2015 at 2:39 PM, Alexander Huemer wrote:
> Hi,
>
> this patch solved an inconvenience for me regarding at least mpv and
> firefox.
> In case there are no strong objections I recommend to mainline it.
>
> Kind regards,
> -Alex^Wblackbit
Can you explain in some greater detail what is
On Fri, Nov 20, 2015 at 7:04 AM, Stephen Sherratt wrote:
> I made a patch to add suggestions to dmenu based on previously run commands.
> I know there already exists such a patch
> (http://tools.suckless.org/dmenu/patches/history) but it seems to be quite
> old and doesn't work with the latest ver
On Wed, Nov 18, 2015 at 10:54 PM, Markus Teich
wrote:
> The drw code of sent diverged from the drw code of dmenu/dwm/… a couple of
> months ago. I submitted my changes earlier this year, they were never merged
> into upstream libdrw. Now we have two different histories and should probably
> try to
On Fri, Nov 27, 2015 at 7:38 PM, Silvan Jegen wrote:
> Heyhey
>
> I kept thinking about a more general way to implement history
> functionality for dmenu and this is what I came up with.
>
> We use the sort command to generate an input list for dmenu sorted by
> count (first patch). dmenu itself i
On Mon, Nov 30, 2015 at 3:28 PM, Silvan Jegen wrote:
> Heyho!
>
> On Sat, Nov 28, 2015 at 11:25 PM, Hiltjo Posthuma
> wrote:
>> On Fri, Nov 27, 2015 at 7:38 PM, Silvan Jegen wrote:
>> This can be implemented in a few lines of shell (wc, sort) and maybe awk.
>
> I
On Mon, Jan 11, 2016 at 6:29 PM, Klemens Nanni wrote:
> Hey,
>
Hi!
> cc596365a (unbolify dmenu) "breaks" some of the patches provided at
> tools.suckless.org/dmenu/patches. Basically 's,bool,int' was all I had
> to do besides some offset correction. Since this is the first time I'm
> dealing wit
On Fri, Feb 19, 2016 at 8:43 PM, Lucas Gabriel Vuotto
wrote:
> this is a small fix for arg.h where it's possible to perform an
> out-of-boundary memory access in argv's internal string. In particular, this
> is a fix for sbase's arg.h, but I've also seen it in st repo, and I suppose
> that this "b
On Sat, Feb 20, 2016 at 10:28 PM, Maurycy Skier wrote:
> Hi, I hope I am doing everything right.
>
> I added a new option (-r) which reverses the list and puts the input under
> it. If you've used Vimperator or CtrlP plugin in Vim you can say it tries to
> make dmenu lookalike (with -b and -l opti
On Sat, Mar 26, 2016 at 12:30:50AM +0100, Mattias Andr??e wrote:
> Signed-off-by: Mattias Andr??e
> diff --git a/pwdx.c b/pwdx.c
> new file mode 100644
> index 000..b9836b7
> --- /dev/null
> +++ b/pwdx.c
> @@ -0,0 +1,53 @@
> +/* See LICENSE file for copyright and license details. */
> +#includ
On Sat, Mar 26, 2016 at 12:58:37PM +0100, Mattias Andr??e wrote:
> +
> + for (; argc > 0; argc--, argv++) {
> + n = snprintf(path, sizeof(path), "/proc/%s/cwd", *argv);
> + if (n < 0 || n > sizeof(path)) {
> + errno = ESRCH;
The line:
> +
On Tue, Mar 29, 2016 at 08:41:00PM +0200, Mattias Andr??e wrote:
> Signed-off-by: Mattias Andr??e
> ---
> Makefile | 1 -
> setsid.1 | 17 -
> setsid.c | 40
> 3 files changed, 58 deletions(-)
> delete mode 100644 setsid.1
> delete mode
On Fri, Apr 08, 2016 at 01:13:09PM +, ra...@openmailbox.org wrote:
> This adds a crop tool to farbfeld, the use is: ffcrop x y w h.
>
> What do you think?
Cool idea, I think farbfeld should have some useful tools included, maybe
in a separate tools/ directory or something.
Another tool I lik
On Fri, Apr 22, 2016 at 03:24:47AM +0200, Mattias Andrée wrote:
> Also in man page: [-r | -s | -w] => (-r | -s | -w)
>
> 8< ... snippity snip ...>8
>
> int
> @@ -141,7 +141,7 @@ main(int argc, char *argv[])
> else if (argc == 1)
> dev = argv[0];
>
> - if ((rflag ^ sfla
>From 9d83c63ab6557d1a7effbcb6c88cac00bc507ef2 Mon Sep 17 00:00:00 2001
From: Hiltjo Posthuma
Date: Fri, 6 May 2016 22:18:53 +0200
Subject: [PATCH] fix uninitialized value after include(), fixes test001
The issue manifests after the line "#include " is parsed.
The codeflow is lik
On Mon, May 9, 2016 at 7:52 PM, Nico Golde wrote:
> Hi,
>
> This is massive, pretty exciting!
>
Hi and thanks!
It came as a bit of a surprise to me too, but it is nice FRIGN posted it.
There can be some silly commits though since it is an incremental
patchset, so the changeset seems bigger than
On Thu, May 12, 2016 at 7:29 PM, wrote:
> commit c9cccba538e9870b1177ae4c57dad716e9f02185
> Author: sin
> AuthorDate: Wed May 11 17:38:15 2016 +0100
> Commit: Roberto E. Vargas Caballero
> CommitDate: Wed May 11 17:35:52 2016 +0200
>
> Implement proper #pragma support
>
This patch
On Sun, May 22, 2016 at 10:29:21PM +0200, Markus Teich wrote:
> - Use simple XftColor type instead of Clr struct => No need for drw_clr_free
> function.
> - Replace ClrScheme struct with simple array of XftColor items `Scm`.
> - Add Enum with ColFg and ColBg for indexing Scm type variables.
> - R
On Mon, May 23, 2016 at 07:40:14PM +0200, Markus Teich wrote:
> Hiltjo Posthuma wrote:
> > I'm willing to apply your unification patches to dmenu and dwm, but can you
> > make a patch for dwm/dmenu if it breaks it?
>
> Heyho Hiltjo,
>
> sorry, I don't quit
On Sun, May 22, 2016 at 10:34:30PM +0200, Markus Teich wrote:
> - extract drawitem function (code deduplication)
> - fix bug where inputw was not correctly calculated from the widest item, but
> just from the one with the longest strlen() which is not the same.
> - minor code style fixes (indenta
On Thu, Jun 02, 2016 at 09:57:01PM +0200, FRIGN wrote:
> Hello fellow hackers,
>
> I'll drop this little patch here so we finally make the switch to the
> safe OpenBSD-functions for string copying.
A good compromise might be using snprintf(buf, sizeof(buf), "%s", text) this is
standard and functi
On Fri, Jun 03, 2016 at 06:55:36PM +0200, Markus Teich wrote:
> Hiltjo Posthuma wrote:
> > I noticed a regression, dmenu seems really slow to load on my machine in the
> > function readstdin(). Was the font cache behaviour removed from drw?
>
> Heyho,
>
Heya!,
> that
On Fri, Jun 03, 2016 at 07:42:37PM +0200, Markus Teich wrote:
> Hiltjo Posthuma wrote:
> > Your patch fixes the slowness for me, but we need to think of a more
> > accurate
> > but faster way indeed.
>
> Heyho,
>
> I plan to clean up the drw_text function so
Hi,
>From f63134043f065eaa7ccce666160e9a05785ecd54 Mon Sep 17 00:00:00 2001
From: Hiltjo Posthuma
Date: Sat, 4 Jun 2016 16:29:07 +0200
Subject: [PATCH] load slide image on-demand
previously an image file would be opened but only ffread when advancing to
the slide, but when the slide was
On Sat, Jun 04, 2016 at 05:28:31PM +0200, Markus Teich wrote:
> Hiltjo Posthuma wrote:
> > previously an image file would be opened but only ffread when advancing to
> > the slide, but when the slide was not used it gave an error:
> >
> > /usr/local/bin/2ff:
On Mon, Jun 06, 2016 at 08:50:31PM +0200, FRIGN wrote:
> On Mon, 6 Jun 2016 20:12:19 +0200
> k...@shike2.com wrote:
>
>> ...
>
> Nope, it's not. Keep in mind strlcpy fills the rest
> of the memory area with 0's.
No it doesn't, but strncpy does that.
> Also, I suspect you have not understood str
Hi,
I don't think it is an improvement, so will disregard it.
--
Kind regards,
Hiltjo
On Fri, Jun 03, 2016 at 09:12:11PM +0200, Markus Teich wrote:
> Hiltjo Posthuma wrote:
> > Fair enough, I think I'll apply it with the (temporary fix), since the
> > current
> > width is also less accurate and the speed trade-off is not worth it.
> >
> > Ag
On Sun, Jun 26, 2016 at 01:05:18PM -0700, Eric Pruitt wrote:
> On Sun, Jun 26, 2016 at 02:53:03PM +0200, Hiltjo Posthuma wrote:
> > I have pushed the drw changes to dmenu and dwm.
> >
> > Thanks for the contributions!
> >
> > It would be nice if people test it and
On Tue, Jun 28, 2016 at 01:11:50AM -0400, S. Gilles wrote:
> ---
> dmenu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dmenu.c b/dmenu.c
> index 0e7b70b..e926eca 100644
> --- a/dmenu.c
> +++ b/dmenu.c
> @@ -480,7 +480,7 @@ readstdin(void)
> }
> if (items)
On Mon, Jul 25, 2016 at 11:33:25AM +0200, Quentin Rameau wrote:
> Without this, we discard the item if it's longer than assigned width
> instead of truncating it.
> ---
> dmenu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dmenu.c b/dmenu.c
> index e926eca..8e84fb
On Tue, Jul 26, 2016 at 02:15:36PM +0200, soe...@soeren-tempel.net wrote:
> From: Sören Tempel
>
> If your current window is in fullscreen mode than you are able to
> trigger a few cases where the current window focus is lost. For instance
> when your current window is in fullscreen mode and you
On Sat, Jul 30, 2016 at 4:06 PM, wrote:
> From: Vincent Legoll
>
> Allow CC and PREFIX to be overridden to make sinit
> buildable & installable under guix packaging system
>
> Signed-off-by: Vincent Legoll
> ---
> config.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -
for the reminder.
Let me know what you think or if i've missed something.
Patch:
>From d3f47bef10384ae624e5e7f81063e1bc1f37962c Mon Sep 17 00:00:00 2001
From: Hiltjo Posthuma
Date: Sun, 31 Jul 2016 13:43:00 +0200
Subject: [PATCH] clear passwords with explicit_bzero
Make sure to ex
Bah sorry, directly after sending I noticed an obvious mistake :P
explicit_bzero(&passwd, len);
should be safer:
explicit_bzero(&passwd, sizeof(passwd));
Updated full patch below:
>From 416675b2af28a70199a14bd4999bb27b6df97abe Mon Sep 17 00:00:00 2001
From: Hilt
Can someone apply this patch or give a reason why it sucks? :)
--
Kind regards,
Hiltjo
I (and some others) think we should apply the behaviour change in die() to all
other suckless projects that use it for consistency.
--
Kind regards,
Hiltjo
On Fri, Aug 12, 2016 at 11:18:43AM +0200, Markus Teich wrote:
> Hiltjo Posthuma wrote:
> > I (and some others) think we should apply the behaviour change in die() to
> > all
> > other suckless projects that use it for consistency.
>
> Heyho,
>
> yes, I propo
On Fri, Aug 12, 2016 at 11:18:43AM +0200, Markus Teich wrote:
> Hiltjo Posthuma wrote:
> > I (and some others) think we should apply the behaviour change in die() to
> > all
> > other suckless projects that use it for consistency.
>
> Heyho,
>
> yes, I propo
On Fri, Aug 12, 2016 at 03:06:06PM +0200, Markus Teich wrote:
> Heyho,
>
> Hiltjo Posthuma wrote:
> > Here is a patch that improve the error messages a bit more and a patch that
> > checks a memory allocation case.
>
> Thanks, I clarified the split error mess
On Sun, Aug 14, 2016 at 12:30:46AM +0200, Joerg Jung wrote:
> Hi,
>
> please find below a diff for sic to enable pledge() to be used on
> OpenBSD. This diff was originally submitted by Ali H. Fardan via
> po...@openbsd.org. While here, I enabled the usage of strlcpy()
> from libc on OpenBSD.
>
On Sat, Aug 20, 2016 at 11:26:50PM +0200, David Dufberg Tøttrup wrote:
>
>
> From 10e65f4f8c1016ce90d6e0d159c78ca642d4bba3 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?David=20Dufberg=20T=C3=B8ttrup?=
> Date: Sat, 20 Aug 2016 16:20:19 +0200
> Subject: [PATCH] Fix prefix match is treated as exact m
On Mon, Aug 22, 2016 at 03:15:07PM +0200, Markus Teich wrote:
> Heyho,
>
> FRIGN pointed me to this[0] yesterday.
>
> > Vendor was notified about this issue on 2015-11-13.
>
> I could not find a mail related to this on the suckless mailing lists for that
> date, but hiro mentioned an unspecific
Any more input on this from the community? (you, yes you behind the keyboard)
--
Kind regards,
Hiltjo
On Fri, Sep 02, 2016 at 12:37:00PM +0100, Nick wrote:
> Hi FRIGN,
>
> I don't have time to look at this closely now, but one little thing
> that jumped out at me:
>
> > +static const struct {
> > + char *ext;
> > + char *type;
> > +} mimes[] = {
> > ...
>
> Why are you defining the struct i
On Thu, Sep 22, 2016 at 10:22:14AM +0200, g...@suckless.org wrote:
> commit da5290a41aac4eabef83f6b88039f44d28b0ea00
> Author: Quentin Rameau
> AuthorDate: Mon Nov 23 22:12:00 2015 +0100
> Commit: Quentin Rameau
> CommitDate: Thu Sep 22 10:21:31 2016 +0200
>
> Add support for loading
On Thu, Jun 23, 2016 at 10:47:09PM +0200, Nico Golde wrote:
> * Hiltjo Posthuma [2016-05-10 01:14]:
> > On Mon, May 9, 2016 at 7:52 PM, Nico Golde wrote:
> [...]
> > > To be honest I was a little in shock when I saw this. Some of this would
> > > have
> >
On Mon, Sep 26, 2016 at 10:26:41AM +0200, Ramsey wrote:
> Hi list,
>
I don't like the extra braces for example:
Good:
if (1)
...
vs "bad":
if (1) {
...
}
Also goto's are perfectly fine in some cases.
--
Kind regards,
Hiltjo
Two things I noticed:
It does not seem to compile, it requires cp_iflag in fs.h:
diff --git a/fs.h b/fs.h
index 15ae5f4..36b9cb3 100644
--- a/fs.h
+++ b/fs.h
@@ -25,6 +25,7 @@ enum {
extern int cp_aflag;
extern int cp_fflag;
+extern int cp_iflag;
extern int cp_pflag;
extern int cp_rflag;
e
On Wed, Oct 19, 2016 at 04:14:40PM +0200, Felix Van der Jeugt wrote:
> Dear all,
>
> Attached patch changes behaviour of the Tab key for dmenu. Instead of
> replacing the written text with the current selection, it replaces the
> written text with the longest common prefix of all matches.
>
> Not
On Fri, Oct 21, 2016 at 01:18:12AM +0200, s...@mailless.org wrote:
> Hi,
>
> Here are two patches; the first introduces a shorthand for walking
> through the visible (stacked) clients.
>
> The second applies on top of the first and implements stack rotation
> (moving clients from the top to the b
On Thu, Oct 27, 2016 at 12:41:25PM +0200, Laslo Hunhold wrote:
> On Thu, 27 Oct 2016 10:02:32 +0200
> Anselm R Garbe wrote:
>
> > To me ! is logical NOT and your suggestion relies on the fact that
> > XUrgencyHint is a single bit flag? no?
> > I prefer the original code, as it doesn't use side ef
On Sat, Oct 29, 2016 at 12:32 AM, Klemens Nanni wrote:
> This reduces the amount of strcmp() calls and comparisons in general to
> a minimum.
> ---
> slock.c | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/slock.c b/slock.c
> index 283b04e..e9b050a 100644
>
On Sat, Oct 29, 2016 at 12:11 PM, Ali H. Fardan wrote:
> On 2016-10-29 12:40, Hiltjo Posthuma wrote:
>>
>> This is total bullshit: it is less readable and it makes no sense to
>> optimize this case. Please fix real bugs.
>
>
> uhm, like the dmenu one?[0]
>
>
On Thu, Nov 03, 2016 at 06:27:21PM +0100, Markus Teich wrote:
> Heyho,
>
Hiya!
> Davids patch for sent reminded me of an open issue. I proposed the following
> change to libsls ecalloc() a few months ago, but did not get feedback.
>
> void *
> ecalloc(size_t nmemb, size_t size)
On Fri, Nov 04, 2016 at 07:53:35PM +0100, Markus Teich wrote:
> Heyho Hiltjo,
>
> > > My proposal would be to change ecalloc to use die() and in the rare cases
> > > where the allocation error should be handled gracefully just don't use
> > > ecalloc, but calloc directly.
> > >
> > > Btw: The drw
On Fri, Nov 11, 2016 at 11:38 PM, Markus Teich
wrote:
>> >>> I can at least imagine cases where quitting on allocation failure is not
>> >>> good. For example dwm is running, a new client starting up, but there is
>> >>> no memory left for the client struct. In this case dwm should just print
>>
On Fri, Nov 25, 2016 at 10:38:09PM +1000, Thomas Gardner wrote:
> ---
> Sorry Quentin, I know now that this is where to include remarks.
>
> dmenu.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/dmenu.c b/dmenu.c
> index 9278e91..1cfefcd 100644
> --- a/dmen
On Sat, Nov 26, 2016 at 08:00:01AM +0100, Ivan Delalande wrote:
> GTK3 checks for this property in some of its functions and simply give
> up if it's not there and set correctly. This notably caused fullscreen
> to be broken on recent versions of Firefox.
>
> This is mostly arg's 762b66a resurrect
Hey Anselm,
I think its better to use `git am` next time to apply the original patches.
This way the original author, commit message/reason/explanation is archived
aswell.
--
Kind regards,
Hiltjo
On Sun, Dec 04, 2016 at 09:55:11PM -0800, Michael Forney wrote:
> ---
> tail.c | 16 +++-
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/tail.c b/tail.c
> index ad97308..000be62 100644
> --- a/tail.c
> +++ b/tail.c
> @@ -133,7 +133,7 @@ main(int argc, char *argv[])
On Sun, Dec 04, 2016 at 09:55:07PM -0800, Michael Forney wrote:
> The FILE streams are buffered, so the end result is essentially the
> same, except now lines are printed as they are read since we don't wait
> until the entire buffer is filled.
>
> This also fixes an issue where only part of the l
On Mon, Dec 05, 2016 at 01:51:36PM +0100, Silvan Jegen wrote:
> On Mon, Dec 5, 2016 at 1:45 PM, Markus Teich
> wrote:
> > Anselm R Garbe wrote:
> >> I agree, but my MUA couldn't detect a proper attachment.
> >
> > Heyho Anselm,
> >
> > `git am` also works with the whole source-text of a mail. For
On Wed, Dec 07, 2016 at 09:45:01AM -0500, Andrew Gregory wrote:
> This reverts commit 09d0a36e0370f7ca9bdb171bf93c5ac3131c5a92.
>
> Using strncmp with the length of the user input turns it into a prefix
> match rather than an exact match as it's supposed to be.
> ---
> dmenu.c | 2 +-
> 1 file ch
Nitpicks:
- Check if digit in date_field().
- Style: don't declare variables in the inner scope, just use the
function scope for struct tm date; and struct timespec ts;
Kind regards,
Hiltjo
On Tue, Jan 10, 2017 at 08:56:46AM +0100, g...@suckless.org wrote:
> commit b95c8ed79e5d5322dd3c5c386c3acd62105ac116
> Author: Roberto E. Vargas Caballero
> AuthorDate: Tue Jan 10 08:46:48 2017 +0100
> Commit: Roberto E. Vargas Caballero
> CommitDate: Tue Jan 10 08:49:17 2017 +0100
>
>
On Sun, Jan 29, 2017 at 10:27:29PM +0100, Josuah Demangeon wrote:
> I am updating the SSL patch for ii for latest commit (8570350).
>
> I attached both the diff for "sites" (sites.diff) and the patch itself
> (ii-ssl-20170129-8570350.diff).
> diff --git a/config.mk b/config.mk
> index b5bc34f..85
Probably a false positive, but for ed.c it looks ok to me.
The join.c patch does not look ok to me (clang doesn't detect that
eprintf() exists the program), so it's a false positive.
On Thu, Feb 2, 2017 at 3:43 PM, Simon Cooksey wrote:
> - ed.c
>Initialise hline in `static int makeline(char,
On Mon, Feb 06, 2017 at 02:04:52PM -0800, Evan Gates wrote:
> Hiltjo Posthuma wrote:
>
> > Probably a false positive, but for ed.c it looks ok to me.
> >
> > The join.c patch does not look ok to me (clang doesn't detect that
> > eprintf() exists the program),
On Wed, Mar 29, 2017 at 05:52:57PM +0200, g...@suckless.org wrote:
> commit 416f39e3d68a6b12a05751930a609cfbbde483ff
> Author: Laslo Hunhold
> AuthorDate: Wed Mar 29 17:51:41 2017 +0200
> Commit: Laslo Hunhold
> CommitDate: Wed Mar 29 17:51:41 2017 +0200
>
> Overhaul Build-system
>
On Thu, Mar 30, 2017 at 08:44:34AM +0200, g...@suckless.org wrote:
> commit bbe28227eb80da62fec59aa79ba7a97f5c3937b4
> Author: Laslo Hunhold
> AuthorDate: Thu Mar 30 08:41:17 2017 +0200
> Commit: Laslo Hunhold
> CommitDate: Thu Mar 30 08:43:42 2017 +0200
>
> Make Makefile strictly PO
On Thu, Mar 30, 2017 at 01:40:36PM +0200, Matteo Alessio Carrara wrote:
>This patch facilitates writing wrappers to dmenu, because to understand
>what has been selected by comparing strings is slower than using the
>index of an array. Furthermore avoids ambiguity in the case that there
On Sun, Apr 23, 2017 at 11:54:31PM +1000, Daniel Cousens wrote:
>I have found this pattern to take up significant parts of my time when
>rebasing my changes onto suckless/master, � such that I feel the
>following patch will both increase readability, � reduce diffs and
>overall inc
On Mon, Apr 24, 2017 at 10:14:36AM +1000, Daniel Cousens wrote:
>Indeed, � apologies for the style issues.
>The argument could probably be const too.
>
>On 24 Apr. 2017 04:32, "Laslo Hunhold" <[1]d...@frign.de> wrote:
>
> On Sun, 23 Apr 2017 20:
On Mon, Apr 24, 2017 at 01:35:59PM +1000, Daniel Cousens wrote:
>It has often annoyed me that my `st` windows would have "gaps" beneath
>them and to the right as a result of the size hints not being respected
>(due to column widths being enforced nicely in `st`)... however, � the
>a
Hey,
I briefly tested the patch and it does not tile the window properly for me.
It seems to overlap the st window even in tiled-mode.
PS. Please use plain-text e-mail and don't top-post.
--
Kind regards,
Hiltjo
Hey,
I think there are some cases where libutil/cp.c can leak file descriptors.
It is a warning case, but the descriptors are not closed.
I think only `mv` is affected.
Patch below:
>From af392d1a764d7420c7b05bb9e13d7766a5979894 Mon Sep 17 00:00:00 2001
From: Hiltjo Posthuma
Date: Sun, 7
On Sun, May 07, 2017 at 01:54:42PM +0200, Hiltjo Posthuma wrote:
> Hey,
>
> I think there are some cases where libutil/cp.c can leak file descriptors.
> It is a warning case, but the descriptors are not closed.
>
> I think only `mv` is affected.
>
> P
On Mon, May 29, 2017 at 07:15:15PM +0200, Laslo Hunhold wrote:
>
> As far as I can see it, we are left to write down each target
> explicitly.
Which is not an issue in my opinion in our case.
Like I said on IRC:
Generally speaking I'd prefer if the Makefile is 20 lines longer and
very straightfo
On Sat, Jun 10, 2017 at 06:29:49PM +0200, Philip Kaludercic wrote:
> From: Philip K
>
If this is meant for upstream a description would be nice, but this feature
is beyond the scope of dmenu and won't be accepted.
Some feedback below:
> ---
> dmenu.c | 19 +++
> 1 file changed
On Wed, Jun 28, 2017 at 08:30:13AM +0200, g...@suckless.org wrote:
> commit 1e65a4848e04660ae4d471ef418993da6a7e
> Author: Laslo Hunhold
> AuthorDate: Wed Jun 28 08:29:31 2017 +0200
> Commit: Laslo Hunhold
> CommitDate: Wed Jun 28 08:29:31 2017 +0200
>
> Fix dir-check in dirent
>
On Fri, Jul 07, 2017 at 01:35:37PM +0200, g...@suckless.org wrote:
> commit d598da3d52413b20cffe2c7f03c885ffdcca2818
> Author: Laslo Hunhold
> AuthorDate: Fri Jul 7 13:33:43 2017 +0200
> Commit: Laslo Hunhold
> CommitDate: Fri Jul 7 13:33:43 2017 +0200
>
> Send absolute path when red
On Sun, Jul 16, 2017 at 11:29:18PM +0600, Techno Implant wrote:
> 1.New update changes config.mk file so this patch gets rejected there.
> 2. When alpha is set 0xff unicode input with i is
> possible, for other values in alpha unicode input is not possible for
> me.
> From terminal I get this:
> pc
On Fri, Aug 11, 2017 at 09:01:01PM -0700, Michael Forney wrote:
> I went looking through my sbase/ubase branches and found some more
> forgotten patches.
>
> = sbase =
> * http://lists.suckless.org/hackers/1702/14283.html
>
> sbase tar still needs a lot of work, but currently it is frustrating
>
1 - 100 of 471 matches
Mail list logo
