Re: [hackers] [surf][patch] Support PDFs

2025-04-18 Thread Quentin Rameau
Hi Artyom, > This patch allows webkit-pdfjs-viewer:// links, thus enabling WebKit > built-in PDF viewer. It's a feature that was in WebKitGTK for some > time, and I've been missing it in Surf. So here you go, a patch > adding it. Thank you and sorry for the delay. This is something that I myself

Re: [hackers] [surf][patch] Support PDFs

2024-10-08 Thread Artyom Bologov
Hello Страхиња, I ended up agreeing with the arguments of Hiltjo and sent a second iteration in “PDF support (second shot)” email (I know, bad tagging.) There, the functionality is toggleable via a config flag. I suggest taking a look at it instead. Best of luck, — Artyom Bologov https://aarta

Re: [hackers] [surf][patch] Support PDFs

2024-10-08 Thread Страхиња Радић
Дана 24/09/14 10:01AM, Hiltjo Posthuma написа: > Perhaps this should be disabled by default? > > I prefer to use my system PDF viewer. I second this. The built-in webkit's PDF viewer is not the suckless/Unix way. IMHO, this patch should not be included in the mainline. Note that I don't use su

Re: [hackers] [surf][patch] Support PDFs

2024-09-14 Thread Artyom Bologov
Hi Hiltjo, > Perhaps this should be disabled by default? > > I prefer to use my system PDF viewer. I see where you're coming from. I am indecisive about it too. But I guess the reasoning here is the same as file:// scheme: one can open it in suitable program, but they also can open it in the brow

Re: [hackers] [surf][patch] Support PDFs

2024-09-14 Thread Hiltjo Posthuma
On Sat, Sep 14, 2024 at 05:14:19AM +0400, Artyom Bologov wrote: > This patch allows webkit-pdfjs-viewer:// links, thus enabling WebKit > built-in PDF viewer. It's a feature that was in WebKitGTK for some time, > and I've been missing it in Surf. So here you go, a patch adding it. > > To: hackers@

[hackers] [surf][patch] Support PDFs

2024-09-13 Thread Artyom Bologov
This patch allows webkit-pdfjs-viewer:// links, thus enabling WebKit built-in PDF viewer. It's a feature that was in WebKitGTK for some time, and I've been missing it in Surf. So here you go, a patch adding it. To: hackers@suckless.org >From d553d091c7a3a26f3367fda4a2e3e10e76ada588 Mon Sep 17 00:0