Re: v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches.

2022-08-10 Thread Maxime Devos
On 10-08-2022 08:10, bl...@reproduciblemedia.com wrote: August 5, 2022 1:59 PM, "Maxime Devos" wrote: Technical grammatical correction: the software that Guix "has" is that in the monorepo, but it "distributes" many packages. Thus: --8<---cut here---start->8

Re: v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches.

2022-08-10 Thread blake
None of the edits I made were in criticism. In an academic context a proof reader would mark almost all the same sentences for revision. August 10, 2022 9:06 AM, "Maxime Devos" wrote: > On 10-08-2022 08:10, bl...@reproduciblemedia.com wrote: > >> August 5, 2022 1:59 PM, "Maxime Devos" wrote:

Re: v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches.

2022-08-10 Thread Maxime Devos
On 10-08-2022 12:33, bl...@reproduciblemedia.com wrote: None of the edits I made were in criticism. In an academic context a proof reader would mark almost all the same sentences for revision. As far as I'm aware, I do not have implied the contrary anywhere previously. I do think they are cr

Re: v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches.

2022-08-10 Thread david larsson
On 2022-08-09 22:53, Maxime Devos wrote: Agreed (*), but I don't think that subsection claims those are the only reasons for patches -- that section is only about fixing technical issues, not adding new features, as implied by the name of the section. It definitely doesn't claim that. I phras

[PATCH v2] doc: Update contribution guidelines on patches, etc.

2022-08-10 Thread Liliana Marie Prikler
* doc/contributing.texi ("Snippets versus Phases"): Replaced with... ("Modifying Sources"): ... this. List more use cases and some principles. --- doc/contributing.texi | 108 +- 1 file changed, 95 insertions(+), 13 deletions(-) diff --git a/doc/contributi