Re: Importers as independent packages?

2020-01-25 Thread Martin Becze
Thank you Ludo, I added guile-semver to guix in the attached patch set, and I tested it by running ./pre-inst-env guix environment guix, which installed the guile-semver. and Makefile.am may have to check whether guile-semver is available.) I didn't see anything in the Makefile.am that look

(not) testing Rust packages?!

2020-01-25 Thread Hartmut Goebel
Hi, I discovered that most packages in crates-io.scm are not build. I understand that this is done since they do not produce any useful output. But as an side-effect, the packages are not tested either - which might leave issues undiscovered. Is this intended? My experience when packaging KDE l

Re: branch master updated: gnu: ode: Disable tests.

2020-01-25 Thread Ludovic Courtès
Hi Nicolas, guix-comm...@gnu.org skribis: > commit 049bdae52795f01030cb99d6fb271dc4b4ce9a7d > Author: Nicolas Goaziou > AuthorDate: Fri Jan 24 22:47:22 2020 +0100 > > gnu: ode: Disable tests. > > * gnu/packages/game-development.scm (ode): Tests are failing or other > systems >

Re: (not) testing Rust packages?!

2020-01-25 Thread Martin Becze
Part of the reason is that bringing tests for a given library can bring in a massive amount of dependencies. So testing only the top level package seemed like the way to go. Maybe we could add testing when encountering problematic rust packages that break often? On 1/25/20 8:38 AM, Hartmut Goe

Looking for help with packaging a Common Lisp library

2020-01-25 Thread Konrad Hinsen
Hi Guix, I hope that some Common Lisp expert here can help me with a strange error message. I am trying to package the library hdf5-cffi, my current package definition is attached. It builds without any error message, but when I try to load the library with (asdf:load-system "hdf5-cffi") I ge

Re: Looking for help with packaging a Common Lisp library

2020-01-25 Thread Pierre Neidhardt
It seems unrelated, but first there seems to be an issue during the build regarding the missing pkg-config package. If you add it to the native-inputs, then you'll get the following error: --8<---cut here---start->8--- ; ERROR: Subprocess # with command ("pkg-c

Re: Looking for help with packaging a Common Lisp library

2020-01-25 Thread Guillaume Le Vaillant
I think the generated '...-sbcl-hdf5-cffi-1.8.18/lib/sbcl/hdf5-cffi.asd' file is missing a dependency. It contains ':depends-on ("cffi")', but I think it should be ':depends-on ("cffi" "cffi-grovel")', because the original asd file has: --8<---cut here---start-

Re: (not) testing Rust packages?!

2020-01-25 Thread John Soo
Hi Hartmut and Martin, I think it makes sense to run tests now. > Part of the reason is that bringing tests for a given library can bring in a > massive amount of dependencies. I think that we are getting close to having complete dependencies for most rust packages we have and most are declare

Re: patch-shebang and Rust - Change on core-updates?

2020-01-25 Thread Ludovic Courtès
Hi, Danny Milosavljevic skribis: > Rust uses #![...] for something that is definitely not a shebang > (file-wide feature tests). > > Currently, our patch-shebang[1] emits a lot of warnings because of those. > > Should we change patch-shebang to ignore lines starting with "#![" ? > > If so, how?

Re: Rust bootstrapping TODO

2020-01-25 Thread Ludovic Courtès
Hi, Danny Milosavljevic skribis: > (1) For all Mozilla Rusts except the latest one, pass > "--disable-docs --disable-compilerdocs" in order to disable building (and > especially TESTING) the docs. Testing the docs takes a very long time > and no one will ever read the docs of the compilers used

Re: How should ambiguous package specifications be handled?

2020-01-25 Thread Ludovic Courtès
Hello, Tobias Geerinckx-Rice skribis: > Christopher Baines 写道: [...] >> Given there do seem to be ways of avoiding these ambiguous package >> specifications, would it be helpful to have a lint warning that >> identifies a package as being ambiguous (as it shares the name and >> version with an

Re: Guile 3 migration plan

2020-01-25 Thread Ludovic Courtès
Hello! Yesterday I published a post on this topic: https://guix.gnu.org/blog/2020/guile-3-and-guix/ Enjoy! :-) Ludo’.

Re: [PATCH 1/4] utils: Change critical section terminology to worker threads.

2020-01-25 Thread Ludovic Courtès
Hi, Christopher Baines skribis: > As far as I'm aware, it's necessary to use a separate thread for interacting > with SQLite as one of the threads used for fibers will be blocked while the > SQLite query is running. Indeed. > This doesn't mean all queries have to be executed one at a time thou

Re: (not) testing Rust packages?!

2020-01-25 Thread Martin Becze
On 1/25/20 11:46 AM, John Soo wrote: Hi Hartmut and Martin, I think it makes sense to run tests now. Part of the reason is that bringing tests for a given library can bring in a massive amount of dependencies. I think that we are getting close to having complete dependencies for most rus

Re: [PATCH 4/4] database: Enable running up to 4 database queries at once.

2020-01-25 Thread Ludovic Courtès
The rest of this patch series LGTM! Ludo’.

Re: [PATCH 2/2] Alter the Builds table to have an id field

2020-01-25 Thread Ludovic Courtès
Christopher Baines skribis: > The internal rowid's are used for builds as you can request builds by using > the rowid in the URL. > > The motivation here is to enable running VACUUM operations in SQLite, without > risking the rowid's for Builds changing. It would be bad if they change, as > they'

Re: guix build --repair might not always work

2020-01-25 Thread Ludovic Courtès
Hi, another...@gmail.com (Nicolò Balzarotti) skribis: > #+begin_src bash :results list > # This is the broken system > guix gc --verify=repair,contents > #+end_src > > > #+RESULTS: > - reading the store... > - checking path existence... > - checking hashes... > > And nothing else. So, let's chec

Re: Looking for help with packaging a Common Lisp library

2020-01-25 Thread Guillaume Le Vaillant
We could add all the dependencies declared in the original asd files (by 'defsystem-depends-on' and 'depends-on') to the generated asd files with the following patch: --8<---cut here---start->8--- From 7e2009177137b3ad5831b5c42d9a4387d408bc57 Mon Sep 17 00:00:0

Re: branch master updated: gnu: ode: Disable tests.

2020-01-25 Thread Nicolas Goaziou
Hello, Ludovic Courtès writes: > What about disabling tests only on those platforms I didn't realize that was possible. Hopefully, commit 5b7fdc8289ce0adf85e881bc23d3537121b41193 fixes this. > reporting a bug upstream about the failures on the other platforms? Done here: https://bitbucke

Re: rust-build-system: Unvendor *-sys libraries in phase?

2020-01-25 Thread Efraim Flashner
On Fri, Jan 24, 2020 at 01:49:21PM -0800, John Soo wrote: > Hi guix, > > After working on a few rust packages, it looks like there could be another > step on the process. There are a number of libraries in the crates registry > that wrap and vendor c libraries - libgit2, openssl, or jemalloc fo

Re: Parameterized packages

2020-01-25 Thread John Soo
Hey all! I’ve been following very roughly. I have a couple issues with parameterized packages. > On Jan 22, 2020, at 4:24 AM, zimoun wrote: > > Well, I am wanting the same thing: be able to modify the 'arguments' > field but I am not convinced by the design you are proposing because I > have

Re: (not) testing Rust packages?!

2020-01-25 Thread Efraim Flashner
On Sat, Jan 25, 2020 at 08:46:48AM -0800, John Soo wrote: > Hi Hartmut and Martin, > > I think it makes sense to run tests now. > > > Part of the reason is that bringing tests for a given library can bring in > > a massive amount of dependencies. > > I think that we are getting close to having

Re: rust-build-system: Unvendor *-sys libraries in phase?

2020-01-25 Thread John Soo
Hi Efraim, > IMO the correct way to do it would be in the crate source that we > download. We regularly add snippets to remove vendored code, this should > be no different. Totally agree. It seems like a challenge to me to do the other required work since all the building happens only when bu

Re: Guile 3 migration plan

2020-01-25 Thread Ricardo Wurmus
Ludovic Courtès writes: > Yesterday I published a post on this topic: > > https://guix.gnu.org/blog/2020/guile-3-and-guix/ Very nice! It’s impressive how you managed to give structure to something that initially seems like “just a few changes here and there”. Thanks for writing this! Two

Re: Looking for help with packaging a Common Lisp library

2020-01-25 Thread Pierre Neidhardt
I'm not sure: isn't defsystem-depends-on specific to the .asd? If the Common Lisp package depends on it, it should be in the depends, right? -- Pierre Neidhardt https://ambrevar.xyz/ signature.asc Description: PGP signature

Re: rust-build-system: Unvendor *-sys libraries in phase?

2020-01-25 Thread Efraim Flashner
On Sat, Jan 25, 2020 at 11:01:31AM -0800, John Soo wrote: > > Hi Efraim, > > > > IMO the correct way to do it would be in the crate source that we > > download. We regularly add snippets to remove vendored code, this should > > be no different. > > Totally agree. It seems like a challenge to me

Re: Looking for help with packaging a Common Lisp library

2020-01-25 Thread Konrad Hinsen
Hi Pierre and Guillaume, thanks for your quick help! Guillaume Le Vaillant writes: > I think the generated '...-sbcl-hdf5-cffi-1.8.18/lib/sbcl/hdf5-cffi.asd' > file is missing a dependency. It contains ':depends-on ("cffi")', but > I think it should be ':depends-on ("cffi" "cffi-grovel")', beca

Re: [PATCH 2/2] Alter the Builds table to have an id field

2020-01-25 Thread Christopher Baines
Ludovic Courtès writes: > Christopher Baines skribis: > >> The internal rowid's are used for builds as you can request builds by using >> the rowid in the URL. >> >> The motivation here is to enable running VACUUM operations in SQLite, without >> risking the rowid's for Builds changing. It woul

Re: [PATCH 1/4] utils: Change critical section terminology to worker threads.

2020-01-25 Thread Christopher Baines
Ludovic Courtès writes: >> This doesn't mean all queries have to be executed one at a time though, >> providing the queries are executed outside the threads used by fibers, and a >> single connection isn't used in multiple threads. > > Serialization of database accesses comes from: > > commit

Re: (not) testing Rust packages?!

2020-01-25 Thread Andreas Rottmann
Martin Becze writes: > Yeah really good point there (and good work on getting all those pkgs > in!) > Being a newcomer to guix, I must say I'm really amazed about the state of Rust packaging! >> Furthermore since most rust libraries we have are not executables, we >> could still skip the build a