Re: [PATCH 1/4] guix: build/glib-or-gtk-build-system: Add support for GIO and XDG theming.

2015-01-11 Thread Federico Beffa
On Sat, Jan 10, 2015 at 10:08 PM, Ludovic Courtès wrote: > Yes, rather append, otherwise users would be unable to change it, no? My reasoning for choosing to prefix is as follows: we want the application to find the data version that it was compiled with (GLib schemas, ...) to avoid clashing with

Re: [PATCH] gnu: Add nss.

2015-01-11 Thread John Darrington
On Sun, Jan 11, 2015 at 03:51:31PM +0800, ? wrote: John Darrington writes: > Nss has already been packaged on the wup-libreoffice branch. Ah, I didn't notice it :( I look into wip-libreoffice branch, it seems that: it use bundle nspr. it only b

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-11 Thread Federico Beffa
On Sat, Jan 10, 2015 at 10:13 PM, Ludovic Courtès wrote: > Very good! Could you add the story about XDG_DATA_DIRS > vs. XDG_DATA_HOME as a comment above the phase? Will do. > >> + (let ((sounds (string-append >> + (assoc-ref inputs "sound-theme-freedesktop") >>

Re: [PATCH] gnu: Add nss.

2015-01-11 Thread Ludovic Courtès
宋文武 skribis: > Ludovic Courtès writes: > >> 宋文武 skribis: >> >>> Mark H Weaver writes: >>> 宋文武 writes: > * gnu/packages/patches/nss.patch: New file. > * gnu-system.scm (dist_patch_DATA): Add it. > * gnu/packages/polkit.scm (nss): New variable. polkit.scm seems l

Re: [PATCH] gnu: Add ninja.

2015-01-11 Thread Ludovic Courtès
宋文武 skribis: > From 712f161a358a4bbcf005c5875e6d91eff21bdef4 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= > Date: Fri, 9 Jan 2015 21:37:30 +0800 > Subject: [PATCH] gnu: Add ninja. > > * gnu/packages/ninja.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Re: [PATCH 1/4] guix: build/glib-or-gtk-build-system: Add support for GIO and XDG theming.

2015-01-11 Thread Ludovic Courtès
Federico Beffa skribis: > On Sat, Jan 10, 2015 at 10:08 PM, Ludovic Courtès wrote: >> Yes, rather append, otherwise users would be unable to change it, no? > > My reasoning for choosing to prefix is as follows: we want the > application to find the data version that it was compiled with (GLib >

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-11 Thread Ludovic Courtès
Federico Beffa skribis: > On Sat, Jan 10, 2015 at 10:13 PM, Ludovic Courtès wrote: >>> + (let ((sounds (string-append >>> + (assoc-ref inputs "sound-theme-freedesktop") >>> + "/share"))) >>> +(substitute* "src/sound-theme-spec.

Re: [PATCH 1/2] gnu: Move mozjs and nspr to (gnu packages gnuzilla).

2015-01-11 Thread Ludovic Courtès
宋文武 skribis: > * gnu/packages/plokit.scm (mozjs, nspr): Move to... > * gnu/packages/gnuzilla.scm (mozjs, nspr): ... here. New variables. s/plokit/polkit/ OK to push, thanks. Ludo’.

Re: [PATCH 2/2] gnu: Add nss.

2015-01-11 Thread Ludovic Courtès
宋文武 skribis: > * gnu/packages/patches/nss-pkgconfig.patch: New file. > * gnu-system.scm (dist_patch_DATA): Add it. > * gnu/packages/gnuzilla.scm (nss): New variable. OK! Thanks, Ludo'.

wip-libreoffice status?

2015-01-11 Thread Ludovic Courtès
What’s the status of wip-libreoffice? It seems to have built successfully a couple of times: http://hydra.gnu.org/job/gnu/wip-libreoffice/libreoffice-4.3.2.2.x86_64-linux What about cherry-picking the relevant commits into master (after ‘nss’ has been committed)? Perhaps some cleanup is neede

Re: [PATCH 1/2] gnu: Move mozjs and nspr to (gnu packages gnuzilla).

2015-01-11 Thread 宋文武
Ludovic Courtès writes: > 宋文武 skribis: > >> * gnu/packages/plokit.scm (mozjs, nspr): Move to... >> * gnu/packages/gnuzilla.scm (mozjs, nspr): ... here. New variables. > > s/plokit/polkit/ > > OK to push, thanks. Done, thanks for review! > > Ludo’.

Re: [PATCH] gnu: Add ninja.

2015-01-11 Thread 宋文武
Ludovic Courtès writes: > 宋文武 skribis: > >> From 712f161a358a4bbcf005c5875e6d91eff21bdef4 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= >> Date: Fri, 9 Jan 2015 21:37:30 +0800 >> Subject: [PATCH] gnu: Add ninja. >> >> * gnu/packages/ninja.scm: New file. >> * gnu-syst

Re: [PATCH 1/2] gnu: qt: Update to 5.4.0.

2015-01-11 Thread 宋文武
Ludovic Courtès writes: > 宋文武 skribis: > >> * gnu/packages/qt.scm (qt): Update to 5.4.0. >> [origin]: Add snippet. > > [...] > >> * gnu/packages/qt.scm (qt): Add inputs libxcomposite, libxml2, libxslt, >> mtdev, pcre, eudev. Add native-inputs bison, flex, gperf, python-2, ruby. > > LGTM. I

Re: wip-libreoffice status?

2015-01-11 Thread John Darrington
On Sun, Jan 11, 2015 at 12:03:46PM +0100, Ludovic Courtès wrote: What’s the status of wip-libreoffice? It seems to have built successfully a couple of times: http://hydra.gnu.org/job/gnu/wip-libreoffice/libreoffice-4.3.2.2.x86_64-linux What about cherry-picking t

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-11 Thread Federico Beffa
On Sun, Jan 11, 2015 at 11:59 AM, Ludovic Courtès wrote: > I’m a bit concerned about readability. What about doing it this way: > > 1. Make an actual patch for libcanberra, with @SOUND_THEME_DIRECTORY@ > as a placeholder for the sound-theme-freedesktop directory. > > 2. Add this patch to

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-11 Thread Federico Beffa
On Sun, Jan 11, 2015 at 2:04 PM, Federico Beffa wrote: > Good idea! Here the updated patch. seeing my own post I noticed that I had tabs instead of spaces in the patch. Here I've corrected that. Fede From 14abfc26e7b45aa5644104fa661f34f3a70323ae Mon Sep 17 00:00:00 2001 From: Federico Beffa Dat

Trivial build system

2015-01-11 Thread Andreas Enge
Hello, in my work on texlive, I am trying to build a package by simply applying the 'unpack and 'patch-source-shebangs phases of gnu-build-system. A working approach is to delete all other phases from gnu-build-system, but that would break the package whenever gnu-build-system is augmented. So I t

Re: Trivial build system

2015-01-11 Thread Andreas Enge
I also wonder if we should not modify the structure of our build system code. Our different build systems end up calling gnu:gnu-build with a list of phases. Could this not be done all the time? And then a build system be defined as a list of phases? For instance, trivial-build-system could be the

Re: Trivial build system

2015-01-11 Thread David Thompson
Andreas Enge writes: > in my work on texlive, I am trying to build a package by simply applying > the 'unpack and 'patch-source-shebangs phases of gnu-build-system. A working > approach is to delete all other phases from gnu-build-system, but that would > break the package whenever gnu-build-syst

Re: Trivial build system

2015-01-11 Thread Andreas Enge
On Sun, Jan 11, 2015 at 04:12:47PM +0100, Andreas Enge wrote: > In execvp of tar: No such file or directory Hm, it looks to me as if "tar" is the file not found and not its argument, and that I am missing the 'set-paths phase. But this has tons of arguments, which I do not know how to set in my bu

Re: Optional runtime dependencies in Guix

2015-01-11 Thread Gammel Holte
Apologies for the really late reply. Sadly I was ill for the best part of December. So I wouldn’t claim this is a solved problem, because it really gets > fixed when we discover a problematic case, and we certainly overlook > some of them. Yet, that’s something I pay attention to, and I think we

Re: Trivial build system

2015-01-11 Thread Andreas Enge
On Sun, Jan 11, 2015 at 10:33:04AM -0500, David Thompson wrote: > Rather than deleting the other known phases, how about just selecting > the 2 phases you are interested in? > (map (cut assq <> %standard-phases) >'(unpack patch-source-shebangs)) Thanks a lot, that did the trick (together