Re: swh-plugins-lv2: New variable [WIP, v2]

2016-11-04 Thread Ricardo Wurmus
Hi Flo, > On 12/06/2015 11:44 PM, Florian Paul Schmidt wrote: >> Just pushing this out to get some feedback (I'll need to package more >> audio plugins and this might be a good start to talk about possible issues) > > Updated the patch, since it seems the other version didn't get submitted.. I’m

Re: swh-plugins-lv2: New variable [WIP, v2]

2015-12-10 Thread Florian Paul Schmidt
On 12/06/2015 11:44 PM, Florian Paul Schmidt wrote: > Just pushing this out to get some feedback (I'll need to package more > audio plugins and this might be a good start to talk about possible issues) Updated the patch, since it seems the other version didn't get submitted.. Flo -- https://fp

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-09 Thread Leo Famulari
On Wed, Dec 09, 2015 at 09:56:37PM +0100, Ludovic Courtès wrote: > Leo Famulari skribis: > > > On Tue, Dec 08, 2015 at 09:52:30AM +0100, Ludovic Courtès wrote: > >> Mark H Weaver skribis: > >> > >> > Ricardo Wurmus writes: > >> > > >> >>> +(define-public swh-plugins-lv2 > >> >>> + (let ((comm

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-09 Thread Ludovic Courtès
Leo Famulari skribis: > On Tue, Dec 08, 2015 at 09:52:30AM +0100, Ludovic Courtès wrote: >> Mark H Weaver skribis: >> >> > Ricardo Wurmus writes: >> > >> >>> +(define-public swh-plugins-lv2 >> >>> + (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea")) >> >> >> >> We usually don’t use fu

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-09 Thread Leo Famulari
On Tue, Dec 08, 2015 at 09:52:30AM +0100, Ludovic Courtès wrote: > Mark H Weaver skribis: > > > Ricardo Wurmus writes: > > > >>> +(define-public swh-plugins-lv2 > >>> + (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea")) > >> > >> We usually don’t use full commit hashes. You could proba

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-08 Thread Ludovic Courtès
Florian Paul Schmidt skribis: > fps@cherry ~/src/guix [env]$ ./pre-inst-env guix lint swh-plugins-lv2 > ;;; note: source file /home/fps/src/guix/gnu/packages/audio.scm > ;;; newer than compiled /home/fps/src/guix/gnu/packages/audio.go > fps@cherry ~/src/guix [env]$ > -11-11-5098e09e255eaed1

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-08 Thread Ludovic Courtès
Mark H Weaver skribis: > Ricardo Wurmus writes: > >>> +(define-public swh-plugins-lv2 >>> + (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea")) >> >> We usually don’t use full commit hashes. You could probably trim it to >> the first six characters or so. > > I would recommend using at

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-07 Thread Leo Famulari
On Mon, Dec 07, 2015 at 10:17:38PM +0100, Ricardo Wurmus wrote: > Hi Florian, > > thanks for the patch! > > > From 6dee84494a522921baacbcad8c7618c9eb709eb1 Mon Sep 17 00:00:00 2001 > > From: Florian Paul Schmidt > > Date: Wed, 2 Dec 2015 15:30:14 +0100 > > Subject: [PATCH] swh-plugins-lv2: New v

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-07 Thread Mark H Weaver
Ricardo Wurmus writes: >> +(define-public swh-plugins-lv2 >> + (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea")) > > We usually don’t use full commit hashes. You could probably trim it to > the first six characters or so. I would recommend using at least 10 characters, maybe more. We

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-07 Thread Ricardo Wurmus
Florian Paul Schmidt writes: >>> + (alist-cons-after >> >> Please use ‘modify-phases’ instead of the ‘alist-*’ stuff. > > OK, noted. I think I searched through other packages to come up with this. > > fps@cherry ~/src/guix [env]$ grep "#:phases (alist-cons-after" > gnu/packages/*.scm | wc

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-07 Thread Florian Paul Schmidt
On 12/07/2015 10:17 PM, Ricardo Wurmus wrote: Hi Florian, thanks for the patch! Hi rekado, thanks for the feedback :) The commit message should be: gnu: Add swh-plugins-lv2. * gnu/packages/audio.scm (swh-plugins-lv2): New variable. Oh drats, no more -a -m "lalalala" commits.

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-07 Thread Ricardo Wurmus
Hi Florian, thanks for the patch! > From 6dee84494a522921baacbcad8c7618c9eb709eb1 Mon Sep 17 00:00:00 2001 > From: Florian Paul Schmidt > Date: Wed, 2 Dec 2015 15:30:14 +0100 > Subject: [PATCH] swh-plugins-lv2: New variable The commit message should be: gnu: Add swh-plugins-lv2. * gnu

Re: swh-plugins-lv2: New variable [WIP] v2

2015-12-06 Thread Florian Paul Schmidt
On 12/06/2015 11:44 PM, Florian Paul Schmidt wrote: Just pushing this out to get some feedback (I'll need to package more audio plugins and this might be a good start to talk about possible issues) Updated complete patch with some whitespace and typos fixed Flo From 6dee84494a522921baacbcad8

swh-plugins-lv2: New variable [WIP]

2015-12-06 Thread Florian Paul Schmidt
Just pushing this out to get some feedback (I'll need to package more audio plugins and this might be a good start to talk about possible issues) See the attached diff.. Flo From 905622fe8bf6522765002a2ee3f7815b5bf458ea Mon Sep 17 00:00:00 2001 From: Florian Paul Schmidt Date: Wed, 2 Dec 2015