Re: rav1e AV1 encoder

2020-04-26 Thread Efraim Flashner
On Sun, Apr 26, 2020 at 01:48:00PM -0400, Leo Famulari wrote: > On Sun, Apr 26, 2020 at 08:05:34PM +0300, Efraim Flashner wrote: > > I squashed all the cargo commits together and pushed them. I didn't push > > the one with adding rav1e to ffmpeg, I wasn't sure how much that would > > add to 'guix s

Re: rav1e AV1 encoder

2020-04-26 Thread Leo Famulari
On Sun, Apr 26, 2020 at 08:05:34PM +0300, Efraim Flashner wrote: > I squashed all the cargo commits together and pushed them. I didn't push > the one with adding rav1e to ffmpeg, I wasn't sure how much that would > add to 'guix size'. It's okay to delete the wip-rav1e branch now, right? signatur

Re: rav1e AV1 encoder

2020-04-26 Thread Leo Famulari
On Sun, Apr 26, 2020 at 08:05:34PM +0300, Efraim Flashner wrote: > I squashed all the cargo commits together and pushed them. I didn't push > the one with adding rav1e to ffmpeg, I wasn't sure how much that would > add to 'guix size'. Amazing, thank you!!! I intended the FFmpeg commit as a "demo"

Re: rav1e AV1 encoder

2020-04-26 Thread Efraim Flashner
I squashed all the cargo commits together and pushed them. I didn't push the one with adding rav1e to ffmpeg, I wasn't sure how much that would add to 'guix size'. -- Efraim Flashner אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guarantee

Re: sorting Rust crates [was Re: rav1e AV1 encoder]

2020-04-14 Thread Martin Becze
The problem should be fixed now. You can try it out about cloning `git clone https://gitlab.com/mjbecze/guix-package-sorter && cd guix-package-sorter` then do `./pre-install-env guix sort ` to sort the given file. Let me know if it works! On 4/12/20 10:22 AM, Martin Becze wrote: I apologize I

Re: sorting Rust crates [was Re: rav1e AV1 encoder]

2020-04-12 Thread Martin Becze
I apologize I didn't see this message until now. I will look into this today. On 4/2/20 5:31 PM, Leo Famulari wrote: On Fri, Feb 21, 2020 at 04:15:43AM -0500, Martin Becze wrote: sort2.scm will sort a files exported packages alphanumerically. I'm working on packaging rav1e for Guix again and

sorting Rust crates [was Re: rav1e AV1 encoder]

2020-04-02 Thread Leo Famulari
On Fri, Feb 21, 2020 at 04:15:43AM -0500, Martin Becze wrote: > sort2.scm will sort a files exported packages alphanumerically. I'm working on packaging rav1e for Guix again and so I'm using sort2.scm on the big 'gnu/packages/crates-io.scm' module. One problem I noticed with sort2.scm is that inh

Re: rav1e AV1 encoder

2020-02-28 Thread Martin Becze
On 2/27/20 12:26 PM, Leo Famulari wrote: I'm wondering if I can just push the crates as a single commit, after inserting them alphabetically and fixing any cosmetic issues, and also handling the semver-compatible package updates. I know that we don't usually do this when adding packages to an

Re: rav1e AV1 encoder

2020-02-28 Thread Efraim Flashner
On Thu, Feb 27, 2020 at 12:26:13PM -0500, Leo Famulari wrote: > I'm wondering if I can just push the crates as a single commit, after > inserting them alphabetically and fixing any cosmetic issues, and also > handling the semver-compatible package updates. > > I know that we don't usually do this

Re: rav1e AV1 encoder

2020-02-28 Thread Efraim Flashner
On Thu, Feb 27, 2020 at 12:16:02PM -0500, Leo Famulari wrote: > On Wed, Feb 26, 2020 at 09:09:05AM +0200, Efraim Flashner wrote: > > Short of resorting them I'd start with ones that have no dependencies, > > just rely on rust-quote & friends or are older versions. Some packages, > > like rust-futur

Re: rav1e AV1 encoder

2020-02-27 Thread Leo Famulari
I'm wondering if I can just push the crates as a single commit, after inserting them alphabetically and fixing any cosmetic issues, and also handling the semver-compatible package updates. I know that we don't usually do this when adding packages to an existing module. We do add packages en masse

Re: rav1e AV1 encoder

2020-02-27 Thread Leo Famulari
On Wed, Feb 26, 2020 at 09:09:05AM +0200, Efraim Flashner wrote: > Short of resorting them I'd start with ones that have no dependencies, > just rely on rust-quote & friends or are older versions. Some packages, > like rust-futures-*, should be updated as a group since they all expect > to be the s

Re: rav1e AV1 encoder

2020-02-25 Thread Efraim Flashner
On Tue, Feb 25, 2020 at 11:14:29PM -0500, Leo Famulari wrote: > On Tue, Feb 25, 2020 at 01:21:18PM -0800, John Soo wrote: > > You should be committing packages in topological order but the file > > order is alphabetical. This is at least partially my fault; I suggested that the packages be sorted

Re: rav1e AV1 encoder

2020-02-25 Thread Leo Famulari
On Tue, Feb 25, 2020 at 01:21:18PM -0800, John Soo wrote: > You should be committing packages in topological order but the file > order is alphabetical. > > Good luck, rust is a ton of work. Okay, that makes sense. I tried to use `guix graph` to learn the shape of the package graph but it doesn

Re: rav1e AV1 encoder

2020-02-25 Thread John Soo
Hi Leo, > Since the packages refer to each other, committing them individually breaks the build until the entire commit series is complete. This will break `git bisect` for 267 commits (the number of packages). You should be committing packages in topological order but the file order is alphabe

Re: rav1e AV1 encoder

2020-02-25 Thread Leo Famulari
On Fri, Feb 21, 2020 at 04:15:43AM -0500, Martin Becze wrote: > On 2/20/20 5:43 PM, Leo Famulari wrote: > > And if so, should it > > be done as a single commit? Or one-by-one? > > One-by-one unfortunately I've been working on this and I've committed about 3000 lines of these packages by hand. Bu

Re: rav1e AV1 encoder

2020-02-24 Thread Martin Becze
However, it does not successfully handle inherited packages, doing things like removing rust-aho-corasick-0.7 even though rust-aho-corasick-0.6 inherits from it. Handling inheritance could be tricky, I have fully thought that part though. Additionally, the commit diffs it creates are a lit

Re: rav1e AV1 encoder

2020-02-22 Thread Leo Famulari
On Sat, Feb 22, 2020 at 06:09:33AM -0500, Martin Becze wrote: > You need to remove the "(use-modules ..." from rav1e-sorted.scm, it should > only have package definitions into. Ah, I see! After removing that, the merge.scm script does run. However, it does not successfully handle inherited packag

Re: rav1e AV1 encoder

2020-02-22 Thread Martin Becze
You need to remove the "(use-modules ..." from rav1e-sorted.scm, it should only have package definitions into. Ill also find away to handle that more elegantly On 2/21/20 11:56 AM, Leo Famulari wrote: On Fri, Feb 21, 2020 at 11:46:58AM -0500, Martin Becze wrote: hmm do you mind sending me rav

Re: rav1e AV1 encoder

2020-02-21 Thread Martin Becze
hmm do you mind sending me rav1e-sorted.scm? Thanks for the report! On 2/21/20 11:41 AM, Leo Famulari wrote: On Fri, Feb 21, 2020 at 04:15:43AM -0500, Martin Becze wrote: 2) Sort the packages, `guile -s ./sort2.scm mypackage.scm > mypackage.scm` (you will probably also want to sort crates-io.sc

Re: rav1e AV1 encoder

2020-02-21 Thread Martin Becze
hmm do you mind sending me rav1e-sorted.scm? Thanks for the report! On 2/21/20 11:41 AM, Leo Famulari wrote: On Fri, Feb 21, 2020 at 04:15:43AM -0500, Martin Becze wrote: 2) Sort the packages, `guile -s ./sort2.scm mypackage.scm > mypackage.scm` (you will probably also want to sort crates-io.sc

Re: rav1e AV1 encoder

2020-02-21 Thread Leo Famulari
On Fri, Feb 21, 2020 at 04:15:43AM -0500, Martin Becze wrote: > 2) Sort the packages, `guile -s ./sort2.scm mypackage.scm > mypackage.scm` > (you will probably also want to sort crates-io.scm, i think some packages > may be out-of-order now) I sorted rav1e.scm and crates-io.scm, no problem... > 3

Re: rav1e AV1 encoder

2020-02-21 Thread Leo Famulari
On Fri, Feb 21, 2020 at 04:15:43AM -0500, Martin Becze wrote: > I have a small tool I have been working will make the new packages easier to > commit its very much WIP but if I would appreciate any feedback. > Attached is sort2.scm and merge.scm Awesome, thanks. I will give it a try!

Re: rav1e AV1 encoder

2020-02-21 Thread Martin Becze
On 2/20/20 5:43 PM, Leo Famulari wrote: Should they be added to (gnu packages crates-io)? yep! And if so, should it be done as a single commit? Or one-by-one? One-by-one unfortunately It's 258 new packages, and figuring out the order they should be added in seems... too hard. They s

rav1e AV1 encoder

2020-02-20 Thread Leo Famulari
I've pushed a branch wip-rav1e to Savannah: https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-rav1e With this branch I can successfully (slowly!) encode AV1 video using librav1e in FFmpeg. I need some advice about the Rust packages. I used Martin Becze's recursive version-aware Rust crate im