Re: hackage importer broken

2017-02-05 Thread Ricardo Wurmus
Federico Beffa writes: > Hi, > > I notice that with a recent Guix checkout (commit > d8e85b20325073d90cfaf3060889d59d91362deb) the hackage importer doesn't > work and the problem seems to be with Guile itself or the lalr par

Re: hackage importer broken

2017-02-05 Thread Federico Beffa
On Fri, Feb 3, 2017 at 2:53 PM, Federico Beffa wrote: > Hi, > > I notice that with a recent Guix checkout (commit > d8e85b20325073d90cfaf3060889d59d91362deb) the hackage importer doesn't > work and the problem seems to be with Guile itself or the lalr par

hackage importer broken

2017-02-03 Thread Federico Beffa
Hi, I notice that with a recent Guix checkout (commit d8e85b20325073d90cfaf3060889d59d91362deb) the hackage importer doesn't work and the problem seems to be with Guile itself or the lalr parser coming wi

Re: hackage importer problem

2016-08-26 Thread Federico Beffa
John J Foerch writes: > Hello, > > I'm seeing a problem with the hackage importer with the git-annex > package: > > $ guix import hackage git-annex > Syntax error: unexpected token : custom-setup (at line 316, column 0) > Syntax error: unexpected end of input &

hackage importer problem

2016-08-25 Thread John J Foerch
Hello, I'm seeing a problem with the hackage importer with the git-annex package: $ guix import hackage git-annex Syntax error: unexpected token : custom-setup (at line 316, column 0) Syntax error: unexpected end of input guix import: error: failed to download cabal file for package

Re: hackage importer

2015-06-09 Thread Federico Beffa
On Tue, Jun 9, 2015 at 9:38 AM, Ludovic Courtès wrote: > OK to commit, thank you! Pushed. > PS: Commit 751630c adds n-ary >>= for your pleasure. ;-) Thanks :-) Fede

Re: hackage importer

2015-06-09 Thread Ludovic Courtès
Federico Beffa skribis: > On Fri, Jun 5, 2015 at 9:30 AM, Ludovic Courtès wrote: [...] >>> +(define (make-stack) >>> + "Creates a simple stack closure. Actions on the generated stack are >>> +requested by calling it with one of the following symbols as the first >>> +argument: 'empty?, 'push

Re: hackage importer

2015-06-05 Thread Federico Beffa
On Fri, Jun 5, 2015 at 9:30 AM, Ludovic Courtès wrote: >> I've removed the test with TABs because the Cabal documentation says >> explicitly that they are not allowed. >> https://www.haskell.org/cabal/users-guide/developing-packages.html#package-descriptions > > But are they actually used in pract

Re: hackage importer

2015-06-05 Thread Ludovic Courtès
Howdy! Federico Beffa skribis: > On Sat, May 2, 2015 at 2:48 PM, Ludovic Courtès wrote: [...] >> This procedure is intimidating. I think this is partly due to its >> length, to the big let-values, the long identifiers, the many local >> variables, nested binds, etc. > > Ok, this procedure ha

Re: hackage importer

2015-06-01 Thread Federico Beffa
Hi, sorry for taking so long to answer! On Sat, May 2, 2015 at 2:48 PM, Ludovic Courtès wrote: >> Subject: [PATCH] import: hackage: Refactor parsing code and add new option. >> >> * guix/import/cabal.scm: New file. >> >> * guix/import/hackage.scm: Update to use the new Cabal parsing module. >> >

Re: hackage importer

2015-05-02 Thread Ludovic Courtès
Federico Beffa skribis: > Please find attached a patch reorganizing the code as you suggest. Woow, neat! Impressive work. I think this is a great improvement. I have a bunch of stylistic comments below, and some open questions as well. > From bc8cdab1e322a25002a3d9cf33eddd856c8a81d8 Mon Sep

Re: hackage importer

2015-04-26 Thread Federico Beffa
Federico Beffa writes: > Please find attached a patch reorganizing the code as you suggest. Just noticed that I forgot to delete 'parse-cabal' from the public interface of the cabal module. Regards, Fede

Re: hackage importer

2015-04-26 Thread Federico Beffa
On Tue, Mar 31, 2015 at 3:33 PM, Ludovic Courtès wrote: > I think it’s a matter of separating concerns. In my mind there are > three distinct layers: > > 1. Cabal parsing (what I call ‘read-cabal’, because it’s the > equivalent of ‘read’); > > 2. Cabal evaluation/instantiation for a cert

Re: hackage importer

2015-04-05 Thread Ludovic Courtès
ow an > exception of type '&message' is raised with a meaningful message. OK. > From 633bfb5af57f707dea12ab747133182d085951ff Mon Sep 17 00:00:00 2001 > From: Federico Beffa > Date: Sat, 7 Mar 2015 17:23:14 +0100 > Subject: [PATCH 01/29] import: Add hackage importer

Re: hackage importer

2015-04-03 Thread Federico Beffa
as suggested and made local to the former. If parsing fails now an exception of type '&message' is raised with a meaningful message. Regards, Fede From 633bfb5af57f707dea12ab747133182d085951ff Mon Sep 17 00:00:00 2001 From: Federico Beffa Date: Sat, 7 Mar 2015 17:23:14 +0100 Subj

Re: hackage importer

2015-03-31 Thread Ludovic Courtès
Federico Beffa skribis: > On Sun, Mar 29, 2015 at 3:58 PM, Ludovic Courtès wrote: >>> On Thu, Mar 26, 2015 at 2:09 PM, Ludovic Courtès wrote: Could you post the actual backtrace you get (?) when running the program with LC_ALL=C? >>> >>> I doesn't backtrace, the function just gives th

Re: hackage importer

2015-03-29 Thread Federico Beffa
On Sun, Mar 29, 2015 at 3:58 PM, Ludovic Courtès wrote: >> On Thu, Mar 26, 2015 at 2:09 PM, Ludovic Courtès wrote: >>> Could you post the actual backtrace you get (?) when running the program >>> with LC_ALL=C? >> >> I doesn't backtrace, the function just gives the wrong result. > > Hmm, OK. Sti

Re: hackage importer

2015-03-29 Thread Ludovic Courtès
Federico Beffa skribis: > On Thu, Mar 26, 2015 at 2:09 PM, Ludovic Courtès wrote: >> Could you post the actual backtrace you get (?) when running the program >> with LC_ALL=C? > > I doesn't backtrace, the function just gives the wrong result. Hmm, OK. Still sounds like an encoding error.

Re: hackage importer

2015-03-28 Thread Federico Beffa
On Thu, Mar 26, 2015 at 2:09 PM, Ludovic Courtès wrote: > Could you post the actual backtrace you get (?) when running the program > with LC_ALL=C? I doesn't backtrace, the function just gives the wrong result. I think the problem was caused by the character § that I did introduce to mark some ca

Re: hackage importer

2015-03-26 Thread Ludovic Courtès
t;>> +;; version information is discarded. >> >> s/GUIX/Guix/ > > OK > >>> +(define (split-dependencies ls) >>> + (define (split-at-comma d) >>> +(map >>> + (lambda (m) >>> + (let ((name (guix-name (match:substring m

Re: hackage importer

2015-03-22 Thread Federico Beffa
al-install.cabal" >> read-cabal))) >> +;; (display (get-flags (pre-process-entries-keys (cabal->key-values >> test-5 >> +;; (newline) >> +;; (display (conditional->sexp-like test-cond-2)) >> +;; (newline) >> +;; (display >> +;; (

Re: hackage importer

2015-03-15 Thread Federico Beffa
Thanks for the review! I'm currently on a business trip. Will look carefully at your comments when I will be back. Regards, Fede On Sun, Mar 15, 2015 at 2:38 PM, Ludovic Courtès wrote: > Federico Beffa skribis: > >> please find attached an initial version of an importer for packages >> from Ha

Re: hackage importer

2015-03-15 Thread Ludovic Courtès
Federico Beffa skribis: > please find attached an initial version of an importer for packages > from Hackage: > http://hackage.haskell.org/ Woow, impressive piece of work! [...] > * The code handles dependencies with conditionals and tries to comply > with the description at > https://www.hask

hackage importer

2015-03-13 Thread Federico Beffa
Hi, please find attached an initial version of an importer for packages from Hackage: http://hackage.haskell.org/ Here a couple of features and limitations: * The information about packages is retrieved from .cabal files. Similarly to Haskell code these files support "layout" style grouping and