Re: Use and abuse of ‘computed-origin-method’: the ‘rust-ring’ case

2025-01-07 Thread Ludovic Courtès
Efraim Flashner skribis: > I ended up making the changes and pushing them to the rust-team branch. > Rust-team is right after mesa-updates, so we should be landing it soon™ > > ¹ > https://git.savannah.gnu.org/cgit/guix.git/commit/?h=rust-team&id=39c1a5f48e9f7a175be7b3c22a76d3ec2d9fc840 > https:

Re: Use and abuse of ‘computed-origin-method’: the ‘rust-ring’ case

2024-12-30 Thread Efraim Flashner
On Sun, Dec 29, 2024 at 10:39:41PM +0100, Ludovic Courtès wrote: > Hey Efraim, > > Ludovic Courtès skribis: > > >> + (package > >> +(name "rust-ring") > >> +(version "0.17.8.tar.gz") ; Hack to adjust the output name. > >> +(source (origin > >> (method git-fetch) > >>

Re: Use and abuse of ‘computed-origin-method’: the ‘rust-ring’ case

2024-12-29 Thread Ludovic Courtès
Hey Efraim, Ludovic Courtès skribis: >> + (package >> +(name "rust-ring") >> +(version "0.17.8.tar.gz") ; Hack to adjust the output name. >> +(source (origin >> (method git-fetch) >> (uri (git-reference >> (url "https://github.com/b

Re: Use and abuse of ‘computed-origin-method’: the ‘rust-ring’ case

2024-12-15 Thread Ludovic Courtès
Hi! Efraim Flashner skribis: >> Anyway, the ‘computed-origin-method’ hack prevents input rewriting from >> working as expected because the inputs of that big gexp aren’t visible >> by just traversing the package graph. That’s a problem. > > Are we talking about the inputs used for the computed-

Re: Use and abuse of ‘computed-origin-method’: the ‘rust-ring’ case

2024-12-15 Thread Efraim Flashner
Thanks for bringing this up! rust-ring, while an interesting experiment in how to package software which doesn't play well with rebuilding sources, is certainly not something we want to have be the norm. On Sat, Dec 14, 2024 at 11:37:53PM +0100, Ludovic Courtès wrote: > Hello Guix, > > ‘rust-rin

Use and abuse of ‘computed-origin-method’: the ‘rust-ring’ case

2024-12-14 Thread Ludovic Courtès
Hello Guix, ‘rust-ring-0.16-sources’ & co. are origins that use ‘computed-origin-method’ (the thing that’s internal and undocumented) to generate object files from assembly source, things like that. An origin is supposed to represent source code, and clearly, the end result here is not source by