Re: Some macros to make package definitions prettier

2015-03-04 Thread Ludovic Courtès
taylanbayi...@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis: > l...@gnu.org (Ludovic Courtès) writes: > >> I actually agree. Well, next round? > > If you want. :-) I thought it might be too much to have a second commit > that touches all recipes where 'modify-phases' is used, but maybe I'm >

Re: Some macros to make package definitions prettier

2015-03-03 Thread Taylan Ulrich Bayırlı/Kammer
l...@gnu.org (Ludovic Courtès) writes: > I actually agree. Well, next round? If you want. :-) I thought it might be too much to have a second commit that touches all recipes where 'modify-phases' is used, but maybe I'm being too pedantic. > In think Guile 2.1 is standards-compliant in that resp

Re: Some macros to make package definitions prettier

2015-03-03 Thread Ludovic Courtès
taylanbayi...@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis: > l...@gnu.org (Ludovic Courtès) writes: > >> I’ve applied it locally and will push shortly. > > It might be too late, but I have a nitpick on my macro: the implicit > quoting of phase names 1. makes it impossible to provide them >

Re: Some macros to make package definitions prettier

2015-03-03 Thread Taylan Ulrich Bayırlı/Kammer
l...@gnu.org (Ludovic Courtès) writes: > I’ve applied it locally and will push shortly. It might be too late, but I have a nitpick on my macro: the implicit quoting of phase names 1. makes it impossible to provide them dynamically (e.g. procedure argument), 2. might give an illusion that they're

Re: Some macros to make package definitions prettier

2015-02-26 Thread Taylan Ulrich Bayırlı/Kammer
l...@gnu.org (Ludovic Courtès) writes: > taylanbayi...@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis: > >> (modify-phases '((foo . 0) (bar . 1) (baz . 2)) >> (delete foo) >> (replace bar 'x) >> (add-before baz pre-baz 'y)) ;=> ((bar . x) (pre-baz . y) (baz . 2)) > > I like it! Let’s pu

Re: Some macros to make package definitions prettier

2015-02-25 Thread Ludovic Courtès
taylanbayi...@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis: > (modify-phases '((foo . 0) (bar . 1) (baz . 2)) > (delete foo) > (replace bar 'x) > (add-before baz pre-baz 'y)) ;=> ((bar . x) (pre-baz . y) (baz . 2)) I like it! Let’s put it in (guix utils)? > ;;; phase-lambda > > (def

Re: Some macros to make package definitions prettier

2015-02-25 Thread Thompson, David
On Wed, Feb 25, 2015 at 1:12 PM, Andreas Enge wrote: > > On Wed, Feb 25, 2015 at 05:42:23PM +0100, Taylan Ulrich Bayırlı/Kammer wrote: >> (delete foo) >> (replace bar 'x) >> (add-before baz pre-baz 'y)) ;=> ((bar . x) (pre-baz . y) (baz . 2)) >> This has the following advantages: >> - The or

Re: Some macros to make package definitions prettier

2015-02-25 Thread Taylan Ulrich Bayırlı/Kammer
"Thompson, David" writes: > On Wed, Feb 25, 2015 at 12:04 PM, Thompson, David > wrote: > >> I understand the temptation to name it 'modify-phases', but since this >> macro applies to any alist, I think 'modify-alist' or something with >> "alist" in the name would be more appropriate. > > Looking

Re: Some macros to make package definitions prettier

2015-02-25 Thread Thompson, David
On Wed, Feb 25, 2015 at 12:04 PM, Thompson, David wrote: > I understand the temptation to name it 'modify-phases', but since this > macro applies to any alist, I think 'modify-alist' or something with > "alist" in the name would be more appropriate. Looking again, I see that the above isn't quit