Re: ui: Move 'show-manifest-transaction' from (guix profiles).

Alex Kost skribis: > OK, I have not pushed anything yet, as the commits were changed a bit. > I'm attaching all 3 patches for adding “Switch to generation” support. > Everything seems OK now (at least “make check” does not fail anymore), > so if you don't have final comments, I would like to comm

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

Ludovic Courtès (2014-10-10 16:15 +0400) wrote: > Alex Kost skribis: > >> Ludovic Courtès (2014-10-10 02:08 +0400) wrote: > > [...] > >>> This is bikeshedding, but I would make a hierarchy like this: >>> >>> &profile-error, with ‘profile’ field >>>

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

Alex Kost skribis: > Ludovic Courtès (2014-10-10 02:08 +0400) wrote: [...] >> This is bikeshedding, but I would make a hierarchy like this: >> >> &profile-error, with ‘profile’ field >> ^ >>.———–+———–. >>

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

Ludovic Courtès (2014-10-10 02:08 +0400) wrote: > l...@gnu.org (Ludovic Courtès) skribis: > >> There’s: >> >> (guix store) -> (guix nar) -> (guix ui) -> (guix store) ... > > Commit 0363991 fixes that. > > (Now we must make sure we don’t reintroduce cycles in these modules; > probably we should i

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

l...@gnu.org (Ludovic Courtès) skribis: > There’s: > > (guix store) -> (guix nar) -> (guix ui) -> (guix store) ... Commit 0363991 fixes that. (Now we must make sure we don’t reintroduce cycles in these modules; probably we should integrate Mark’s cycle detection script somehow.) With that I w

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

Alex Kost skribis: > Ludovic Courtès (2014-10-08 23:55 +0400) wrote: [...] >> However, back to the initial problem, is this a problem if the error >> conditions are defined in (guix profiles), which is then imported by >> (guix ui)? This is suboptimal, but this kind of circular reference >> sh

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

Ludovic Courtès (2014-10-08 23:55 +0400) wrote: > Alex Kost skribis: [...] > This is another circularity issue. :-/ > > There’s: > > (guix store) -> (guix nar) -> (guix ui) -> (guix store) ... > > This shouldn’t be a problem, except that occasional uses of #:select > trigger a bug (see

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

Alex Kost skribis: >?: 16 [primitive-load-path "guix/profiles" ...] > In guix/profiles.scm: > 21: 15 [#] > In ice-9/boot-9.scm: > 2951: 14 [define-module* (guix profiles) #:filename ...] > 2926: 13 [resolve-imports (((guix utils)) ((guix records)) ((guix > derivations)) ...)] > 2864: 12 [r

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

Sorry, I've found that the patch I sent is not cleanly applied to the latest master checkout. The modified patch is attached. It seems the fail happens only if there is #:use-module (guix profiles) in (guix ui). If (guix profiles) is not used, there are no problems. I'm stuck. >From 480c22f