Re: Regarding "Use Invoke" or "Return a boolean from phase" commits

2018-06-07 Thread Ludovic Courtès
Mark H Weaver skribis: >> If the analyzer doesn’t cover 100% of the packages, we’ll rely on manual >> testing as we rebuild everything anyway—pretty much like when we do a >> regular ‘core-updates’ cycle. > > If I'm not mistaken, the combination of checkers mentioned above should > give 100% cove

Re: Regarding "Use Invoke" or "Return a boolean from phase" commits

2018-06-04 Thread Mark H Weaver
Hi Ludovic, l...@gnu.org (Ludovic Courtès) writes: > Mark H Weaver skribis: > >> Furthermore, it will be important for a static code analyzer to be able >> to infer that phases and snippets always return #t, so let's try not to >> be too clever about it. We'll need a static analyzer to gain con

Re: Regarding "Use Invoke" or "Return a boolean from phase" commits

2018-06-04 Thread Ludovic Courtès
Hello Mark, Mark H Weaver skribis: > Furthermore, it will be important for a static code analyzer to be able > to infer that phases and snippets always return #t, so let's try not to > be too clever about it. We'll need a static analyzer to gain confidence > that we can start ignoring the retur