Re: Phases and snippets no longer returning a Boolean

2020-11-29 Thread Maxim Cournoyer
Hey, Ludovic Courtès writes: > Hello Guix! > > As a followup to our recent discussion¹, I pushed the following commits > to ‘core-updates’: > > 16111ad11c gnu: gcc: Phases no longer return a Boolean. > 3504e39a5d gnu: base, gcc: Removing trailing #t from snippets. > 325d00e619 packages: Ig

Re: Phases and snippets no longer returning a Boolean

2020-11-27 Thread Ludovic Courtès
Leo Famulari skribis: > On Wed, Nov 25, 2020 at 03:02:28PM +0100, zimoun wrote: >> Hi, >> >> Cool for the change! >> >> On Wed, 25 Nov 2020 at 14:27, Danny Milosavljevic >> wrote: >> >> >> I only removed trailing #t in a couple of files unlikely to result in >> >> merge conflicts down the ro

Re: Phases and snippets no longer returning a Boolean

2020-11-25 Thread Leo Famulari
On Wed, Nov 25, 2020 at 03:02:28PM +0100, zimoun wrote: > Hi, > > Cool for the change! > > On Wed, 25 Nov 2020 at 14:27, Danny Milosavljevic > wrote: > > >> I only removed trailing #t in a couple of files unlikely to result in > >> merge conflicts down the road, as Marius rightfully suggested

Re: Phases and snippets no longer returning a Boolean

2020-11-25 Thread zimoun
Hi, Cool for the change! On Wed, 25 Nov 2020 at 14:27, Danny Milosavljevic wrote: >> I only removed trailing #t in a couple of files unlikely to result in >> merge conflicts down the road, as Marius rightfully suggested on IRC. > > I agree that we shouldn't graciously remove "#t"s in existing

Re: Phases and snippets no longer returning a Boolean

2020-11-25 Thread Danny Milosavljevic
Hi Ludo, On Wed, 25 Nov 2020 00:17:41 +0100 Ludovic Courtès wrote: > With these changes, the return value of origin snippets and build phases > is now ignored. Good riddance :) No, seriously, good change. > I only removed trailing #t in a couple of files unlikely to result in > merge conflict

Re: Phases and snippets no longer returning a Boolean

2020-11-25 Thread 宋文武
Ludovic Courtès writes: > With these changes, the return value of origin snippets and build phases > is now ignored. > ... > > That’s it! Thoughts? Comments? Indeed better! Return ‘#t’ feel perlish, perl requires return ‘1’ at the end of each module.