Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-07 Thread Ludovic Courtès
Jan Nieuwenhuizen skribis: > From 060f9123acd4c6771e976c5442361285f8c8bc89 Mon Sep 17 00:00:00 2001 > From: Jan Nieuwenhuizen > Date: Tue, 6 Sep 2016 08:28:33 +0200 > Subject: [PATCH] scripts: hash: Add --exclude-vcs option. > > * guix/scripts/hash.scm (show-help): Add help text for --exclude-vc

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-06 Thread Ludovic Courtès
Jan Nieuwenhuizen skribis: >> What about --exclude-vcs/-x? Tar uses that name, although with slightly >> different semantics (info "(tar) exclude"). > > Yes, I like this even better than my 2nd --exclude=FILE patch. I prefer --exclude-vcs too because that’s the main use case, so it’s best to ha

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-06 Thread Ludovic Courtès
Vincent Legoll skribis: > On Mon, Sep 5, 2016 at 11:33 PM, Ludovic Courtès wrote: >> Hello! >> >> Jan Nieuwenhuizen skribis: >> >>> Added an -g/--exclude-.git option for guix hash. It is very specific: >>> it skips toplevel .git directory. WDYT? >> >> Good idea! >> >>> From 86a580840f21f858b7

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-06 Thread Vincent Legoll
On Mon, Sep 5, 2016 at 11:33 PM, Ludovic Courtès wrote: > Hello! > > Jan Nieuwenhuizen skribis: > >> Added an -g/--exclude-.git option for guix hash. It is very specific: >> it skips toplevel .git directory. WDYT? > > Good idea! > >> From 86a580840f21f858b757cb7f421b0ba1c169e09d Mon Sep 17 00:0

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Jan Nieuwenhuizen
Ludovic Courtès writes: Hi! >> Added an -g/--exclude-.git option for guix hash. It is very specific: >> it skips toplevel .git directory. WDYT? > > Good idea! Thanks... > What about --exclude-vcs/-x? Tar uses that name, although with slightly > different semantics (info "(tar) exclude"). Ye

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Ludovic Courtès
Hello! Jan Nieuwenhuizen skribis: > Added an -g/--exclude-.git option for guix hash. It is very specific: > it skips toplevel .git directory. WDYT? Good idea! > From 86a580840f21f858b757cb7f421b0ba1c169e09d Mon Sep 17 00:00:00 2001 > From: Jan Nieuwenhuizen > Date: Mon, 5 Sep 2016 10:27:19

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Leo Famulari
On Mon, Sep 05, 2016 at 11:04:11PM +0200, Jan Nieuwenhuizen wrote: > Efraim Flashner writes: > > > Can this be generalized? `grep \\-download\) gnu/packages/*scm' shows also > > svn-download, cvs-download and a lone hg-download. > > Okay. What about simply having non-default > >--exclude=FI

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Jan Nieuwenhuizen
Efraim Flashner writes: > Can this be generalized? `grep \\-download\) gnu/packages/*scm' shows also > svn-download, cvs-download and a lone hg-download. Okay. What about simply having non-default --exclude=FILE See attached. (Missing test included this time). Greetings, Jan >From ae738a

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Leo Famulari
On Mon, Sep 05, 2016 at 10:49:23PM +0200, Danny Milosavljevic wrote: > Hi Jan, > > On Mon, 05 Sep 2016 10:43:28 +0200 > Jan Nieuwenhuizen wrote: > > Added an -g/--exclude-.git option for guix hash. It is very specific: > > it skips toplevel .git directory. > > Why? To calculate the hash of a

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Leo Famulari
On Mon, Sep 05, 2016 at 01:36:43PM +0200, Jan Nieuwenhuizen wrote: > Vincent Legoll writes: > > >> Added an -g/--exclude-.git option for guix hash. It is very specific: > >> it skips toplevel .git directory. WDYT? > > > > I'd rather name it "--exclude-git" or something less strange than > > --ex

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Danny Milosavljevic
Hi Jan, On Mon, 05 Sep 2016 10:43:28 +0200 Jan Nieuwenhuizen wrote: > Added an -g/--exclude-.git option for guix hash. It is very specific: > it skips toplevel .git directory. Why?

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Efraim Flashner
On Mon, Sep 05, 2016 at 01:36:43PM +0200, Jan Nieuwenhuizen wrote: > Vincent Legoll writes: > > >> Added an -g/--exclude-.git option for guix hash. It is very specific: > >> it skips toplevel .git directory. WDYT? > > > > I'd rather name it "--exclude-git" or something less strange than > > --ex

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Jan Nieuwenhuizen
Vincent Legoll writes: >> Added an -g/--exclude-.git option for guix hash. It is very specific: >> it skips toplevel .git directory. WDYT? > > I'd rather name it "--exclude-git" or something less strange than > --exclude-.git, > even --exclude-dot-git... >> What about make i the default? > > OK

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Vincent Legoll
Hello, here are my 2 cts On Mon, Sep 5, 2016 at 11:20 AM, Hartmut Goebel wrote: > Am 05.09.2016 um 10:43 schrieb Jan Nieuwenhuizen: > > Added an -g/--exclude-.git option for guix hash. It is very specific: > it skips toplevel .git directory. WDYT? I'd rather name it "--exclude-git" or somethin

Re: [PATCH] scripts: hash: Add --exclude-.git option.

2016-09-05 Thread Hartmut Goebel
Am 05.09.2016 um 10:43 schrieb Jan Nieuwenhuizen: > Added an -g/--exclude-.git option for guix hash. It is very specific: > it skips toplevel .git directory. WDYT? +1. What about make i the default? -- Schönen Gruß Hartmut Goebel Dipl.-Informatiker (univ), CISSP, CSSLP, ISO 27001 Lead Impleme