Hi Danny!
Danny Milosavljevic skribis:
> On Wed, 31 Aug 2016 22:40:57 +0200
> l...@gnu.org (Ludovic Courtès) wrote:
>
>> > + (lambda* (#:key outputs make-flags #:allow-other-keys)
>> > + (let ((configname (string-append ,board "_defconfig")))
>>
>> Should be ‘config-name
> I'm not totally against naming filenames "file" - or "f" for that matter -
> but I distinguish for good reason.
I believe I renamed your variables... xD
(replace 'install
+ (lambda* (#:key outputs make-flags #:allow-other-keys)
+ (let ((out (string-append (assoc-ref outpu
Hi Ludo,
On Wed, 31 Aug 2016 22:40:57 +0200
l...@gnu.org (Ludovic Courtès) wrote:
> > + (lambda* (#:key outputs make-flags #:allow-other-keys)
> > + (let ((configname (string-append ,board "_defconfig")))
>
> Should be ‘config-name’ per our conventions, but ‘config’ is pr
David Craven skribis:
> From: Danny Milosavljevic
>
> * gnu/packages/u-boot.scm (u-boot, make-u-boot-package,
> u-boot-vexpress_ca9x4, u-boot-malta armhf-linux-uboot,
> mips64el-linux-uboot): New variables.
>
> Co-authored-by: David Craven
Cool, thanks for picking it up!
Overall this LGTM
On Mon, 29 Aug 2016 20:27:52 +0200
Danny Milosavljevic wrote:
> (find-files "." ".*\\.(bin|efi)$"))
Also in order to support Novena it should be
(find-files "." ".*\\.(bin|efi|spl)$"))
> +(define (make-u-boot-package board triplet xgcc)
...
> + (begin
> + (display "Invalid boardname. Valid boardnames would
> have been:")
> + (newline)
> + (system* "ls" "-1" "configs")
> + #f)
I
