Re: [PATCH] gnu: Add sg3_utils.

2016-08-14 Thread Chris Marusich
Leo Famulari writes: > Generally, we have the problem of using different variables named > 'expat', 'zlib', 'openssl', and possibly others. For those 3, there are > both package and license variables sharing the name. > > So, if we want to refer to both the package and license variables of, > for

Re: [PATCH] gnu: Add sg3_utils.

2016-08-14 Thread Leo Famulari
On Sun, Aug 14, 2016 at 11:49:28AM -0700, Chris Marusich wrote: > Leo Famulari writes: > > >> >> + #:use-module ((guix licenses) > >> >> +#:select (gpl2+ bsd-3)) > >> > > >> > Do we need to use #:select here? How about using a license prefix? What > >> > are the pros and cons? >

Re: [PATCH] gnu: Add sg3_utils.

2016-08-14 Thread Chris Marusich
Leo Famulari writes: >> >> + #:use-module ((guix licenses) >> >> +#:select (gpl2+ bsd-3)) >> > >> > Do we need to use #:select here? How about using a license prefix? What >> > are the pros and cons? > > I'll leave this as is. Oh, sorry, I missed this comment. What is the diffe

Re: [PATCH] gnu: Add sg3_utils.

2016-08-14 Thread Leo Famulari
On Sat, Aug 13, 2016 at 08:23:38PM -0700, Chris Marusich wrote: > sg3_utils and its library can be used with any SCSI device, which > includes many devices which are not hard disks, such as CD-ROMs and > media changers (i.e., jukeboxes), so I don't think it makes sense to put > it into a file whose

Re: [PATCH] gnu: Add sg3_utils.

2016-08-13 Thread Chris Marusich
Leo Famulari writes: > Thanks for this patch! How about putting it in disk.scm? I have no > strong preference either way. I don't like moving things around too much > once they have been created, however :) sg3_utils and its library can be used with any SCSI device, which includes many devices w

Re: [PATCH] gnu: Add sg3_utils.

2016-08-13 Thread Leo Famulari
On Sat, Aug 13, 2016 at 02:52:56AM -0700, Chris Marusich wrote: > Chris Marusich writes: > Subject: [PATCH] gnu: Add sg3_utils. > > * gnu/local.mk: Include gnu/packages/scsi.scm. > * gnu/packages/scsi.scm: Add new file. > * gnu/packages/scsi.scm (sg3_utils): New variable. Thanks for this patch!

Re: [PATCH] gnu: Add sg3_utils.

2016-08-13 Thread Leo Famulari
On Sat, Aug 13, 2016 at 02:42:34AM -0700, Chris Marusich wrote: > Hi, > > This patch adds sg3_utils (and libsgutils). > > When I ran 'guix size sg3_utils', I noticed the following output, which > seemed large to me. Is it normal? > > --8<---cut here---start->

Re: [PATCH] gnu: Add sg3_utils.

2016-08-13 Thread Chris Marusich
Chris Marusich writes: > Subject: [PATCH] gnu: Add sg3_utils. > > * gnu/local.mk: Include gnu/packages/education.scm. > * gnu/packages/scsi.scm: Add new file. > * gnu/packages/scsi.scm (sg3_utils): New variable. This commit message contains an error. I copied it from an earlier commit message,