Re: [PATCH] gnu: Add re2.

2016-09-13 Thread Alex Kost
Marius Bakke (2016-09-12 15:09 +0100) wrote: > Alex Kost writes: > >> Marius Bakke (2016-08-17 16:18 +0100) wrote: >> >>> ..and here is a patch that moves tre.scm over as well. The code is >>> unchanged apart from license: prefix. >>> >>> From 8e673ebd8c68c3a92fa60b56068339c011607752 Mon Sep 17 0

Re: [PATCH] gnu: Add re2.

2016-09-12 Thread Marius Bakke
Alex Kost writes: > Marius Bakke (2016-08-17 16:18 +0100) wrote: > >> ..and here is a patch that moves tre.scm over as well. The code is >> unchanged apart from license: prefix. >> >> From 8e673ebd8c68c3a92fa60b56068339c011607752 Mon Sep 17 00:00:00 2001 >> From: Marius Bakke >> Date: Wed, 17 Au

Re: [PATCH] gnu: Add re2.

2016-09-12 Thread Alex Kost
Marius Bakke (2016-08-17 16:18 +0100) wrote: > ..and here is a patch that moves tre.scm over as well. The code is > unchanged apart from license: prefix. > > From 8e673ebd8c68c3a92fa60b56068339c011607752 Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Wed, 17 Aug 2016 16:10:15 +0100 > Subje

Re: [PATCH] gnu: Add re2.

2016-08-19 Thread Leo Famulari
On Fri, Aug 19, 2016 at 10:35:14AM +0300, Alex Kost wrote: > I agree that having both 'tre' and 're2' packages in "regex.scm" is the > right thing. Also I think it would be good to move 'oniguruma' there. > > As for "pcre.scm", I would also move its content to "regex.scm". What > about 'ghc-pcre

Re: [PATCH] gnu: Add re2.

2016-08-19 Thread Marius Bakke
Leo Famulari writes: > When moving packages around, all users of the package need to have their > module imports updated. Copyright attribution must be carefully handled. > And merging the various *-updates branches into master and vice versa > becomes more complicated and prone to error. Perhap

Re: [PATCH] gnu: Add re2.

2016-08-19 Thread Marius Bakke
Leo Famulari writes: > On Wed, Aug 17, 2016 at 04:18:48PM +0100, Marius Bakke wrote: >> Marius Bakke writes: >> >> > Leo Famulari writes: >> > >> >> On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: >> >>> >> >>> I wasn't sure where to put this, so went with its own file. It does

Re: [PATCH] gnu: Add re2.

2016-08-19 Thread Alex Kost
Leo Famulari (2016-08-18 23:43 +0300) wrote: > On Wed, Aug 17, 2016 at 04:18:48PM +0100, Marius Bakke wrote: >> Marius Bakke writes: >> >> > Leo Famulari writes: >> > >> >> On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: >> >>> >> >>> I wasn't sure where to put this, so went with

Re: [PATCH] gnu: Add re2.

2016-08-18 Thread Leo Famulari
On Wed, Aug 17, 2016 at 04:18:48PM +0100, Marius Bakke wrote: > Marius Bakke writes: > > > Leo Famulari writes: > > > >> On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: > >>> > >>> I wasn't sure where to put this, so went with its own file. It does not > >>> fully implement PCRE s

Re: [PATCH] gnu: Add re2.

2016-08-18 Thread Leo Famulari
On Wed, Aug 17, 2016 at 11:34:14AM +0100, Marius Bakke wrote: > Leo Famulari writes: > > > On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: > >> > >> I wasn't sure where to put this, so went with its own file. It does not > >> fully implement PCRE so pcre.scm seems inappropriate. Pe

Re: [PATCH] gnu: Add re2.

2016-08-17 Thread Marius Bakke
Marius Bakke writes: > Leo Famulari writes: > >> On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: >>> >>> I wasn't sure where to put this, so went with its own file. It does not >>> fully implement PCRE so pcre.scm seems inappropriate. Perhaps that could >>> be renamed to regex.scm

Re: [PATCH] gnu: Add re2.

2016-08-17 Thread Marius Bakke
Leo Famulari writes: > On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: >> >> I wasn't sure where to put this, so went with its own file. It does not >> fully implement PCRE so pcre.scm seems inappropriate. Perhaps that could >> be renamed to regex.scm or similar. > > The patch look

Re: [PATCH] gnu: Add re2.

2016-08-16 Thread Leo Famulari
On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: > > I wasn't sure where to put this, so went with its own file. It does not > fully implement PCRE so pcre.scm seems inappropriate. Perhaps that could > be renamed to regex.scm or similar. The patch looks good, but please put it in reg