Re: [PATCH] gnu: Add cool-retro-term.

2017-05-08 Thread Efraim Flashner
On Thu, May 04, 2017 at 10:03:24PM -0500, Eric Bavier wrote: > Hello Petter, > ... > > I had to add $out/qml to the wrapper QML2_IMPORT_PATH in order for crt > to start up. I figured that was alright, since that path was present > in your initial patch. > ... > > Thanks again, > `~Eric > I lo

Re: [PATCH] gnu: Add cool-retro-term.

2017-05-05 Thread Petter
Hi Eric, On Thu, 4 May 2017 22:03:24 -0500 Eric Bavier wrote: > Hello Petter, > > Pushed as f9ff014bf623071b9343265e8a5aa994a10ec9d4 ! Cool! :) > I ended up whitelisting a few more of the fonts, after verifying their > licenses, and made some more specific notes on the license of each > font.

Re: [PATCH] gnu: Add cool-retro-term.

2017-05-04 Thread Eric Bavier
Hello Petter, Pushed as f9ff014bf623071b9343265e8a5aa994a10ec9d4 ! I ended up whitelisting a few more of the fonts, after verifying their licenses, and made some more specific notes on the license of each font. I had to add $out/qml to the wrapper QML2_IMPORT_PATH in order for crt to start up.

Re: [PATCH] gnu: Add cool-retro-term.

2017-05-03 Thread Petter
On Tue, 2 May 2017 08:51:06 -0500 Eric Bavier wrote: > Hi Petter, > > Thanks again for your patience with this review. Hi Eric, I'm in no rush :) > "gpl2" in the license field should be "gpl2+" according to > qmltermwidget license headers. Could you also include a comment noting > the compon

Re: [PATCH] gnu: Add cool-retro-term.

2017-05-03 Thread Petter
On Sun, 30 Apr 2017 13:59:29 -0700 Chris Marusich wrote: > Petter writes: > > > What do we do about the fonts without licensing info? > > Unfortunately, "no license" is not a free license: Yeah, I kinda figured that one just after I sent the e-mail :) > > https://www.gnu.org/licenses/lice

Re: [PATCH] gnu: Add cool-retro-term.

2017-05-02 Thread Eric Bavier
Hi Petter, Thanks again for your patience with this review. On Fri, 28 Apr 2017 14:10:37 +0200 Petter wrote: > On Thu, 27 Apr 2017 20:47:54 -0500 > Eric Bavier wrote: > > > > > > +(inputs > > > > > + `(("qt" ,qt))) > > > > > > > > Does this package need all of qt, or could we

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-30 Thread Chris Marusich
Petter writes: > What do we do about the fonts without licensing info? Unfortunately, "no license" is not a free license: https://www.gnu.org/licenses/license-list.en.html#NoLicense "If source code does not carry a license to give users the four essential freedoms, then unless it has been expl

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-30 Thread Chris Marusich
Hi Petter, Sorry for the slow reply. Petter writes: > What do you think of adding `crt` as an alternative name > for the binary? I see it's been briefly discussed here, > https://github.com/Swordfish90/cool-retro-term/issues/258 I think that'd be fine. I don't know of any other common program

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-28 Thread Petter
On Thu, 27 Apr 2017 20:47:54 -0500 Eric Bavier wrote: > > > > +(inputs > > > > + `(("qt" ,qt))) > > > > > > Does this package need all of qt, or could we use the component > > > packages instead? > > > > I don't know. I'll do some experiments and see. > > OK, great. Fixed!

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-27 Thread Eric Bavier
On Wed, 26 Apr 2017 20:09:33 +0200 Petter wrote: > On Tue, 25 Apr 2017 22:36:27 -0500 > Eric Bavier wrote: > > > Could you ping the developer about porting some of these fixes to their > > fork? I think we'd want to create a local patch for at least the first > > commit. The others could wait

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-26 Thread Petter
On Tue, 25 Apr 2017 22:36:27 -0500 Eric Bavier wrote: > Could you ping the developer about porting some of these fixes to their > fork? I think we'd want to create a local patch for at least the first > commit. The others could wait for a new release. Sure, I'll do that! > > +(inputs > >

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-25 Thread Eric Bavier
Petter, Thanks for the patch! And Chris, thanks for the review. A few notes from my look through: On Mon, 24 Apr 2017 14:30:26 +0200 Petter wrote: > > * gnu/packages/terminals.scm (cool-retro-term): New variable. > --- > gnu/packages/terminals.scm | 62 >

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-24 Thread Petter
Hi Chris, > > By the way, the output of 'guix lint' points out the following: Oh lint, I had forgotten about that. > --8<---cut here---start->8--- > [0] marusich@garuda:~/guix > $ ./pre-inst-env guix lint cool-retro-term > gnu/packages/terminals.scm:493:5: co

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-23 Thread Chris Marusich
Hi Petter, > +(synopsis "Terminal emulator which mimics the look and feel of the > old +cathode ray tube screens") > +(description > + "Cool-retro-term (CRT) is a terminal emulator which mimics the > look and +feel of the old cathode ray tube (CRT) screens. It has been > designed to be

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-23 Thread Petter
On Sun, 23 Apr 2017 12:18:05 -0700 Chris Marusich wrote: > Petter writes: > > > Hi Guix, > > > > The past is finally here! Had a go at packaging a terminal emulator > > which mimics old cathode displays :) > > Wow!! This is really fun. Thanks for packaging it! :) > > + (modify-phas

Re: [PATCH] gnu: Add cool-retro-term.

2017-04-23 Thread Chris Marusich
Petter writes: > Hi Guix, > > The past is finally here! Had a go at packaging a terminal emulator > which mimics old cathode displays :) Wow!! This is really fun. Thanks for packaging it! > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (