Re: [PATCH] gnu: Add clojure.

On Tue, Aug 16, 2016 at 08:45:17PM +0200, Ricardo Wurmus wrote: > > Alex Vong writes: > > > Thanks for the review too. The changes looks good to me, excepts that it > > seems 'find-files' will find all files with name matching the regex > > recursively, but `scandir' will only list the files on

Re: [PATCH] gnu: Add clojure.

Alex Vong writes: > Thanks for the review too. The changes looks good to me, excepts that it > seems 'find-files' will find all files with name matching the regex > recursively, but `scandir' will only list the files on the 1st > level. Ah, I didn’t notice that this is what you were trying to d

Re: [PATCH] gnu: Add clojure.

Hi Ricardo, Thanks for the review too. The changes looks good to me, excepts that it seems 'find-files' will find all files with name matching the regex recursively, but `scandir' will only list the files on the 1st level. Should we change 'find-files so that it supports the concept of depth as we

Re: [PATCH] gnu: Add clojure.

Thanks for the patch. I went through it and tried to simplify it where possible. - removed unused module imports - merged some procedures - wrote an abstraction for submodules - changed comment style where necessary All proposed changes relative to your patch can be seen here: diff --git a/gnu

Re: [PATCH] gnu: Add clojure.

Hi Ricardo, Ricardo Wurmus writes: > Hi Alex, > >> Thanks for the review again, the package definition is now simplier. > > You only attached the patch to the Clojure sources. Could you please > also attach the latest patch to add the clojure package? > Ahhh, I think I formatted the wrong patch

Re: [PATCH] gnu: Add clojure.

Hi Alex, > Thanks for the review again, the package definition is now simplier. You only attached the patch to the Clojure sources. Could you please also attach the latest patch to add the clojure package? > Yes, the ASM library is included as source (not jar) and is one majar > version behind

Re: [PATCH] gnu: Add clojure.

Hi Ricardo, Thanks for the review again, the package definition is now simplier. Ricardo Wurmus writes: > Hi Alex, > > Usually, we will split bundled libraries. For bundled “jar” archives > this is necessary in any case as a “jar” file is a binary. > > If the libraries are bundled in source fo

Re: [PATCH] gnu: Add clojure.

Hi Alex, > I see. So the general policy here is to be lazy and packaged by need :) > This time only version 1.8 is added. Does this apply to splitting > bundled libraries as well? I see clojure has some java libraries bundled > such as ASM. Currently, I suppose no other packages depend on it. Us

Re: [PATCH] gnu: Add clojure.

Ricardo Wurmus writes: > Hi Alex, > >> This patch adds clojure 1.6 to 1.8. > > Wow. Thanks! > Thanks for the review too! > Usually, we just keep the latest version unless there are packages that > dependend on an older version. In the case of the IcedTea packages, for > example, we need versio

Re: [PATCH] gnu: Add clojure.

Hi Alex, > This patch adds clojure 1.6 to 1.8. Wow. Thanks! > Changes made since last email (comments appreciated): > > Include clojure from 1.6 to 1.8 instead of just 1.8 because I think we > should provide all stable versions and allowed them to be > co-installed. From https://clojure.github

Re: [PATCH] gnu: Add clojure.

Alex Vong writes: > Federico Beffa writes: > >> Alex Vong writes: >> >>> + #:phases >>> + (modify-phases %standard-phases >>> + (delete 'configure) >>> + (replace 'unpack >>> + (lambda _ >>> + (and (mkdir "clojure/") >>> + (zer

Re: [PATCH] gnu: Add clojure.

Alex Vong writes: > + (every (lambda (src) > +(begin (unpack src) > + (copy src))) > + '("data-generators-src" "java-classpath-src" > +"test-check-src" "test-generative-src" > +

Re: [PATCH] gnu: Add clojure.

Federico Beffa writes: > Alex Vong writes: > >> + #:phases >> + (modify-phases %standard-phases >> + (delete 'configure) >> + (replace 'unpack >> + (lambda _ >> + (and (mkdir "clojure/") >> + (zero? (system* "unzip" >> +

Re: [PATCH] gnu: Add clojure.

Ricardo Wurmus writes: > Alex Vong writes: > >> Hi everyone, >> >> This patch adds clojure to guix. I have been interested in clojure's >> syntax for vector [] and hash-map {} for a while, after watching the >> introduction of clojure to lisper video. So, I decide to package it for >> guix! Note

Re: [PATCH] gnu: Add clojure.

Alex Vong writes: > Hi everyone, > > This patch adds clojure to guix. I have been interested in clojure's > syntax for vector [] and hash-map {} for a while, after watching the > introduction of clojure to lisper video. So, I decide to package it for > guix! Note that I follow the example in ldc