Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-13 Thread Ludovic Courtès
Troy Sankey skribis: > Quoting ng0 (2016-07-11 12:35:49) >> The patch below reads okay to me, could you add your name or >> nickname in the section of guix.texi where document author names >> are included, if applicable (ie if your name is missing before >> this edit)? > > Attached patch includes

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-11 Thread Troy Sankey
Quoting ng0 (2016-07-11 12:35:49) > The patch below reads okay to me, could you add your name or > nickname in the section of guix.texi where document author names > are included, if applicable (ie if your name is missing before > this edit)? Attached patch includes my name. Troy From 6381b62a377

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-11 Thread ng0
Hi, Troy Sankey writes: > Quoting Leo Famulari (2016-07-10 19:16:30) >> On Sun, Jul 10, 2016 at 05:54:38PM -0400, Troy Sankey wrote: >> > When hashing git checkouts of packages, packagers must first remove the >> > .git >> > directory. This commit adds this clarification to the "Invoking guix h

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-11 Thread Leo Famulari
On Mon, Jul 11, 2016 at 01:33:40AM -0400, Troy Sankey wrote: > Hashing sources is becoming quite compilated! I can't wait until 'guix > download' supports git, then this could be automated. In that case, `guix download` would need to take a Git hash as an argument. In general, I think it's a goo

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-11 Thread Pjotr Prins
Yes, that is how I understand it previously did not work for me. Thanks :) On Mon, Jul 11, 2016 at 01:33:40AM -0400, Troy Sankey wrote: > Quoting Pjotr Prins (2016-07-10 20:13:26) > > And only now I am understanding a problem ages ago. Would this also be > > the reason for git sub-modules not to w

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Troy Sankey
Quoting Pjotr Prins (2016-07-10 20:13:26) > And only now I am understanding a problem ages ago. Would this also be > the reason for git sub-modules not to work? Pjotr, If I'm understanding correctly, you failed to generate the hash of a git repository containing submodules? In that case, you may

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Troy Sankey
Quoting Leo Famulari (2016-07-10 19:16:30) > On Sun, Jul 10, 2016 at 05:54:38PM -0400, Troy Sankey wrote: > > When hashing git checkouts of packages, packagers must first remove the .git > > directory. This commit adds this clarification to the "Invoking guix hash" > > page in the documentation. >

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Pjotr Prins
On Sun, Jul 10, 2016 at 07:16:30PM -0400, Leo Famulari wrote: > On Sun, Jul 10, 2016 at 05:54:38PM -0400, Troy Sankey wrote: > > When hashing git checkouts of packages, packagers must first remove the .git > > directory. This commit adds this clarification to the "Invoking guix hash" > > page in t

Re: [PATCH] doc: clarification for hashing git checkouts

2016-07-10 Thread Leo Famulari
On Sun, Jul 10, 2016 at 05:54:38PM -0400, Troy Sankey wrote: > When hashing git checkouts of packages, packagers must first remove the .git > directory. This commit adds this clarification to the "Invoking guix hash" > page in the documentation. Yes! This is one that *everybody* has to ask. I th