Re: [PATCH] Add Blast+.

2015-06-29 Thread Ricardo Wurmus
Mark H Weaver writes: >> + (snippet >> + '(begin >> + ;; Remove bundled bzip2 and zlib >> + (delete-file-recursively "c++/src/util/compress/bzip2") >> + (delete-file-recursively "c++/src/util/compress/zlib") >> +

Re: [PATCH] Add Blast+.

2015-06-27 Thread Mark H Weaver
Ricardo Wurmus writes: >> It would be great to get the tests working, even if we have to disable >> some of them. Otherwise we have no way of knowing that we're not >> distributing broken garbage :) > > It's hard to know in this case even with the tests, because it's only > three tests and they

Re: [PATCH] Add Blast+.

2015-06-27 Thread Ricardo Wurmus
Ben Woodcroft writes: > 2.2.31+ just got released, maybe upgrade first? Ah, good to know. I’ll build the latest version on Monday and push that if there are no further objections. ~~ Ricardo

Re: [PATCH] Add Blast+.

2015-06-27 Thread Ben Woodcroft
On 27/06/15 20:14, Ludovic Courtès wrote: Ricardo Wurmus skribis: From 8d131f66ba0378738e5b837f78c411edb241d35a Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Tue, 16 Jun 2015 16:24:24 +0200 Subject: [PATCH] gnu: Add Blast+. * gnu/packages/bioinformatics.scm (blast+): New variable.

Re: [PATCH] Add Blast+.

2015-06-27 Thread Ludovic Courtès
Ricardo Wurmus skribis: > From 8d131f66ba0378738e5b837f78c411edb241d35a Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 16 Jun 2015 16:24:24 +0200 > Subject: [PATCH] gnu: Add Blast+. > > * gnu/packages/bioinformatics.scm (blast+): New variable. Mark, do you have anything to add on

Re: [PATCH] Add Blast+.

2015-06-23 Thread Ricardo Wurmus
Hi Mark, thank you for the review! >> + `(;; There are three(!) tests for this massive library, and all fail >> with >> + ;; "unparsable timing stats". >> + ;; ERR [127] -- [util/regexp] test_pcre.sh (unparsable timing >> stats) >> + ;; ERR [127] -- [serial/datatool]

Re: [PATCH] Add Blast+.

2015-06-16 Thread Mark H Weaver
Ricardo Wurmus writes: > From 81cbb9bfa523d56c68d5f9f4feed3676edb5a414 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 16 Jun 2015 16:24:24 +0200 > Subject: [PATCH] gnu: Add Blast+. > > * gnu/packages/bioinformatics.scm (blast+): New variable. > --- > gnu/packages/bioinformatics.sc