Re: RFC: Build system hacks for Guix do not belong in 'source'

2015-03-12 Thread Mark H Weaver
Ricardo Wurmus writes: > Mark H Weaver writes: > >> I think that both the 'ldconfig -> true' hack and the LIBDIR >> substitution should be moved to a build phase for both of these >> packages. > > Attached are updated patches, moving the build hacks from snippets to a > build phase. > > ~~ Ricard

Re: RFC: Build system hacks for Guix do not belong in 'source'

2015-03-10 Thread Ricardo Wurmus
Mark H Weaver writes: > I think that both the 'ldconfig -> true' hack and the LIBDIR > substitution should be moved to a build phase for both of these > packages. Attached are updated patches, moving the build hacks from snippets to a build phase. ~~ Ricardo >From abdbfec11164c61cfdb6fc88ddf9a

Re: RFC: Build system hacks for Guix do not belong in 'source'

2015-03-05 Thread Ricardo Wurmus
Ludovic Courtès writes: > Mark H Weaver skribis: > >> I don't think we should be making these kinds of changes in 'snippets'. >> >> When I ask for the source code via "guix build -S ", I expect >> freedom fixes and other bug fixes, and maybe even enhancements needed >> for Guix that would also w

Re: RFC: Build system hacks for Guix do not belong in 'source'

2015-03-05 Thread Ludovic Courtès
Mark H Weaver skribis: > I don't think we should be making these kinds of changes in 'snippets'. > > When I ask for the source code via "guix build -S ", I expect > freedom fixes and other bug fixes, and maybe even enhancements needed > for Guix that would also work fine on other systems (e.g. ad

Re: RFC: Build system hacks for Guix do not belong in 'source'

2015-03-05 Thread Thompson, David
On Thu, Mar 5, 2015 at 1:38 PM, Mark H Weaver wrote: > I don't think we should be making these kinds of changes in 'snippets'. > > When I ask for the source code via "guix build -S ", I expect > freedom fixes and other bug fixes, and maybe even enhancements needed > for Guix that would also work

RFC: Build system hacks for Guix do not belong in 'source'

2015-03-05 Thread Mark H Weaver
Hi Ricardo, Thanks for investigating. Please see below for comments. Ricardo Wurmus writes: > From f5e35f488fd1b4f5d916476d7c522783809b0f82 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Wed, 4 Mar 2015 11:50:26 +0100 > Subject: [PATCH 1/2] gnu: zita-alsa-pcmi: set LIBDIR to "lib". >