Re: Patch xdg-open in emacs-embark package

2023-05-21 Thread Mekeor Melire
2023-05-10 17:40 jg...@dismail.de: I think it would be great to not worry about installing xdg-open if you install emacs-embark and it depends on it. I'm not sure about this since embark.el does a lot more than invoking xdg-open and also, it can be used without xdg-open, while still being us

Re: Patch xdg-open in emacs-embark package

2023-05-10 Thread jgart
BTW, I discovered this because when I tried calling that function in eshell (with eat-eshell-mode enabled, btw lol) it complained that xdg-open was not install. ;() Just a little story about the discovery. I think it would be great to not worry about installing xdg-open if you install emacs-e

Re: Patch xdg-open in emacs-embark package

2023-05-10 Thread jgart
Hi, Yes, definitely please do open a PR upstream for that. Sounds good to me. Keep us posted here on the thread on that status of that. all best, jgart May 10, 2023 6:29 AM, "Mekeor Melire" wrote: > 2023-05-10 02:11 jg...@dismail.de: > >> Just writing down a public TODO for myself: >> >>

Re: Patch xdg-open in emacs-embark package

2023-05-10 Thread Mekeor Melire
2023-05-10 02:11 jg...@dismail.de: Just writing down a public TODO for myself: TODO: patch xdg-open (xdg-utils) in emacs-embark package. https://github.com/oantolin/embark/blob/f88314044d5492efeacb9466122889c6e60c8af4/embark.el#L3710 If anyone else wants to work on this feel free to. We cou

Patch xdg-open in emacs-embark package

2023-05-09 Thread jgart
Just writing down a public TODO for myself: TODO: patch xdg-open (xdg-utils) in emacs-embark package. https://github.com/oantolin/embark/blob/f88314044d5492efeacb9466122889c6e60c8af4/embark.el#L3710 If anyone else wants to work on this feel free to.