Re: Dependency cycle issues when using a Gexp-based snippet

2020-09-16 Thread Ludovic Courtès
Hi, Maxim Cournoyer skribis: >>> What is the difference between delayed and thunked? Would a thunked >>> capture the closure of its environment while delayed not? Is the >>> closure useful to access record-bound values such as the version field >>> of a package? >> >> ‘Thunk’ uses an actual thu

Re: Dependency cycle issues when using a Gexp-based snippet

2020-09-16 Thread Ludovic Courtès
Hi Mark, Mark H Weaver skribis: > Ludovic Courtès writes: > >> Indeed: the problem is that when loading this module, we try to resolve >> one of the variables referenced in the snippet, but that variable is not >> defined yet because it comes from a module that’s in a dependency circle >> with

Re: Dependency cycle issues when using a Gexp-based snippet

2020-09-14 Thread Maxim Cournoyer
Hello Ludovic, [...] >> What is the difference between delayed and thunked? Would a thunked >> capture the closure of its environment while delayed not? Is the >> closure useful to access record-bound values such as the version field >> of a package? > > ‘Thunk’ uses an actual thunk (zero-argume

Re: What should "guix build --source" produce? (was Re: Dependency cycle issues when using a Gexp-based snippet)

2020-09-11 Thread Andreas Enge
Hello Maxim, On Fri, Sep 11, 2020 at 02:22:44PM -0400, Maxim Cournoyer wrote: > +@cindex snippets, when to use > +The boundary between using an origin snippet versus a build phase to > +modify the sources of a package can be elusive. Origin snippets are > +typically used to remove unnecessary fil

Re: What should "guix build --source" produce? (was Re: Dependency cycle issues when using a Gexp-based snippet)

2020-09-11 Thread zimoun
Hi, On Fri, 11 Sep 2020 at 20:22, Maxim Cournoyer wrote: > Yes, this sounds like it! How about the following section, to help > contributors decide between the two? > > --8<---cut here---start->8--- > 1 file changed, 14 insertions(+) > doc/contributing.texi |

Re: What should "guix build --source" produce? (was Re: Dependency cycle issues when using a Gexp-based snippet)

2020-09-11 Thread Maxim Cournoyer
Hi Mark, Mark H Weaver writes: > Hi Maxim, > > maxim.courno...@gmail.com writes: > >> While trying to move some of the patching done to qtbase into a snippet, >> with the goal of having at least the ./configure script runnable in a >> guix environment without having to manually run patching phas

Re: What should "guix build --source" produce? (was Re: Dependency cycle issues when using a Gexp-based snippet)

2020-09-11 Thread Maxim Cournoyer
Andreas Enge writes: > Hello Mark, > > On Tue, Sep 08, 2020 at 12:07:01AM -0400, Mark H Weaver wrote: >> > + (let ((coreutils #+(canonical-package coreutils))) >> > + (substitute* "configure" >> > + (("/bin/pwd") >> > +

Re: What should "guix build --source" produce? (was Re: Dependency cycle issues when using a Gexp-based snippet)

2020-09-08 Thread Andreas Enge
Hello Mark, On Tue, Sep 08, 2020 at 12:07:01AM -0400, Mark H Weaver wrote: > > + (let ((coreutils #+(canonical-package coreutils))) > > + (substitute* "configure" > > + (("/bin/pwd") > > + (string-append cor

What should "guix build --source" produce? (was Re: Dependency cycle issues when using a Gexp-based snippet)

2020-09-07 Thread Mark H Weaver
Hi Maxim, maxim.courno...@gmail.com writes: > While trying to move some of the patching done to qtbase into a snippet, > with the goal of having at least the ./configure script runnable in a > guix environment without having to manually run patching phases: [...] > + (snippet > +

Re: Dependency cycle issues when using a Gexp-based snippet

2020-09-07 Thread Mark H Weaver
Hi Ludovic, Ludovic Courtès writes: > Indeed: the problem is that when loading this module, we try to resolve > one of the variables referenced in the snippet, but that variable is not > defined yet because it comes from a module that’s in a dependency circle > with the one at hand. [...] > As M

Re: Dependency cycle issues when using a Gexp-based snippet

2020-09-07 Thread Ludovic Courtès
Hi Maxim, Maxim Cournoyer skribis: >>> Attempting a suggested fix by Ludovic in that same conversation [0], >>> namely, making the snippet field of the record a thunked one: >>> >>> modified guix/packages.scm >>> @@ -250,7 +250,8 @@ as base32. Otherwise, it must be a bytevector." >>>(pat

Re: Dependency cycle issues when using a Gexp-based snippet

2020-09-02 Thread Maxim Cournoyer
Hi Ludovic! Thank you for the reply. Ludovic Courtès writes: > Hello! > > maxim.courno...@gmail.com skribis: > >> While trying to move some of the patching done to qtbase into a snippet, >> with the goal of having at least the ./configure script runnable in a >> guix environment without having

Re: Dependency cycle issues when using a Gexp-based snippet

2020-08-24 Thread Ludovic Courtès
Hello! maxim.courno...@gmail.com skribis: > While trying to move some of the patching done to qtbase into a snippet, > with the goal of having at least the ./configure script runnable in a > guix environment without having to manually run patching phases: [...] > I encountered the following iss

Dependency cycle issues when using a Gexp-based snippet

2020-08-23 Thread maxim . cournoyer
Hello, While trying to move some of the patching done to qtbase into a snippet, with the goal of having at least the ./configure script runnable in a guix environment without having to manually run patching phases: --8<---cut here---start->8--- modified gnu/p