Re: 02/09: guix: store: Make register-items transactional, register drv outputs

2019-04-06 Thread Caleb Ristvedt
> I finally got around to fixing it in > a31174e896047e6a0f42b69db331fdeebb3cc995. > > The kludge is no longer needed! Great. Here are updated patches: >From 287879a825f41c46cc5091c715467e476d465def Mon Sep 17 00:00:00 2001 From: Caleb Ristvedt Date: Mon, 1 Apr 2019 15:04:59 -0500 Subject: [PATC

Re: 02/09: guix: store: Make register-items transactional, register drv outputs

2019-04-04 Thread Ludovic Courtès
Caleb Ristvedt skribis: > As we found out on IRC yesterday, https://bugs.gnu.org/15602 is causing > this to fail. If I understand correctly, the workaround involves trying > to make sure that modules that use (guix memoization) are compiled > before (guix memoization) is (and it turns out that on

Re: 02/09: guix: store: Make register-items transactional, register drv outputs

2019-04-01 Thread Ludovic Courtès
Hello, Caleb Ristvedt skribis: >> A problem is that we should not pull in these two modules here, because >> they are conceptually at a higher level (they have to do with talking to >> a separate daemon process.) >> >> So perhaps a first step would be to re-arrange things, probably along >> thes

Re: 02/09: guix: store: Make register-items transactional, register drv outputs

2019-04-01 Thread Caleb Ristvedt
> A problem is that we should not pull in these two modules here, because > they are conceptually at a higher level (they have to do with talking to > a separate daemon process.) > > So perhaps a first step would be to re-arrange things, probably along > these lines: > > • Move the .drv parsing c

Re: 02/09: guix: store: Make register-items transactional, register drv outputs

2019-03-06 Thread Ludovic Courtès
Hi reepca! Caleb Ristvedt skribis: > Changes made, though I'm not quite sure about this part: > >> Could you add a test in tests/store-database.scm for this bit? >> >>> +(when (derivation-path? real-file-name) >>> + (register-derivation-outputs)) > > Should that be a separate te

Re: 02/09: guix: store: Make register-items transactional, register drv outputs

2019-02-13 Thread Caleb Ristvedt
Changes made, though I'm not quite sure about this part: > Could you add a test in tests/store-database.scm for this bit? > >> +(when (derivation-path? real-file-name) >> + (register-derivation-outputs)) Should that be a separate test or an extension of "register-path"? Currentl

Re: 02/09: guix: store: Make register-items transactional, register drv outputs

2019-02-09 Thread Ludovic Courtès
Hi reepca, guix-comm...@gnu.org skribis: > commit 91cbfa8da90d8d1723da753c171a378dae13cb40 > Author: Caleb Ristvedt > Date: Wed Jan 30 17:03:38 2019 -0600 > > guix: store: Make register-items transactional, register drv outputs > > * guix/store/database.scm (SQLITE_BUSY, register-