Re: [RFC]: Skipping rust crate tests by default

2023-10-23 Thread Maxim Cournoyer
Hi Efraim! Efraim Flashner writes: [...] >> > error: unnecessary parentheses around index expression >> > --> >> > /tmp/guix-build-rust-nalgebra-0.21.1.drv-0/nalgebra-0.21.1/src/linalg/convolution.rs:49:53 >> >| >> > 49 | conv[i] += self[u] * kernel[(i - u)]; >> >

Re: [RFC]: Skipping rust crate tests by default

2023-10-23 Thread Efraim Flashner
On Wed, Oct 18, 2023 at 02:46:57PM -0400, Maxim Cournoyer wrote: > Hi Efraim, > > Efraim Flashner writes: > > [...] > > >> This sounds good except I don't understand how disabling the tests by > >> default help to "make sure that the packages have the correct inputs" ? > > > > When the tests ar

Re: [RFC]: Skipping rust crate tests by default

2023-10-18 Thread Maxim Cournoyer
Hi Efraim, Efraim Flashner writes: [...] >> This sounds good except I don't understand how disabling the tests by >> default help to "make sure that the packages have the correct inputs" ? > > When the tests are disabled, if a package shows red on the CI it means > that either: > A) there was a

Re: [RFC]: Skipping rust crate tests by default

2023-10-18 Thread Efraim Flashner
On Thu, Oct 05, 2023 at 03:52:46PM +0300, Efraim Flashner wrote: > Currently for for rust crates we build the crates, run the tests, and > then in %output we only have the license files and a repackaged version > of the source. > > The build system goes: > unpack source > unpack crates > patch she

Re: [RFC]: Skipping rust crate tests by default

2023-10-17 Thread Efraim Flashner
On Mon, Oct 16, 2023 at 11:47:53AM -0400, Maxim Cournoyer wrote: > Hi Efraim, > > Efraim Flashner writes: > > > Currently for for rust crates we build the crates, run the tests, and > > then in %output we only have the license files and a repackaged version > > of the source. > > > > The build s

Re: [RFC]: Skipping rust crate tests by default

2023-10-16 Thread Maxim Cournoyer
Hi Efraim, Efraim Flashner writes: > Currently for for rust crates we build the crates, run the tests, and > then in %output we only have the license files and a repackaged version > of the source. > > The build system goes: > unpack source > unpack crates > patch shebangs > patch checksums of t

Re: [RFC]: Skipping rust crate tests by default

2023-10-15 Thread Josselin Poiret
Hi Felix, Felix Lechner via "Development of GNU Guix and the GNU System distribution." writes: > In summary, I believe that #:test? should be turned off for all build > systems. Guix should instead test installed versions like Debian's > autopkgtest. Let me just chime in and say that I agree: t

Re: [RFC]: Skipping rust crate tests by default

2023-10-05 Thread Nathan Dehnel
As a developer, the majority of the package build failures I encounter are from failed tests, so I agree with this proposal. I also like the idea of clients testing their own packages instead of trusting the substitute server. And if the new tests would catch more packaging bugs, that would be gr

Re: [RFC]: Skipping rust crate tests by default

2023-10-05 Thread Development of GNU Guix and the GNU System distribution.
Hi Ephraim, On Thu, Oct 05 2023, Efraim Flashner wrote: > I propose changing the cargo-build-system to have '#:tests? #f' by > default At first sight, it appears improper to turn off tests because they fail. Please allow me to remind everyone that build-time tests cover only a small proportion o

[RFC]: Skipping rust crate tests by default

2023-10-05 Thread Efraim Flashner
Currently for for rust crates we build the crates, run the tests, and then in %output we only have the license files and a repackaged version of the source. The build system goes: unpack source unpack crates patch shebangs patch checksums of the crates 'build 'package 'check 'install 'install is