Re: [Patch] Tmux Themepack

2016-07-11 Thread Alex Kost
Leo Famulari (2016-07-10 19:19 +0300) wrote: > Thanks! I found myself wondering about some of the new module imports, > in particular (guix build utils), (guix utils), and (gnu packages base). > > The latter two are not needed; tmux.scm compiles and tmux and > tmux-themepack can both be built with

Re: [Patch] Tmux Themepack

2016-07-10 Thread Matthew Jordan
Good Day Leo, > Can you test this and let me know if it works for you? Then we can > finally add tmux-themepack :) I removed the modules in question, then built both tmux and tmux-themepack. Both built successfully. Attached is an updated patch. Let me know if you need any other changes. >From

Re: [Patch] Tmux Themepack

2016-07-10 Thread Leo Famulari
On Sun, Jul 10, 2016 at 09:26:50AM -0400, Matthew Jordan wrote: > Hi I tried applying to patch and git gave me an error asking if I hand > edited the patch file. Huh! > So I added the changes to the attached patch. Let me know if I covered > everything. Thanks! I found myself wondering about so

Re: guix revisions (Re: [Patch] Tmux Themepack)

2016-07-10 Thread Leo Famulari
On Sun, Jul 10, 2016 at 02:06:44PM +, ng0 wrote: > A side question: We do guix revisions of packages? I know we had > a discussion on this in the past which included the string-take > commit 7 or 8, but even with using grep in the gnu/packages dir > it's not obvious as egrep -nr 'revision "1"'

Re: [Patch] Tmux Themepack

2016-07-10 Thread Matthew Jordan
Good Day, > Thanks! Can you test the attached revision on your patch? Here are the > changes: Hi I tried applying to patch and git gave me an error asking if I hand edited the patch file. So I added the changes to the attached patch. Let me know if I covered everything. >From f6d471c2292e6b0a7

guix revisions (Re: [Patch] Tmux Themepack)

2016-07-10 Thread ng0
Hi, Leo Famulari writes: > On Sun, Jun 12, 2016 at 04:01:41PM -0400, Matthew Jordan wrote: >> Good Day, >> >> The package has been updated inline with suggested changes. > > Thanks! Can you test the attached revision on your patch? Here are the > changes: > >> +(define-public tmux-themepack >>

Re: [Patch] Tmux Themepack

2016-06-17 Thread Leo Famulari
On Sun, Jun 12, 2016 at 04:01:41PM -0400, Matthew Jordan wrote: > Good Day, > > The package has been updated inline with suggested changes. Thanks! Can you test the attached revision on your patch? Here are the changes: > +(define-public tmux-themepack > + (let ((commit "03a372866f7677f7fe63bce

Re: [Patch] Tmux Themepack

2016-06-12 Thread Matthew Jordan
Good Day, The package has been updated inline with suggested changes. >From 1b8c8fc3d727d32b515fac48bd989599aa2f7932 Mon Sep 17 00:00:00 2001 From: Matthew Jordan Date: Wed, 18 May 2016 18:20:30 -0400 Subject: [PATCH] gnu: Add Tmux themepack * gnu/packages/tmux.scm (tmux-themepack): New variabl

Re: [Patch] Tmux Themepack

2016-06-11 Thread Ricardo Wurmus
Hi Matthew, thank you very much for your patch! Below are some comments. > From 9d400b025a3d60bc29b58ba0bf1301a418ba7aa2 Mon Sep 17 00:00:00 2001 > From: Matthew Jordan > Date: Wed, 18 May 2016 18:20:30 -0400 > Subject: [PATCH] gnu: Add Tmux themepack > * gnu/packages/tmux.scm: (tmux-themepac

[Patch] Tmux Themepack

2016-06-09 Thread Matthew Jordan
Good Day, This patch to add the tmux themepack. >From 9d400b025a3d60bc29b58ba0bf1301a418ba7aa2 Mon Sep 17 00:00:00 2001 From: Matthew Jordan Date: Wed, 18 May 2016 18:20:30 -0400 Subject: [PATCH] gnu: Add Tmux themepack * gnu/packages/tmux.scm: (tmux-themepack): New variable. --- gnu/packages/