Re: [PATCH 8/8] services: Add spice vdagent service.

2016-08-01 Thread Ludovic Courtès
David Craven skribis: >> If spice-vdagend produces a PID file, make sure to use #:pid-file here >> (there are several examples in the tree), which often provides more >> reliable startup notification. > > spice-vdagentd doesn't create a pid file itself. [0] [1] OK. In that case, ‘make-forkexec-

Re: [PATCH 8/8] services: Add spice vdagent service.

2016-07-31 Thread David Craven
> If spice-vdagend produces a PID file, make sure to use #:pid-file here > (there are several examples in the tree), which often provides more > reliable startup notification. spice-vdagentd doesn't create a pid file itself. [0] [1] I haven't updated the documentation yet because I'm running into

Re: [PATCH 8/8] services: Add spice vdagent service.

2016-07-30 Thread Ludovic Courtès
David Craven skribis: >> If spice-vdagend produces a PID file, make sure to use #:pid-file here >> (there are several examples in the tree), which often provides more >> reliable startup notification. > > I'm passing the -x flag which prevents spice-vdagentd from > daemonizing. I thought that mak

Re: [PATCH 8/8] services: Add spice vdagent service.

2016-07-30 Thread David Craven
> If spice-vdagend produces a PID file, make sure to use #:pid-file here > (there are several examples in the tree), which often provides more > reliable startup notification. I'm passing the -x flag which prevents spice-vdagentd from daemonizing. I thought that make-forkexec-constructor took care

Re: [PATCH 8/8] services: Add spice vdagent service.

2016-07-29 Thread David Craven
> Also, I think this should be a separate patch as it seems to be unrelated. It's related to: > (service-extension profile-service-type + (compose list + spice-vdagent-configuration-spice-vdagent)) But ok. I'll do it first thing tomorrow =)

Re: [PATCH 8/8] services: Add spice vdagent service.

2016-07-29 Thread Ludovic Courtès
David Craven skribis: > * gnu/services/spice.scm: New file. > * gnu/packages/spice.scm (spice-vdagent): Set Exec path in > spice-vdagent.desktop. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. [...] > --- a/gnu/packages/spice.scm > +++ b/gnu/packages/spice.scm > @@ -235,6 +235,11 @@ Internet an

[PATCH 8/8] services: Add spice vdagent service.

2016-07-29 Thread David Craven
* gnu/services/spice.scm: New file. * gnu/packages/spice.scm (spice-vdagent): Set Exec path in spice-vdagent.desktop. * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. --- gnu/local.mk | 1 + gnu/packages/spice.scm | 5 + gnu/services/spice.scm | 55 +