Re: [PATCH 4/5] import: pypi: Compute test requirements when reading requirements files.

2016-07-25 Thread Ludovic Courtès
Cyril Roelandt skribis: > On 07/22/2016 11:30 PM, Ludovic Courtès wrote: >> This seems to suggest that this could be factorized somehow. Maybe >> unpack once and read the two files at once? > > The problem is that both files might not be there, and unzip will return > a non-zero exit code if any

Re: [PATCH 4/5] import: pypi: Compute test requirements when reading requirements files.

2016-07-23 Thread Cyril Roelandt
On 07/22/2016 11:30 PM, Ludovic Courtès wrote: > This seems to suggest that this could be factorized somehow. Maybe > unpack once and read the two files at once? The problem is that both files might not be there, and unzip will return a non-zero exit code if any of them is missing, so it seems ea

Re: [PATCH 4/5] import: pypi: Compute test requirements when reading requirements files.

2016-07-22 Thread Ludovic Courtès
Cyril Roelandt skribis: > * guix/import/pypi.scm (guess-requirement-from-source): Read > test-requirements.txt as well as requirements.txt. > * tests/pypi.scm ("pypi->guix-package"): Update accordingly. [...] >(let* ((req-file (string-append dirname "/requirements.txt")) > -

[PATCH 4/5] import: pypi: Compute test requirements when reading requirements files.

2016-07-16 Thread Cyril Roelandt
* guix/import/pypi.scm (guess-requirement-from-source): Read test-requirements.txt as well as requirements.txt. * tests/pypi.scm ("pypi->guix-package"): Update accordingly. --- guix/import/pypi.scm | 20 +++- tests/pypi.scm | 11 +++ 2 files changed, 26 insertions(+),