Tomáš Čech skribis:
> * gnu/packages/enlightenment.scm (emotion-generic-players): New variable.
[...]
> +(inputs
> + `(("efl" ,efl)
Propagate?
> + "Emotion-generic-players is collection of interfaces to outside
> libraries
> +and applications allowing to natively play video files
* gnu/packages/enlightenment.scm (emotion-generic-players): New variable.
---
gnu/packages/enlightenment.scm | 27 +++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 9e471bd..ebfd0d7 100644
--- a/gnu/pack
Tomáš Čech skribis:
> * gnu/packages/efl.scm (emotion-generic-players): New variable.
I agree with Andreas. Other than that LGTM, except for lines too long.
Thanks,
Ludo’.
On Thu, Feb 26, 2015 at 07:09:08PM +0100, Tomáš Čech wrote:
> But it seems that the filename is really important to you all so I'll
> change the name.
Not really, I care a lot about package names and little about file names :-)
It was just a suggestion to think about, whatever you prefer.
Andreas
On Thu, Feb 26, 2015 at 08:47:20PM +0800, 宋文武 wrote:
Tomáš Čech writes:
Hello,
thanks for review.
On Thu, Feb 26, 2015 at 11:23:27AM +0100, Andreas Enge wrote:
Hello,
just a quick comment on the descriptions. It would be good to write full
sentences, for instance:
On Thu, Feb 26, 2015 at
* gnu/packages/efl.scm (emotion-generic-players): New variable.
---
gnu/packages/efl.scm | 22 ++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/efl.scm b/gnu/packages/efl.scm
index 3d5ed74..d69cb5c 100644
--- a/gnu/packages/efl.scm
+++ b/gnu/packages/efl.scm
@@ -4
