Re: [PATCH 4/4] gnu: samba: Update to 4.3.2.

2015-12-21 Thread Ludovic Courtès
iyzs...@member.fsf.org (宋文武) skribis: > l...@gnu.org (Ludovic Courtès) writes: [...] >> Besides, I wonder if we should change it to ‘waf-build-system’. > All things from samba projects (tevent, ldb, etc.) use a custom > configure script to run its own “buildtools/bin/waf”. And > waf-build-syste

Re: [PATCH 4/4] gnu: samba: Update to 4.3.2.

2015-12-17 Thread 宋文武
l...@gnu.org (Ludovic Courtès) writes: > 宋文武 skribis: > >> * gnu/packages/samba.scm (samba): Update to 4.3.2. Add more inputs. >> [arguments]: Use 'modify-phases' syntax. > > Please mention the arguments removed (#:modules and #:imported-modules) > and the phases removed. > > Otherwise LGTM. Don

Re: [PATCH 4/4] gnu: samba: Update to 4.3.2.

2015-12-17 Thread Ludovic Courtès
宋文武 skribis: > * gnu/packages/samba.scm (samba): Update to 4.3.2. Add more inputs. > [arguments]: Use 'modify-phases' syntax. Please mention the arguments removed (#:modules and #:imported-modules) and the phases removed. Otherwise LGTM. One less user of PatchELF, good. :-) Thank you! Ludo

[PATCH 4/4] gnu: samba: Update to 4.3.2.

2015-12-14 Thread 宋文武
* gnu/packages/samba.scm (samba): Update to 4.3.2. Add more inputs. [arguments]: Use 'modify-phases' syntax. --- gnu/packages/samba.scm | 75 +++--- 1 file changed, 34 insertions(+), 41 deletions(-) diff --git a/gnu/packages/samba.scm b/gnu/packages/sa