Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-08-09 Thread Mark H Weaver
Efraim Flashner writes: > The aarch64 machine that I tested this on built packages without any > problems. Looks good to me. Pushed in commit a1aa5dabaa5d570710da7190a3c3dca5442b9daa. Thanks, Mark

Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-08-06 Thread Efraim Flashner
On Sat, Aug 05, 2017 at 05:41:50PM -0400, Mark H Weaver wrote: > I wrote: > > Can you try the following patch on aarch64 and report back? > > Actually, the last patch was not quite right. C/C++ makes it rather > difficult to avoid edge cases in arithmetic. Can you try this one > instead? > >

Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-08-05 Thread Mark H Weaver
I wrote: > Can you try the following patch on aarch64 and report back? Actually, the last patch was not quite right. C/C++ makes it rather difficult to avoid edge cases in arithmetic. Can you try this one instead? Thanks, Mark --8<---cut here---start--

Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-08-05 Thread Mark H Weaver
Hi Efraim, Efraim Flashner writes: > On Sat, Aug 05, 2017 at 02:21:55AM -0400, Mark H Weaver wrote: >> Reviving a very old thread... >> >> l...@gnu.org (Ludovic Courtès) writes: >> >> > diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc >> > index cebc404d1..9b7bb5391 100644 >> > --- a

Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-08-05 Thread Ludovic Courtès
Mark H Weaver skribis: > Reviving a very old thread... > > l...@gnu.org (Ludovic Courtès) writes: > >> Efraim Flashner skribis: >> >>> man2 clone: EINVAL: ... on aarch64, child_stack must be a multiple of 16. >>> >>> * nix/libstore/build.cc (DerivationGoal::startBuilder): When on aarch64, >>> wh

Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-08-05 Thread Efraim Flashner
On Sat, Aug 05, 2017 at 02:21:55AM -0400, Mark H Weaver wrote: > Reviving a very old thread... > > l...@gnu.org (Ludovic Courtès) writes: > > > Efraim Flashner skribis: > > > >> man2 clone: EINVAL: ... on aarch64, child_stack must be a multiple of 16. > >> > >> * nix/libstore/build.cc (Derivatio

Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-08-04 Thread Mark H Weaver
Reviving a very old thread... l...@gnu.org (Ludovic Courtès) writes: > Efraim Flashner skribis: > >> man2 clone: EINVAL: ... on aarch64, child_stack must be a multiple of 16. >> >> * nix/libstore/build.cc (DerivationGoal::startBuilder): When on aarch64, >> when calling clone(), increment the sta

Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-02-14 Thread Efraim Flashner
On Tue, Feb 14, 2017 at 09:47:30AM +0100, Ludovic Courtès wrote: > Efraim Flashner skribis: > > > man2 clone: EINVAL: ... on aarch64, child_stack must be a multiple of 16. > > > > * nix/libstore/build.cc (DerivationGoal::startBuilder): When on aarch64, > > when calling clone(), increment the stac

Re: [PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-02-14 Thread Ludovic Courtès
Efraim Flashner skribis: > man2 clone: EINVAL: ... on aarch64, child_stack must be a multiple of 16. > > * nix/libstore/build.cc (DerivationGoal::startBuilder): When on aarch64, > when calling clone(), increment the stack by 16. > --- > nix/libstore/build.cc | 7 ++- > 1 file changed, 6 inse

[PATCH 3/6] daemon: On aarch64, use increments of 16 on the stack.

2017-02-09 Thread Efraim Flashner
man2 clone: EINVAL: ... on aarch64, child_stack must be a multiple of 16. * nix/libstore/build.cc (DerivationGoal::startBuilder): When on aarch64, when calling clone(), increment the stack by 16. --- nix/libstore/build.cc | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/n