Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-12 Thread Ludovic Courtès
Federico Beffa skribis: > From 14abfc26e7b45aa5644104fa661f34f3a70323ae Mon Sep 17 00:00:00 2001 > From: Federico Beffa > Date: Thu, 18 Dec 2014 21:32:34 +0100 > Subject: [PATCH 3/4] gnu: libcanberra: Add default sounds support. > > * gnu/packages/libcanberra.scm (libcanberra): Add input > 'so

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-11 Thread Federico Beffa
On Sun, Jan 11, 2015 at 2:04 PM, Federico Beffa wrote: > Good idea! Here the updated patch. seeing my own post I noticed that I had tabs instead of spaces in the patch. Here I've corrected that. Fede From 14abfc26e7b45aa5644104fa661f34f3a70323ae Mon Sep 17 00:00:00 2001 From: Federico Beffa Dat

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-11 Thread Federico Beffa
On Sun, Jan 11, 2015 at 11:59 AM, Ludovic Courtès wrote: > I’m a bit concerned about readability. What about doing it this way: > > 1. Make an actual patch for libcanberra, with @SOUND_THEME_DIRECTORY@ > as a placeholder for the sound-theme-freedesktop directory. > > 2. Add this patch to

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-11 Thread Ludovic Courtès
Federico Beffa skribis: > On Sat, Jan 10, 2015 at 10:13 PM, Ludovic Courtès wrote: >>> + (let ((sounds (string-append >>> + (assoc-ref inputs "sound-theme-freedesktop") >>> + "/share"))) >>> +(substitute* "src/sound-theme-spec.

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-11 Thread Federico Beffa
On Sat, Jan 10, 2015 at 10:13 PM, Ludovic Courtès wrote: > Very good! Could you add the story about XDG_DATA_DIRS > vs. XDG_DATA_HOME as a comment above the phase? Will do. > >> + (let ((sounds (string-append >> + (assoc-ref inputs "sound-theme-freedesktop") >>

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-10 Thread Ludovic Courtès
Federico Beffa skribis: > On Thu, Jan 8, 2015 at 9:39 PM, Ludovic Courtès wrote: >> That said, this kind of patch is not very different from the automated >> shebang patching that we do, IMO. > > I do not see it this way because the shebang concept is fully > standardized, while here we are patc

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-10 Thread Federico Beffa
On Thu, Jan 8, 2015 at 9:39 PM, Ludovic Courtès wrote: > That said, this kind of patch is not very different from the automated > shebang patching that we do, IMO. I do not see it this way because the shebang concept is fully standardized, while here we are patching a "random" piece of code. > T

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-08 Thread Ludovic Courtès
Federico Beffa skribis: > On Wed, Jan 7, 2015 at 9:11 PM, Ludovic Courtès wrote: >> (Sorry for the delay.) >> >> Federico Beffa skribis: >> >>> On Sun, Dec 21, 2014 at 12:06 PM, Ludovic Courtès wrote: Federico Beffa skribis: > I propose to make sound-theme-freedesktop a propagat

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-08 Thread Federico Beffa
On Wed, Jan 7, 2015 at 9:11 PM, Ludovic Courtès wrote: > (Sorry for the delay.) > > Federico Beffa skribis: > >> On Sun, Dec 21, 2014 at 12:06 PM, Ludovic Courtès wrote: >>> Federico Beffa skribis: >>> I propose to make sound-theme-freedesktop a propagated input of libcanberra. This i

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-07 Thread Ludovic Courtès
(Sorry for the delay.) Federico Beffa skribis: > On Sun, Dec 21, 2014 at 12:06 PM, Ludovic Courtès wrote: >> Federico Beffa skribis: >> >>> I propose to make sound-theme-freedesktop a propagated input of >>> libcanberra. This is because, according to the XDG sound theme >>> specification, thos

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2015-01-07 Thread Federico Beffa
On Sun, Dec 21, 2014 at 4:33 PM, Federico Beffa wrote: > On Sun, Dec 21, 2014 at 12:06 PM, Ludovic Courtès wrote: >> Federico Beffa skribis: >> >>> I propose to make sound-theme-freedesktop a propagated input of >>> libcanberra. This is because, according to the XDG sound theme >>> specification

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2014-12-21 Thread Federico Beffa
On Sun, Dec 21, 2014 at 12:06 PM, Ludovic Courtès wrote: > Federico Beffa skribis: > >> I propose to make sound-theme-freedesktop a propagated input of >> libcanberra. This is because, according to the XDG sound theme >> specification, those event sounds should always be present and used as >> fa

Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input.

2014-12-21 Thread Ludovic Courtès
Federico Beffa skribis: > I propose to make sound-theme-freedesktop a propagated input of > libcanberra. This is because, according to the XDG sound theme > specification, those event sounds should always be present and used as > fall-back in case other sounds are not present. > > http://www.free

[PATCH 3/4] gnu: libcanberra: Add propagated-input.

2014-12-18 Thread Federico Beffa
/sound-theme-spec/ Regards, Fede From 72daec908a2f790d73e332c680433734125c5eee Mon Sep 17 00:00:00 2001 From: Federico Beffa Date: Thu, 18 Dec 2014 21:32:34 +0100 Subject: [PATCH 3/4] gnu: libcanberra: Add propagated-input. * gnu/packages/libcanberra.scm (libcanberra): Add 'sound-theme-freedeskto