Re: [PATCH 3/3] gnu: Add vcsh

2016-02-18 Thread Andreas Enge
On Thu, Feb 18, 2016 at 09:32:52PM +, Christopher Baines wrote: > A patch could be written as Andreas describes (to use a variable), and > then this could be used for Guix. Once written, the patch could also be > sent to the upstream maintainer to see if they want to include it. This would be

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-18 Thread Christopher Baines
On 18/02/16 21:26, Leo Famulari wrote: > On Thu, Feb 18, 2016 at 09:01:00PM +0100, Andreas Enge wrote: >> On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote: >>> I missed this earlier. We don't usually propagate this sort of "end-user >>> program" dependencies. For example rsync does not

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-18 Thread Leo Famulari
On Thu, Feb 18, 2016 at 09:01:00PM +0100, Andreas Enge wrote: > On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote: > > I missed this earlier. We don't usually propagate this sort of "end-user > > program" dependencies. For example rsync does not propagate ssh; the > > user must install s

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-18 Thread Christopher Baines
On 18/02/16 20:01, Andreas Enge wrote: > On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote: >> I missed this earlier. We don't usually propagate this sort of "end-user >> program" dependencies. For example rsync does not propagate ssh; the >> user must install ssh. [0] > > I think the c

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-18 Thread Andreas Enge
On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote: > I missed this earlier. We don't usually propagate this sort of "end-user > program" dependencies. For example rsync does not propagate ssh; the > user must install ssh. [0] I think the cleanest approach would be to patch all calls to

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-17 Thread Christopher Baines
On 18/02/16 00:11, Leo Famulari wrote: > On Wed, Feb 17, 2016 at 06:59:08PM +, Christopher Baines wrote: >> From a4d10c0c98b4b9b3df05951b9a38d37b8b1da6d3 Mon Sep 17 00:00:00 2001 >> From: Christopher Baines >> Date: Sat, 13 Feb 2016 23:49:25 + >> Subject: [PATCH] gnu: Add vcsh >> >> * gnu/

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-17 Thread Leo Famulari
On Wed, Feb 17, 2016 at 06:59:08PM +, Christopher Baines wrote: > From a4d10c0c98b4b9b3df05951b9a38d37b8b1da6d3 Mon Sep 17 00:00:00 2001 > From: Christopher Baines > Date: Sat, 13 Feb 2016 23:49:25 + > Subject: [PATCH] gnu: Add vcsh > > * gnu/packages/version-control.scm (vcsh): New varia

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-17 Thread Christopher Baines
On 17/02/16 18:11, Andreas Enge wrote: > Hello, > > this looks good. I also added a copyright line for you. > > On Sun, Feb 14, 2016 at 08:36:00PM +, Christopher Baines wrote: >> + "vcsh provides the @code{vcsh} command, which allows you to maintain > > I would shorten to "vcsh allows ..

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-17 Thread Andreas Enge
Hello, this looks good. I also added a copyright line for you. On Sun, Feb 14, 2016 at 08:36:00PM +, Christopher Baines wrote: > + "vcsh provides the @code{vcsh} command, which allows you to maintain I would shorten to "vcsh allows ..."; that vcsh provides the vcsh command is close to a

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-14 Thread Christopher Baines
On 13/02/16 22:41, Leo Famulari wrote: > On Sat, Feb 13, 2016 at 04:07:55PM +, Christopher Baines wrote: >> * gnu/packages/version-control.scm (vcsh): New variable. > > [...] > >> +(arguments >> + `(#:phases (modify-phases %standard-phases >> + (delete 'configure) >>

Re: [PATCH 3/3] gnu: Add vcsh

2016-02-13 Thread Leo Famulari
On Sat, Feb 13, 2016 at 04:07:55PM +, Christopher Baines wrote: > * gnu/packages/version-control.scm (vcsh): New variable. [...] > +(arguments > + `(#:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'check) > +

[PATCH 3/3] gnu: Add vcsh

2016-02-13 Thread Christopher Baines
* gnu/packages/version-control.scm (vcsh): New variable. --- gnu/packages/version-control.scm | 38 ++ 1 file changed, 38 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 721a284..fd2056d 100644 --- a/gnu/pack