Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-22 Thread Vincent Legoll
> That’ll happen, someday, but even then, I’m not sure we’ll remove > labels; at least we won’t remove them overnight, for sure. ;-) That may be a good fit for a guix lint warning, maybe first as a --pedantic mode, then after the first rush of newbies-editing-the-world, it can be turned into --We

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-22 Thread Ludovic Courtès
Tobias Geerinckx-Rice skribis: > On 2016-07-21 18:06, l...@gnu.org wrote: (inputs `(("somethingsilly" ,glib "bin"))) >> >> This "somethingsilly" is just a label that allows you to refer to an >> input on the build side, in idioms like: >> >> (assoc-ref inputs "somethingsilly") >> => "/

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-21 Thread Tobias Geerinckx-Rice
Ahoy Ludo', On 2016-07-21 18:06, l...@gnu.org wrote: (inputs `(("somethingsilly" ,glib "bin"))) This "somethingsilly" is just a label that allows you to refer to an input on the build side, in idioms like: (assoc-ref inputs "somethingsilly") => "/gnu/store/…-glib-42.0-bin" I remember

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-21 Thread Ludovic Courtès
Vincent Legoll skribis: > On Thu, Jul 21, 2016 at 2:24 PM, Ludovic Courtès wrote: >> David Craven skribis: >> I think packages with a “bin” output are not always used as native inputs, so I would drop this rule. >>> >>> From searching the code-base we have I couldn't find a counter ex

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-21 Thread Vincent Legoll
On Thu, Jul 21, 2016 at 2:24 PM, Ludovic Courtès wrote: > David Craven skribis: > >>> I think packages with a “bin” output are not always used as native >>> inputs, so I would drop this rule. >> >> From searching the code-base we have I couldn't find a counter example. Do >> you think it's ok to

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-21 Thread Ludovic Courtès
David Craven skribis: >> I think packages with a “bin” output are not always used as native >> inputs, so I would drop this rule. > > From searching the code-base we have I couldn't find a counter example. Do > you think it's ok to check for glib:bin specifically? Yes, sounds good to me. Howeve

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-20 Thread Efraim Flashner
On Wed, Jul 20, 2016 at 12:50:49PM +0200, David Craven wrote: > Hi > > > I think packages with a “bin” output are not always used as native > > inputs, so I would drop this rule. > > From searching the code-base we have I couldn't find a counter example. Do > you think it's ok to check for glib:b

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-20 Thread David Craven
Hi > I think packages with a “bin” output are not always used as native > inputs, so I would drop this rule. >From searching the code-base we have I couldn't find a counter example. Do you think it's ok to check for glib:bin specifically? Thanks David

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-20 Thread Ludovic Courtès
Hi! David Craven skribis: > * guix/scripts/lint.scm (check-inputs-should-be-native): Check that packages > with suffix ':bin' and 'intltool', 'itstool' are in native-inputs. I think packages with a “bin” output are not always used as native inputs, so I would drop this rule. However, the rule

[PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.

2016-07-19 Thread David Craven
* guix/scripts/lint.scm (check-inputs-should-be-native): Check that packages with suffix ':bin' and 'intltool', 'itstool' are in native-inputs. --- guix/scripts/lint.scm | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/guix/scripts/lint.scm b/guix/scripts/lin