Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-02 Thread David Craven
> Now we should be all right. :-) Thank you and sorry!

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-02 Thread Ludovic Courtès
David Craven skribis: > * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable. Commit d26e2b9f306a1170d46f7c860c81840d9d600161 introduced breakage: ‘make’ would fail due to the unbound variable. I fixed it in 47e2fe3cdf0ecfcfc6dccc048d4b1da94fa5a4a2. Ludo’.

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-02 Thread Ludovic Courtès
David Craven skribis: >> Ups I just realized I made a mistake on this commit. > > What do you want me to do? not that I make things worse... This is > what I pushed. > > commit d26e2b9f306a1170d46f7c860c81840d9d600161 > Author: David Craven > Date: Mon Aug 1 16:39:00 2016 +0200 > > gnu: kd

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-02 Thread Andreas Enge
On Tue, Aug 02, 2016 at 01:57:25PM +0200, David Craven wrote: > What do you want me to do? not that I make things worse... This is > what I pushed. > > gnu: kde-frameworks: Remove kde-frameworks-version. > * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable. > (kw

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-02 Thread David Craven
> Ups I just realized I made a mistake on this commit. What do you want me to do? not that I make things worse... This is what I pushed. commit d26e2b9f306a1170d46f7c860c81840d9d600161 Author: David Craven Date: Mon Aug 1 16:39:00 2016 +0200 gnu: kde-frameworks: Remove kde-frameworks-vers

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-02 Thread David Craven
> PS: If you delete the variable, I would do this first and replace its use by the current value in the two (?) packages using it so far, and after that update the packages to their latest versions. I pushed the first 5 commits until and including this one here. Ups I just realized I made a mista

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-01 Thread Andreas Enge
On Mon, Aug 01, 2016 at 10:00:34PM +0200, David Craven wrote: > I thought it would be easier to update, since we prefer each update to > be a commit. If we change the version for all packages at the same > time we could have breakage until they are all updated. With the > auto-updater this doesn't

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-01 Thread David Craven
I thought it would be easier to update, since we prefer each update to be a commit. If we change the version for all packages at the same time we could have breakage until they are all updated. With the auto-updater this doesn't require any manual labor at all.

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-01 Thread Andreas Enge
On Mon, Aug 01, 2016 at 08:13:19PM +0200, David Craven wrote: > * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable. PS: If you delete the variable, I would do this first and replace its use by the current value in the two (?) packages using it so far, and after that update the

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-01 Thread Andreas Enge
On Mon, Aug 01, 2016 at 08:13:19PM +0200, David Craven wrote: > * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable. Should we not keep it? From what I understand, all of KDE, or at least the framework, seems to move in unison. So keeping a unique global variable would making t

[PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

2016-08-01 Thread David Craven
* gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable. --- gnu/packages/kde-frameworks.scm | 2 -- 1 file changed, 2 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 12d9f16..db20690 100644 --- a/gnu/packages/kde-frameworks.scm ++