Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-23 Thread Thompson, David
On Thu, Jul 23, 2015 at 12:46 PM, Cyril Roelandt wrote: > On 07/23/2015 04:06 AM, Thompson, David wrote: >> If they are solely for OpenStack then that's fine. > > I was thinking of having all packages managed by OpenStack inside > openstack.scm. Now obviously, they can be used by anyone, since you

Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-23 Thread Cyril Roelandt
On 07/23/2015 04:06 AM, Thompson, David wrote: > If they are solely for OpenStack then that's fine. I was thinking of having all packages managed by OpenStack inside openstack.scm. Now obviously, they can be used by anyone, since you can just import any Python package from another Python program.

Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-23 Thread Ludovic Courtès
Agreed on all points. We can start a first round of review, though. Ludo’.

Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-22 Thread Thompson, David
On Wed, Jul 22, 2015 at 6:13 PM, Cyril Roelandt wrote: > On 07/20/2015 06:14 PM, Thompson, David wrote: >> On Wed, Jul 15, 2015 at 7:32 PM, Cyril Roelandt wrote: >>> * gnu/packages/openstack.scm: New file. >>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it here. >>> * gnu/packages/python.scm (pytho

Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-22 Thread Ian Denhardt
Quoting Cyril Roelandt (2015-07-22 18:13:22) > Well, in the end, we could have everything from PyPI in python.scm. > OpenStack is a huge project, so I thought it would make sense to have > its packages in their own file. WDYT? This matches my gut as well. -Ian signature.asc Description: signatu

Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-22 Thread Cyril Roelandt
On 07/20/2015 06:14 PM, Thompson, David wrote: > On Wed, Jul 15, 2015 at 7:32 PM, Cyril Roelandt wrote: >> * gnu/packages/openstack.scm: New file. >> * gnu-system.am (GNU_SYSTEM_MODULES): Add it here. >> * gnu/packages/python.scm (python-appdirs, python2-appdirs): New variables. > > Could you bre

Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-22 Thread Cyril Roelandt
On 07/16/2015 01:10 PM, Mathieu Lirzin wrote: > Hi, > > I've not test it but I have some stylistic remarks :). Most of them apply > to other parts of your patch and to the other patches. > Oh, Indeed, I screwed up the indentation everywhere :/ I'll fix it when resending the patches if it is need

Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-20 Thread Thompson, David
On Wed, Jul 15, 2015 at 7:32 PM, Cyril Roelandt wrote: > * gnu/packages/openstack.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it here. > * gnu/packages/python.scm (python-appdirs, python2-appdirs): New variables. Could you break this patch so that there is one package per patch? Al

Re: [PATCH 02/11] gnu: Add oslotest.

2015-07-16 Thread Mathieu Lirzin
Hi, I've not test it but I have some stylistic remarks :). Most of them apply to other parts of your patch and to the other patches. Cyril Roelandt writes: > +(define-public python-mox3 > + (package > + (name "python-mox3") ^ It should be indent under the first 'a'. > + (uri (strin

[PATCH 02/11] gnu: Add oslotest.

2015-07-15 Thread Cyril Roelandt
* gnu/packages/openstack.scm: New file. * gnu-system.am (GNU_SYSTEM_MODULES): Add it here. * gnu/packages/python.scm (python-appdirs, python2-appdirs): New variables. --- gnu-system.am | 1 + gnu/packages/openstack.scm | 179 + gnu/package