Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-03-05 Thread Mark H Weaver
Andreas Enge writes: > On Mon, Mar 02, 2015 at 01:06:30AM -0500, Mark H Weaver wrote: >> I think 宋文武 should push this commit. > > Yes. Unfortunately, automatic upgrades will be broken, so people need to > think of doing them manually. If they installed 'gtk-xfce-engine' directly, that is true.

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-03-02 Thread Andreas Enge
On Sun, Mar 01, 2015 at 06:30:22PM +0800, 宋文武 wrote: > I think that's the reason for a 2.x version. > I feel the commit message or a comment should mention it, > but can't get one myself, any suggestion? How about in the second part: Update to 2 Since upstream stopped support of GTK+ 3, they w

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-03-02 Thread Andreas Enge
On Mon, Mar 02, 2015 at 01:06:30AM -0500, Mark H Weaver wrote: > I think 宋文武 should push this commit. Yes. Unfortunately, automatic upgrades will be broken, so people need to think of doing them manually. Andreas

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-03-01 Thread Mark H Weaver
Andreas Enge writes: > On Sun, Mar 01, 2015 at 01:57:12PM +0800, 宋文武 wrote: >> -(version "3.0.0") >> +(version "2.10.0") > > Something is suspicious here - a downgrade? Yes, it's strange, but compare the versions of gtk-xfce-engine available at these two URLs: http://archive.xfce.org/

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-03-01 Thread David Thompson
宋文武 writes: > * gnu/packages/xfce.scm (gtk-xfce-engine): Update to 2.10.0. > --- > gnu/packages/xfce.scm | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm > index fb5427c..1be28a7 100644 > --- a/gnu/packages/xfce.scm >

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-03-01 Thread 宋文武
Andreas Enge writes: > Apart from that, I think you can push without problem updates in which only > the source and the hash change. OK, I leave gtk-xfce-engine and xfconf for review with other pushed. > > Andreas

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-03-01 Thread 宋文武
Andreas Enge writes: > On Sun, Mar 01, 2015 at 01:57:12PM +0800, 宋文武 wrote: >> -(version "3.0.0") >> +(version "2.10.0") > > Something is suspicious here - a downgrade? Xfce 4.10 did has a 3.0.0 version. http://xfce.org/download/changelogs/4.12 has: Theme Engine (gtk-xfce-engine) Gtk+-

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-03-01 Thread Andreas Enge
On Sun, Mar 01, 2015 at 01:57:12PM +0800, 宋文武 wrote: > -(version "3.0.0") > +(version "2.10.0") Something is suspicious here - a downgrade? Apart from that, I think you can push without problem updates in which only the source and the hash change. Andreas

[PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

2015-02-28 Thread 宋文武
* gnu/packages/xfce.scm (gtk-xfce-engine): Update to 2.10.0. --- gnu/packages/xfce.scm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index fb5427c..1be28a7 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@