Re: [PATCH] services: nginx: Actually check if configuration is valid.

2016-09-09 Thread Ludovic Courtès
Hello, "Thompson, David" skribis: > I mean that it should throw an error before the system is made active. > The derivation that builds the service file should fail. Not > suggesting it needs to be done right now, but I think it would be > cool. Yup. Running “nginx -t” would do the trick, rig

Re: [PATCH] services: nginx: Actually check if configuration is valid.

2016-09-09 Thread Ludovic Courtès
Tobias Geerinckx-Rice skribis: > * gnu/services/web.scm (nginx-activation): Fix path to nginx binary. OK to push! :-) Ludo'.

Re: [PATCH] services: nginx: Actually check if configuration is valid.

2016-09-08 Thread Tobias Geerinckx-Rice
Hi Dave, On 09/09/16 04:29, Thompson, David wrote: > No, it doesn't. I wrote the nginx service. The config file used is > part of the g-expression and is absolutely not stateful. Wait. nckx@v5 ~$ sudo herd restart nginx Service nginx has been stopped. Service nginx has been started. nckx@v5 ~$

Re: [PATCH] services: nginx: Actually check if configuration is valid.

2016-09-08 Thread Thompson, David
On Thu, Sep 8, 2016 at 10:21 PM, Tobias Geerinckx-Rice wrote: > Dave, > > On 09/09/16 04:09, Thompson, David wrote: >> Maybe this could be done at build-time instead? > > The nginx service points to a stateful configuration file, like > /etc/nginx.conf, that isn't built or handled by Guix. No, it

Re: [PATCH] services: nginx: Actually check if configuration is valid.

2016-09-08 Thread Tobias Geerinckx-Rice
Dave, On 09/09/16 04:09, Thompson, David wrote: > Maybe this could be done at build-time instead? The nginx service points to a stateful configuration file, like /etc/nginx.conf, that isn't built or handled by Guix. I'd like that to change, but that will have to wait for now. > Would be nice to

Re: [PATCH] services: nginx: Actually check if configuration is valid.

2016-09-08 Thread Thompson, David
On Thu, Sep 8, 2016 at 10:05 PM, Tobias Geerinckx-Rice wrote: > * gnu/services/web.scm (nginx-activation): Fix path to nginx binary. > --- > > Hullo again! > > I suspect not many people run nginx (or dovecot, but that's a different > matter) on Guix. The nginx activation script will now correctly

[PATCH] services: nginx: Actually check if configuration is valid.

2016-09-08 Thread Tobias Geerinckx-Rice
* gnu/services/web.scm (nginx-activation): Fix path to nginx binary. --- Hullo again! I suspect not many people run nginx (or dovecot, but that's a different matter) on Guix. The nginx activation script will now correctly print a non-fatal error if the configuration smells off. Why I'm mailing: