Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Ludovic Courtès writes: > Heya, > > Roel Janssen skribis: > >> From fcbe7ebb3d205cf7310700e62b78b9aafd94f76f Mon Sep 17 00:00:00 2001 >> From: Roel Janssen >> Date: Thu, 19 Apr 2018 17:11:30 +0200 >> Subject: [PATCH] guix-daemon: Disable garbage collection for remote >> connections. >> >> * n

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Heya, Roel Janssen skribis: > From fcbe7ebb3d205cf7310700e62b78b9aafd94f76f Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Thu, 19 Apr 2018 17:11:30 +0200 > Subject: [PATCH] guix-daemon: Disable garbage collection for remote > connections. > > * nix/nix-daemon/nix-daemon.cc (isRemoteCon

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Roel Janssen writes: > I included a test, but I don't know how I can properly run this test. > Could you elaborate on how I can test the test(s)? [...] > diff --git a/tests/guix-daemon.sh b/tests/guix-daemon.sh > index 6f91eb58b..438c79c26 100644 > --- a/tests/guix-daemon.sh > +++ b/tests/guix-

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Ludovic Courtès writes: > Roel Janssen skribis: > >> Ludovic Courtès writes: > > [...] > diff --git a/nix/nix-daemon/nix-daemon.cc b/nix/nix-daemon/nix-daemon.cc index deb7003d7..65770ba95 100644 --- a/nix/nix-daemon/nix-daemon.cc +++ b/nix/nix-daemon/nix-daemon.cc @@

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Roel Janssen skribis: > Ludovic Courtès writes: [...] >>> diff --git a/nix/nix-daemon/nix-daemon.cc b/nix/nix-daemon/nix-daemon.cc >>> index deb7003d7..65770ba95 100644 >>> --- a/nix/nix-daemon/nix-daemon.cc >>> +++ b/nix/nix-daemon/nix-daemon.cc >>> @@ -529,6 +529,11 @@ static void performOp(

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Ludovic Courtès writes: > Hello Roel, > > Roel Janssen skribis: > [...] > >> From 00f489d6303720c65571fdf0bc9ee810a20f70e0 Mon Sep 17 00:00:00 2001 >> From: Roel Janssen >> Date: Wed, 11 Apr 2018 09:52:11 +0200 >> Subject: [PATCH] guix-daemon: Disable garbage collection for remote hosts. >>

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Hello Roel, Roel Janssen skribis: > Roel Janssen writes: > >> Ludovic Courtès writes: [...] >>> In this case, I thought guix-daemon could explicitly check whether the >>> peer is remote, and disable GC in that case. That is, ‘guix gc’ would >>> still work locally on the machine that runs gu

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Hello! Roel Janssen skribis: > I'm not sure this made it to the mailing list. Is the proposed patch > fine to disable the GC for remote connections? It did make it to the list, I’ll look at it real soon. Ludo’.

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Hello there, I'm not sure this made it to the mailing list. Is the proposed patch fine to disable the GC for remote connections? Thanks! Kind regards, Roel Janssen Roel Janssen writes: > Roel Janssen writes: > >> Ludovic Courtès writes: >> >>> Hello Roel, >>> >>> Roel Janssen skribis: >>

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Roel Janssen writes: > Ludovic Courtès writes: > >> Hello Roel, >> >> Roel Janssen skribis: >> >>> The patch adds a “disableGarbageCollection” boolean variable to the >>> guix-daemon settings, and on each occasion where a store item may be >>> deleted, it checks this option. >>> >>> This optio

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Ludovic Courtès writes: > Hello Roel, > > Roel Janssen skribis: > >> The patch adds a “disableGarbageCollection” boolean variable to the >> guix-daemon settings, and on each occasion where a store item may be >> deleted, it checks this option. >> >> This option can be set using “--disable-gc”.

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Hello Roel, Roel Janssen skribis: > The patch adds a “disableGarbageCollection” boolean variable to the > guix-daemon settings, and on each occasion where a store item may be > deleted, it checks this option. > > This option can be set using “--disable-gc”. > > It would be great if someone could

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Adam Van Ymeren writes: > Just out of curiosity, what is your situation where the daemon can't > see all GC roots? Are you sharing the store over NFS or something? Yes. And the underlying storage system is configured in such a way that “root” is not allowed to look into user's folders. Kind

Re: [PATCH] guix-daemon: Add option to disable garbage collection.

Just out of curiosity, what is your situation where the daemon can't see all GC roots? Are you sharing the store over NFS or something?On 3 Apr 2018 6:12 a.m., Roel Janssen wrote: > > Dear Guix, > > I have an interesting situation where the guix-daemon cannot see all > directories that (may)

[PATCH] guix-daemon: Add option to disable garbage collection.

h a feature. And to point out what else would be needed to include this option in guix-daemon. Thank you for your time. Kind regards, Roel Janssen >From d842f320f0ee911d7d219bba7baa45240edcbe6d Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Tue, 3 Apr 2018 11:22:16 +0200 Subject: [PATCH]