Re: [PATCH] gnu: Add urwid

2015-02-03 Thread Ludovic Courtès
Omar Radwan skribis: >>I'm sorry, but we are failing to >communicate, and I don't have any >more >>time to spend on this. I have pushed >commit e99f421185 based on your >>preliminary work. It adds two >packages: python-urwid for Python 3, >and >>python2-urwid for Python 2. > > Sorry for the mis

Re: [PATCH] gnu: Add urwid

2015-02-03 Thread Omar Radwan
>I'm sorry, but we are failing to >communicate, and I don't have any >more >time to spend on this. I have pushed >commit e99f421185 based on your >preliminary work. It adds two >packages: python-urwid for Python 3, >and >python2-urwid for Python 2. Sorry for the miscommunication. I'll do better

Re: [PATCH] gnu: Add urwid

2015-02-02 Thread Mark H Weaver
Omar Radwan writes: >>What was the error? I tested the >package with all of the > modifications >>I suggested, including this one, and it >built successfully on my > i686 >>machine. > It didn't build on my 64bit machine. And just to be clear. I tried to > substitute it for inputs and that didn't

Re: [PATCH] gnu: Add urwid

2015-02-02 Thread Omar Radwan
>What was the error? I tested the >package with all of the modifications >I suggested, including this one, and it >built successfully on my i686 >machine. It didn't build on my 64bit machine. And just to be clear. I tried to substitute it for inputs and that didn't work. Was I supposed to put it i

Re: [PATCH] gnu: Add urwid

2015-02-02 Thread Mark H Weaver
Omar Radwan writes: > Here is it, finally I hope this is good enough. > > And by the way, you asked for me to do this > >> (arguments `(#:python ,python-2)) > > instead of what I did before, but that gives me an error, so I can't > build it, so I hope it's ok if I leave it the way it is. What w

Re: [PATCH] gnu: Add urwid

2015-02-02 Thread Omar Radwan
o run "./pre-inst-env guix lint PACKAGE" > before you submit your patch, it catches some common problems. > > Andreas > > From 7d9f79c3e4b6e4121c0304d5da3995a2f3473fe0 Mon Sep 17 00:00:00 2001 From: Omar Radwan Date: Mon, 2 Feb 2015 18:28:21 -0800 Subject: [PATCH] gnu: Add

Re: [PATCH] gnu: Add urwid

2015-02-02 Thread Andreas Enge
On Mon, Feb 02, 2015 at 09:46:10AM -0800, Omar Radwan wrote: > I was in such a hurry. I'll get it in asap That sounds like a contradiction! Take your time ;-) You may also want to run "./pre-inst-env guix lint PACKAGE" before you submit your patch, it catches some common problems. Andreas

Re: [PATCH] gnu: Add urwid

2015-02-02 Thread Omar Radwan
My mistake. I was in such a hurry. I'll get it in asap On Feb 1, 2015 9:42 PM, "Mark H Weaver" wrote: > Omar Radwan writes: > > Here's a patch that does all the changes you requested to the previous > > patch file > > A few problems here: > > (1) This new version doesn't even compile, because of

Re: [PATCH] gnu: Add urwid

2015-02-01 Thread Mark H Weaver
Omar Radwan writes: > Here's a patch that does all the changes you requested to the previous > patch file A few problems here: (1) This new version doesn't even compile, because of several typos. Please always test before sending patches. (2) Instead of sending a patch that assumes the firs

Re: [PATCH] gnu: Add urwid

2015-02-01 Thread Omar Radwan
ate: Sun, 1 Feb 2015 14:43:59 -0800 > > Subject: [PATCH] gnu: Add urwid > > Minor nits: add a period above, and: > > > * gnu/packages/python.scm(urwid) New variable. > > This should be: > > * gnu/packages/python.scm (urwid): New variable. > > (add

Re: [PATCH] gnu: Add urwid

2015-02-01 Thread Mark H Weaver
Omar Radwan writes: > From 7d65731aaec1b3dbca9364bc2b0f18c9fc9992e5 Mon Sep 17 00:00:00 2001 > From: Omar Radwan > Date: Sun, 1 Feb 2015 14:43:59 -0800 > Subject: [PATCH] gnu: Add urwid Minor nits: add a period above, and: > * gnu/packages/python.scm(urwid) New variable.

Re: [PATCH] gnu: Add urwid

2015-02-01 Thread Omar Radwan
tomorrow, and hopefully finish by next week. >> > From 7d65731aaec1b3dbca9364bc2b0f18c9fc9992e5 Mon Sep 17 00:00:00 2001 From: Omar Radwan Date: Sun, 1 Feb 2015 14:43:59 -0800 Subject: [PATCH] gnu: Add urwid * gnu/packages/python.scm(urwid) New variable. --- gnu/packages/python.scm

Re: [PATCH] gnu: Add urwid

2015-02-01 Thread Omar Radwan
Wow. I was in such a hurry I forgot to add the patch file On Feb 1, 2015 2:56 PM, "Omar Radwan" wrote: > Here is a patch to add urwid, which is required for wicd, which I will be > working on tomorrow, and hopefully finish by next week. >

[PATCH] gnu: Add urwid

2015-02-01 Thread Omar Radwan
Here is a patch to add urwid, which is required for wicd, which I will be working on tomorrow, and hopefully finish by next week.