On Fri, Feb 12, 2016 at 05:23:22PM -0500, Leo Famulari wrote:
> On Fri, Feb 12, 2016 at 05:33:29PM +0100, Jan Nieuwenhuizen wrote:
> > Leo Famulari writes:
> >
> > >> Can you check if it works for you? I don't really know how to test this
> > >> package.
> > >
> > > My apologies is that patch seri
On Fri, Feb 12, 2016 at 05:33:29PM +0100, Jan Nieuwenhuizen wrote:
> Leo Famulari writes:
>
> >> Can you check if it works for you? I don't really know how to test this
> >> package.
> >
> > My apologies is that patch series does not apply. I have attached
> > another.
>
> Works for me; however,
Leo Famulari writes:
>> Can you check if it works for you? I don't really know how to test this
>> package.
>
> My apologies is that patch series does not apply. I have attached
> another.
Works for me; however, 0002-gnu-tcl-Use-tcl-tk-license.patch somehow
includes a bit from my tclxml patch (t
Hi!
I agree with Pjotr: we need to pay special attention to the way we
review patches coming from newcomers. If a first patch triggers loads
of whitespace issues, that can be discouraging. So I think it’s a good
idea to take extra time to fix trivial things in patches from newcomers
and just let
Leo Famulari skribis:
> Does anyone object to having a slash in the license variable name? I
> don't know whether or not its "safe" [0].
There’s no problem with that, pretty much anything can be used in Scheme
identifiers.
Ludo’.
On Fri, Feb 12, 2016 at 12:19:14AM -0500, Leo Famulari wrote:
[...]
> Can you check if it works for you? I don't really know how to test this
> package.
My apologies is that patch series does not apply. I have attached
another.
>From 4f0a408aa2e26be245010951289b07f4db9c3326 Mon Sep 17 00:00:00 2
On Thu, Feb 11, 2016 at 10:11:07PM +0100, Jan Nieuwenhuizen wrote:
> Efraim Flashner writes:
>
> Thanks for looking in so much detail! New patch set attached.
>
> >> +(native-search-paths
> >> + (list (search-path-specification
> > I don't think this needs to be a list
>
> Yes, so it se
Efraim Flashner writes:
> Pjotr- thanks for the reminder :). I know we've been a bit behind on patch
> review and I jumped in a bit too much.
>
> Jan- I hope I haven't scared you off or discouraged you. Indeed, thank you
> for the patches.
Thanks for the headsup!
Greetings, Jan
--
Jan Nieuwenh
Efraim Flashner writes:
Thanks for looking in so much detail! New patch set attached.
>> +(native-search-paths
>> + (list (search-path-specification
> I don't think this needs to be a list
Yes, so it seems.
Still, I left (list) in for now as I feel uncomfortable changing 40
other packa
On Thu, 11 Feb 2016 21:28:33 +0100
Pjotr Prins wrote:
> To all.
>
> Again, I think we have to be more careful with new committers. All
> comments below are in the trivial category (in my opinion).
>
> I appreciate the work reviewers are doing (thank you!), but we should
> take care to be nice
> On Tue, 09 Feb 2016 21:19:35 +0100
> Jan Nieuwenhuizen wrote:
>
> > From: Jan Nieuwenhuizen
> > To: guix-devel@gnu.org
> > Subject: [PATCH] gnu: Add tcllib.
> > Date: Tue, 09 Feb 2016 21:19:35 +0100
> > Sender: guix-devel-bounces+efraim=flashner.co...@g
On Tue, 09 Feb 2016 21:19:35 +0100
Jan Nieuwenhuizen wrote:
> From: Jan Nieuwenhuizen
> To: guix-devel@gnu.org
> Subject: [PATCH] gnu: Add tcllib.
> Date: Tue, 09 Feb 2016 21:19:35 +0100
> Sender: guix-devel-bounces+efraim=flashner.co...@gnu.org
> User-Agent: Gnus/5.13
Hi,
A "new" package.
Greetings, Jan
>From 51f0b17b38385197240bca37b290730b2fbe5df1 Mon Sep 17 00:00:00 2001
From: Jan Nieuwenhuizen
Date: Tue, 9 Feb 2016 20:44:59 +0100
Subject: [PATCH] gnu: Add tcllib.
* gnu/packages/tcl.scm (tcllib): New variable.
---
gnu/packages
13 matches
Mail list logo
