Re: [PATCH] gnu: Add ruby 1.8.7 package

2015-06-19 Thread Thompson, David
On Tue, Jun 16, 2015 at 11:46 AM, Pjotr Prins wrote: > Anything wrong with this patch? > > On Sun, Jun 14, 2015 at 10:36:40AM +0200, Pjotr Prins wrote: >> From be945cf4d65ab77eb8bd7a462aa0b7d24877ba74 Mon Sep 17 00:00:00 2001 >> From: pjotrp >> Date: Sat, 13 Jun 2015 13:22:10 +0200 >> Subject: [P

Re: [PATCH] gnu: Add ruby 1.8.7 package

2015-06-16 Thread Thompson, David
On Tue, Jun 16, 2015 at 11:46 AM, Pjotr Prins wrote: > Anything wrong with this patch? > > On Sun, Jun 14, 2015 at 10:36:40AM +0200, Pjotr Prins wrote: >> From be945cf4d65ab77eb8bd7a462aa0b7d24877ba74 Mon Sep 17 00:00:00 2001 >> From: pjotrp >> Date: Sat, 13 Jun 2015 13:22:10 +0200 >> Subject: [P

Re: [PATCH] gnu: Add ruby 1.8.7 package

2015-06-16 Thread Pjotr Prins
Anything wrong with this patch? On Sun, Jun 14, 2015 at 10:36:40AM +0200, Pjotr Prins wrote: > From be945cf4d65ab77eb8bd7a462aa0b7d24877ba74 Mon Sep 17 00:00:00 2001 > From: pjotrp > Date: Sat, 13 Jun 2015 13:22:10 +0200 > Subject: [PATCH] gnu: Add ruby 2.1.6 > > * gnu/packages/ruby.scm (ruby-2.

Re: [PATCH] gnu: Add ruby 1.8.7 package

2015-06-14 Thread Pjotr Prins
Attached a patch for adding Ruby 2.1.6. It works for me. This is to try developing and supporting gems that do not necessarily work with (latest) Ruby 2.2.2. It is also useful for the Rails people. We ought to add Ruby 1.9 too, as well as (eventually) Rubinius (LLVM) and JRuby (JVM). It may appea

Re: [PATCH] gnu: Add ruby 1.8.7 package

2014-10-27 Thread Mark H Weaver
Pjotr Prins writes: > * gnu/packages/ruby.scm: (ruby-1.8): New variable. I pushed this with some minor changes to the commit log, and with the unneeded (guix hash) import removed. I also followed it up with another commit making some improvements to the original ruby package. Thanks!

[PATCH] gnu: Add ruby 1.8.7 package

2014-10-26 Thread Pjotr Prins
* gnu/packages/ruby.scm: (ruby-1.8): New variable. fixes --- gnu/packages/ruby.scm | 29 + 1 file changed, 29 insertions(+) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index ac751f5..d6f86a5 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ru

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Pjotr Prins
On Sun, Oct 26, 2014 at 07:33:51PM -0400, Mark H Weaver wrote: > > +(define-public ruby-1.8 > > + (package (inherit ruby) > > +(name "ruby") > > Is there a reason to repeat the 'name' field here? > It should be inherited. it won't compile without.

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Mark H Weaver
Pjotr Prins writes: > On Sun, Oct 26, 2014 at 09:43:22PM -0400, Mark H Weaver wrote: >> In broad strokes, we use the GNU changelog conventions: >> >> http://www.gnu.org/prep/standards/html_node/Change-Logs.html >> >> but with some minor formatting differences. However, the best thing is >> t

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Pjotr Prins
On Sun, Oct 26, 2014 at 09:43:22PM -0400, Mark H Weaver wrote: > In broad strokes, we use the GNU changelog conventions: > > http://www.gnu.org/prep/standards/html_node/Change-Logs.html > > but with some minor formatting differences. However, the best thing is > to look in the commit history f

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Mark H Weaver
Pjotr Prins writes: > On Sun, Oct 26, 2014 at 07:33:51PM -0400, Mark H Weaver wrote: >> Pjotr Prins writes: >> > * gnu/packages/ruby.scm: Added older Ruby 1.8.7 >> >> According to our conventions, this should be: >> >> * gnu/packages/ruby.scm (ruby-1.8): New variable. > > Is a new package

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Pjotr Prins
On Sun, Oct 26, 2014 at 08:53:39PM -0400, David Thompson wrote: > (native-search-paths '()) Ah, I tried #f. > Does Ruby 1.8.7 not know about GEM_PATH because rubygems was a separate > package at that time? Yep. It was not a core feature at the time. Pj.

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread David Thompson
Pjotr Prins writes: > On Mon, Oct 27, 2014 at 12:44:36AM +0100, Pjotr Prins wrote: >> > It looks like the 'native-search-paths' field needs to be overridden, >> > since the existing one has "2.1.3" in it. >> >> I don't think it is used by 1.8.7. Does that matter? > > How would I override it as j

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Pjotr Prins
On Mon, Oct 27, 2014 at 12:44:36AM +0100, Pjotr Prins wrote: > > It looks like the 'native-search-paths' field needs to be overridden, > > since the existing one has "2.1.3" in it. > > I don't think it is used by 1.8.7. Does that matter? How would I override it as just being empty? Pj.

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Pjotr Prins
On Sun, Oct 26, 2014 at 07:33:51PM -0400, Mark H Weaver wrote: > Pjotr Prins writes: > > * gnu/packages/ruby.scm: Added older Ruby 1.8.7 > > According to our conventions, this should be: > > * gnu/packages/ruby.scm (ruby-1.8): New variable. Is a new package a variable? We used the same me

Re: [PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Mark H Weaver
Pjotr Prins writes: > * gnu/packages/ruby.scm: Added older Ruby 1.8.7 According to our conventions, this should be: * gnu/packages/ruby.scm (ruby-1.8): New variable. > --- > gnu/packages/ruby.scm | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/gnu/pa

[PATCH] gnu: Add ruby 1.8.7

2014-10-26 Thread Pjotr Prins
* gnu/packages/ruby.scm: Added older Ruby 1.8.7 --- gnu/packages/ruby.scm | 27 +++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index ac751f5..31cbe54 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -8