Chris Marusich skribis:
> Thanks for the response. The module is primarily a backport, but it also
> contains some features that are not part of the standard library.
> Therefore, it is not exactly the same as the Python standard library's
> contextlib module, even in Python 3. Since the module n
was
> >> also late for other reasons ;-), but still, I think it’d be great if you
> >> could avoid top-posting.
> >
> > Thanks for pointing this out; I'll reply on the bottom from now on!
>
> Thanks. :-)
>
> > From 4089b10f384b38576dfc876
b38576dfc8766c661a5787a4b Mon Sep 17 00:00:00 2001
> From: Chris Marusich
> Date: Mon, 7 Dec 2015 21:07:40 -0800
> Subject: [PATCH] gnu: Add python-contextlib2.
>
> * gnu/packages/python.scm (python-contextlib2, python2-contextlib2):
> New variables.
[...]
> +(home-
Hi,
On 12/6/15, Ludovic Courtès wrote:
> Yes, could you adjust it and send an updated patch?
>
I've attached the new patch here. I've shortened a few lines,
including the one requested.
In particular, I've shortened every line of the description to 70
columns. Because of that, it looks like the
Chris Marusich skribis:
> Yes, your explanation about the quoting makes sense. Also, it looks like
> you were right: the PYTHONPATH leaked from my current environment. Thank
> you for your help.
You’re welcome!
> Would you like me to adjust the length of the longest line as mentioned by
> Ben,
Hi Ludo',
Yes, your explanation about the quoting makes sense. Also, it looks like
you were right: the PYTHONPATH leaked from my current environment. Thank
you for your help.
Would you like me to adjust the length of the longest line as mentioned by
Ben, or is my patch good to go as-is?
Thank yo
Hi!
Sorry for the delay.
Chris Marusich skribis:
> However, there is one curiosity. I've noticed that when I run
> "./pre-inst-env guix environment python2-contextlib2", the PYTHONPATH
> is configured to allow importation of contextlib2 from the
> $profile/lib/python3.4/site-packages directory
Hi,
Thank you for the feedback, Ben and Andreas! I did not know about the
"modify-phases" procedure. That's very useful. I've attached the
modified patch. I've confirmed for both packages that "guix lint" does
not show any errors, that the build succeeds (and tests are run
successfully), and that
Hi there.
On 18/11/15 18:31, Chris Marusich wrote:
Hi,
I've packaged contextlib2. This is my first submission, so please let
me know if there is anything that should be different about the
changes I've made. Also, if there's anything odd about the way I've
formatted these patches or this email,
Hello,
and congratulations for your first package!
Upon a quick glance, I have the following comments:
> gnu: Add python-contextlib2
Please add a "." at the end of the line.
> * gnu/packages/python.scm (python-contextlib2, python2-contextlib2):
> New variables.
> gnu/packages/patches/pytho
Hi,
I'll respond to one of my own questions:
> In particular, I'm curious to know if it's required to include
> python-setuptools as an input. It seems that the Python build system
> is including this build dependency by default, so I've omitted it.
Actually, contextlib2 only requires the built-
Hi,
I've packaged contextlib2. This is my first submission, so please let
me know if there is anything that should be different about the
changes I've made. Also, if there's anything odd about the way I've
formatted these patches or this email, please let me know so I can
correct it next time.
In
12 matches
Mail list logo
